From: David Gibson <david@gibson.dropbear.id.au>
To: ehabkost@redhat.com
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH 1/3] adb: Correct class size on TYPE_ADB_DEVICE
Date: Tue, 25 Aug 2020 21:16:25 +1000 [thread overview]
Message-ID: <20200825111627.2007820-2-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20200825111627.2007820-1-david@gibson.dropbear.id.au>
The TypeInfo incorrectly just lets the class size be inherited. It won't
actually break things, since the class is abstract, but we should get it
right.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
hw/input/adb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/input/adb.c b/hw/input/adb.c
index 013fcc9c54..84331b9fce 100644
--- a/hw/input/adb.c
+++ b/hw/input/adb.c
@@ -309,6 +309,7 @@ static void adb_device_class_init(ObjectClass *oc, void *data)
static const TypeInfo adb_device_type_info = {
.name = TYPE_ADB_DEVICE,
.parent = TYPE_DEVICE,
+ .class_size = sizeof(ADBDeviceClass),
.instance_size = sizeof(ADBDevice),
.abstract = true,
.class_init = adb_device_class_init,
--
2.26.2
next prev parent reply other threads:[~2020-08-25 11:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 11:16 [PATCH 0/3] ppc: Fixes for class and instance size problems David Gibson
2020-08-25 11:16 ` David Gibson [this message]
2020-09-01 9:56 ` [PATCH 1/3] adb: Correct class size on TYPE_ADB_DEVICE Philippe Mathieu-Daudé
2020-08-25 11:16 ` [PATCH 2/3] ppc/pnv: Fix TypeInfo of PnvLpcController abstract class David Gibson
2020-09-01 9:56 ` Philippe Mathieu-Daudé
2020-08-25 11:16 ` [PATCH 3/3] spapr: Correct type for SPAPR_DRC_PCI David Gibson
2020-08-26 16:21 ` Eduardo Habkost
2020-08-31 23:52 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200825111627.2007820-2-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).