From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6DB5C433E1 for ; Tue, 25 Aug 2020 15:14:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A07B72075F for ; Tue, 25 Aug 2020 15:14:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="R5NPeFwc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A07B72075F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44220 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kAae8-0002dH-U4 for qemu-devel@archiver.kernel.org; Tue, 25 Aug 2020 11:14:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57562) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kAadD-0001p6-GD for qemu-devel@nongnu.org; Tue, 25 Aug 2020 11:13:03 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:53437 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kAadB-0004hI-Ld for qemu-devel@nongnu.org; Tue, 25 Aug 2020 11:13:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598368380; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LUnmGnu2mO7s2oEtJY94/fVSCdojgQcwX0izETK+jfs=; b=R5NPeFwc4YfbgcRwCveODqq4BYH3k6pIA6B6IAT0Xch1KUucdRdBYrqKPN1x+AfHBx9hfT 1KGmleQvYqVEkNClInpXxR+Lmqa3UNQjIImQZZBJKZr7hctwinTaiQ7Ktuu0gqODRZM5wa 5Mu+v+fm74SvGa7gHA1Lnjms5KGzVXw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-67-hwBvBsXgOCmBVdvxjGmh3g-1; Tue, 25 Aug 2020 11:12:49 -0400 X-MC-Unique: hwBvBsXgOCmBVdvxjGmh3g-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 089DB8E0AF3; Tue, 25 Aug 2020 15:12:01 +0000 (UTC) Received: from redhat.com (ovpn-114-231.ams2.redhat.com [10.36.114.231]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C4F001F2; Tue, 25 Aug 2020 15:11:59 +0000 (UTC) Date: Tue, 25 Aug 2020 16:11:56 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: marcandre.lureau@redhat.com Subject: Re: [PATCH 5/5] meson: add NSIS building Message-ID: <20200825151156.GW107278@redhat.com> References: <20200825150409.346957-1-marcandre.lureau@redhat.com> <20200825150409.346957-6-marcandre.lureau@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200825150409.346957-6-marcandre.lureau@redhat.com> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline Received-SPF: pass client-ip=207.211.31.120; envelope-from=berrange@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/25 01:37:44 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.958, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, sw@weilnetz.de Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Aug 25, 2020 at 07:04:09PM +0400, marcandre.lureau@redhat.com wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > Makefile | 56 ----------------------------------------------- > meson.build | 24 ++++++++++++++++++++ > scripts/nsis.sh | 58 +++++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 82 insertions(+), 56 deletions(-) > create mode 100755 scripts/nsis.sh I feel like one of the bug improvements of Meson over a traditional configure+make type approach is that we get much improved platform portability by default in the build system, largely for free from Meson and in turn Python. With this in mind, I think that as a general goal, we should strive to eliminate any and all use of shell in the build system, standardizing on Python for any helper programs we need to run from Meson. This is a verbose way of saying I think you should create a nsis.py, not nsis.sh, to avoid the inherant portability problems of shell that hit us over and over and over again. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|