qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: marcandre.lureau@redhat.com
Cc: sw@weilnetz.de, qemu-devel@nongnu.org, pbonzini@redhat.com
Subject: Re: [PATCH v2 4/5] meson: use meson mandir instead of qemu_mandir
Date: Wed, 26 Aug 2020 09:33:24 +0100	[thread overview]
Message-ID: <20200826083324.GF168515@redhat.com> (raw)
In-Reply-To: <20200825175827.355940-5-marcandre.lureau@redhat.com>

On Tue, Aug 25, 2020 at 09:58:26PM +0400, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> When cross-compiling, by default qemu_mandir is 'c:\Program
> Files\QEMU', which is not recognized as being an absolute path, and
> meson will end up adding the prefix again.
> 
> Use the pre-prefixed meson mandir option instead.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  reply	other threads:[~2020-08-26  8:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-25 17:58 [PATCH v2 0/5] meson: mingw installation fixes & nsis conversion marcandre.lureau
2020-08-25 17:58 ` [PATCH v2 1/5] meson: pass confsuffix option marcandre.lureau
2020-08-26  8:28   ` Daniel P. Berrangé
2020-08-25 17:58 ` [PATCH v2 2/5] meson: use meson datadir instead of qemu_datadir marcandre.lureau
2020-08-26  8:29   ` Daniel P. Berrangé
2020-08-26  8:53     ` Marc-André Lureau
2020-08-26  9:45       ` Paolo Bonzini
2020-08-25 17:58 ` [PATCH v2 3/5] meson: add docdir option and pass pre-prefix qemu_docdir marcandre.lureau
2020-08-26  8:32   ` Daniel P. Berrangé
2020-08-26  8:38     ` Marc-André Lureau
2020-08-25 17:58 ` [PATCH v2 4/5] meson: use meson mandir instead of qemu_mandir marcandre.lureau
2020-08-26  8:33   ` Daniel P. Berrangé [this message]
2020-08-25 17:58 ` [PATCH v2 5/5] meson: add NSIS building marcandre.lureau
2020-08-26  8:40   ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200826083324.GF168515@redhat.com \
    --to=berrange@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).