From: Pavel Pisa <pisa@cmp.felk.cvut.cz>
To: Vikram Garhwal <fnu.vikram@xilinx.com>
Cc: Marek Vasut <marex@denx.de>, Jiri Novak <jnovak@fel.cvut.cz>,
Oliver Hartkopp <socketcan@hartkopp.net>,
Deniz Eren <deniz.eren@icloud.com>,
qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
Oleksij Rempel <o.rempel@pengutronix.de>,
Konrad Frederic <frederic.konrad@adacore.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
Jan Charvat <charvj10@fel.cvut.cz>,
Stefan Hajnoczi <stefanha@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Ondrej Ille <ondrej.ille@gmail.com>
Subject: Re: [PATCH v1 3/6] net/can: Add can_dlc2len and can_len2dlc for CAN FD.
Date: Thu, 3 Sep 2020 08:12:42 +0200 [thread overview]
Message-ID: <202009030812.42855.pisa@cmp.felk.cvut.cz> (raw)
In-Reply-To: <20200903054329.GA405867@xilinx.com>
Hello Vikram,
On Thursday 03 of September 2020 07:43:34 Vikram Garhwal wrote:
> On Tue, Jul 14, 2020 at 02:20:16PM +0200, pisa@cmp.felk.cvut.cz wrote:
> Hi Pavel,
>
> > From: Jan Charvat <charvj10@fel.cvut.cz>
> >
> > Signed-off-by: Jan Charvat <charvj10@fel.cvut.cz>
> > Signed-off-by: Pavel Pisa <pisa@cmp.felk.cvut.cz>
> > ---
> > include/net/can_emu.h | 4 ++++
> > net/can/can_core.c | 36 ++++++++++++++++++++++++++++++++++++
> > 2 files changed, 40 insertions(+)
> >
> > diff --git a/include/net/can_emu.h b/include/net/can_emu.h
> > index c6164dcfb4..7d395fbb9b 100644
> > --- a/include/net/can_emu.h
> > +++ b/include/net/can_emu.h
> > @@ -127,4 +127,8 @@ int can_bus_client_set_filters(CanBusClientState *,
> > const struct qemu_can_filter *filters,
> > size_t filters_cnt);
> >
> > +uint8_t can_dlc2len(uint8_t can_dlc);
> > +
> > +uint8_t can_len2dlc(uint8_t len);
> > +
>
> These function are aimed for canfd. Perhaps rename these to canfd_dlc2len
> and canfd_len2dlc for better distinction?
> Rest of the patch looks good to me.
I do not insits on name. But function correspond 1:1 to the Linux
kernel ones
https://elixir.bootlin.com/linux/latest/source/drivers/net/can/dev.c#L34
These functions/tables are very short, but may it be, we should add comment
about their origin. This part of original file is Oliver Hartkopp
contribution
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/net/can/dev.c?h=v5.9-rc3&id=1e0625facab2e871472472b7df87d8fbe6caf75a
some other helpers are from Wolfgang Grandegger and me.
Best wishes,
Pavel
next prev parent reply other threads:[~2020-09-03 6:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 12:20 [PATCH v1 0/6] CTU CAN FD core support pisa
2020-07-14 12:20 ` [PATCH v1 1/6] net/can: Initial host SocketCan support for CAN FD pisa
2020-09-01 20:01 ` Vikram Garhwal
2020-09-02 7:51 ` Pavel Pisa
2020-09-03 5:20 ` Vikram Garhwal
2020-09-03 5:29 ` Vikram Garhwal
2020-07-14 12:20 ` [PATCH v1 2/6] hw/net/can: sja1000 ignore CAN FD frames pisa
2020-09-01 17:07 ` Vikram Garhwal
2020-07-14 12:20 ` [PATCH v1 3/6] net/can: Add can_dlc2len and can_len2dlc for CAN FD pisa
2020-09-03 5:43 ` Vikram Garhwal
2020-09-03 6:12 ` Pavel Pisa [this message]
2020-09-03 6:38 ` Vikram Garhwal
2020-07-14 12:20 ` [PATCH v1 4/6] hw/net/can/ctucafd: Add CTU CAN FD core register definitions pisa
2020-07-14 12:20 ` [PATCH v1 5/6] hw/net/can: CTU CAN FD IP open hardware core emulation pisa
2020-07-24 9:46 ` Pavel Pisa
2020-07-14 12:20 ` [PATCH v1 6/6] hw/net/can: Documentation for " pisa
2020-07-14 12:47 ` [PATCH v1 0/6] CTU CAN FD core support no-reply
2020-07-14 13:45 ` [PATCH v1 0/6] CTU CAN FD core support - patchew report Pavel Pisa
2020-07-14 12:48 ` [PATCH v1 0/6] CTU CAN FD core support no-reply
2020-07-30 15:29 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202009030812.42855.pisa@cmp.felk.cvut.cz \
--to=pisa@cmp.felk.cvut.cz \
--cc=armbru@redhat.com \
--cc=charvj10@fel.cvut.cz \
--cc=deniz.eren@icloud.com \
--cc=fnu.vikram@xilinx.com \
--cc=frederic.konrad@adacore.com \
--cc=jan.kiszka@siemens.com \
--cc=jnovak@fel.cvut.cz \
--cc=marex@denx.de \
--cc=o.rempel@pengutronix.de \
--cc=ondrej.ille@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=socketcan@hartkopp.net \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).