qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Bulekov <alxndr@bu.edu>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Laurent Vivier <lvivier@redhat.com>,
	Thomas Huth <thuth@redhat.com>,
	qemu-devel@nongnu.org, darren.kenny@oracle.com, bsd@redhat.com,
	stefanha@redhat.com, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v3 03/16] fuzz: Add PCI features to the general fuzzer
Date: Mon, 21 Sep 2020 10:41:39 -0400	[thread overview]
Message-ID: <20200921144139.r424ql3ck2dvih2m@mozz.bu.edu> (raw)
In-Reply-To: <407cc86f-a705-115d-dd75-2d1c899811cd@redhat.com>

On 200921 0744, Philippe Mathieu-Daudé wrote:
> On 9/21/20 4:24 AM, Alexander Bulekov wrote:
> > This patch compares TYPE_PCI_DEVICE objects against the user-provided
> > matching pattern. If there is a match, we use some hacks and leverage
> > QOS to map each possible BAR for that device. Now fuzzed inputs might be
> > converted to pci_read/write commands which target specific. This means
> > that we can fuzz a particular device's PCI configuration space,
> > 
> > Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
> > Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
> > ---
> >  tests/qtest/fuzz/general_fuzz.c | 81 +++++++++++++++++++++++++++++++++
> >  1 file changed, 81 insertions(+)
> > 
> > diff --git a/tests/qtest/fuzz/general_fuzz.c b/tests/qtest/fuzz/general_fuzz.c
> > index bf75b215ca..7c4c1398a7 100644
> > --- a/tests/qtest/fuzz/general_fuzz.c
> > +++ b/tests/qtest/fuzz/general_fuzz.c
> > @@ -24,6 +24,7 @@
> >  #include "exec/ramblock.h"
> >  #include "exec/address-spaces.h"
> >  #include "hw/qdev-core.h"
> > +#include "hw/pci/pci.h"
> >  
> >  /*
> >   * SEPARATOR is used to separate "operations" in the fuzz input
> > @@ -35,12 +36,17 @@ enum cmds {
> >      OP_OUT,
> >      OP_READ,
> >      OP_WRITE,
> > +    OP_PCI_READ,
> > +    OP_PCI_WRITE,
> >      OP_CLOCK_STEP,
> >  };
> 
> As there is no versioning, does adding new commands
> invalidates the corpus?
> 
> [...]
>

Yes. I think there are a few approaches:
1.) Write a separate OP parser/converter in python that will convert the
corpus to a newer version. Each time we change the code:
    a. write a converter
    b. download corpus from oss-fuzz
    c. convert the corpus
    d. commit new corpus to the seed corpus repo (we don't have one
    right now)
2.) Same as (1) but instead of corpus_v1 -> corpus_v2, 
try to convert corpus_v1 -> qtest commands -> corpus_v2
3.) Use 1st byte to pick corpus format version. I think this could lead
to a lot of code-bloat and could hurt fuzzing performance (fuzzer
mutations could make new inputs that still use old corpus versions)...
4.) Do nothing and wait..

Do you have any suggestion?
-Alex


  reply	other threads:[~2020-09-21 14:44 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-21  2:24 [PATCH v3 00/16] Add a General Virtual Device Fuzzer Alexander Bulekov
2020-09-21  2:24 ` [PATCH v3 01/16] memory: Add FlatView foreach function Alexander Bulekov
2020-10-08  6:57   ` Paolo Bonzini
2020-09-21  2:24 ` [PATCH v3 02/16] fuzz: Add general virtual-device fuzzer Alexander Bulekov
2020-09-21  5:43   ` Philippe Mathieu-Daudé
2020-09-21 14:34     ` Alexander Bulekov
2020-10-01 15:29       ` Darren Kenny
2020-10-07 13:39         ` Alexander Bulekov
2020-10-07 13:53           ` Darren Kenny
2020-10-08  7:03       ` Paolo Bonzini
2020-10-11 15:35         ` Alexander Bulekov
2020-10-12  7:02           ` Paolo Bonzini
2020-09-22 14:03   ` Alexander Bulekov
2020-10-08  7:04     ` Paolo Bonzini
2020-09-21  2:24 ` [PATCH v3 03/16] fuzz: Add PCI features to the general fuzzer Alexander Bulekov
2020-09-21  5:44   ` Philippe Mathieu-Daudé
2020-09-21 14:41     ` Alexander Bulekov [this message]
2020-09-21  2:24 ` [PATCH v3 04/16] fuzz: Add DMA support to the generic-fuzzer Alexander Bulekov
2020-10-08  7:43   ` Paolo Bonzini
2020-10-08 13:26     ` Alexander Bulekov
2020-09-21  2:24 ` [PATCH v3 05/16] fuzz: Declare DMA Read callback function Alexander Bulekov
2020-10-08  7:39   ` Paolo Bonzini
2020-10-11 15:45     ` Alexander Bulekov
2020-10-12  6:59       ` Paolo Bonzini
2020-09-21  2:24 ` [PATCH v3 06/16] fuzz: Add fuzzer callbacks to DMA-read functions Alexander Bulekov
2020-09-21  2:24 ` [PATCH v3 07/16] fuzz: Add support for custom crossover functions Alexander Bulekov
2020-09-21  2:24 ` [PATCH v3 08/16] fuzz: add a DISABLE_PCI op to general-fuzzer Alexander Bulekov
2020-09-21  2:24 ` [PATCH v3 09/16] fuzz: add a crossover function to generic-fuzzer Alexander Bulekov
2020-10-01 15:31   ` Darren Kenny
2020-10-15 13:43     ` Alexander Bulekov
2020-09-21  2:25 ` [PATCH v3 10/16] scripts/oss-fuzz: Add wrapper program for generic fuzzer Alexander Bulekov
2020-09-21  2:25 ` [PATCH v3 11/16] scripts/oss-fuzz: Add general-fuzzer build script Alexander Bulekov
2020-10-01 15:40   ` Darren Kenny
2020-10-08  7:35   ` Paolo Bonzini
2020-10-15 13:46     ` Alexander Bulekov
2020-09-21  2:25 ` [PATCH v3 12/16] scripts/oss-fuzz: Add general-fuzzer configs for oss-fuzz Alexander Bulekov
2020-09-21  2:25 ` [PATCH v3 13/16] scripts/oss-fuzz: build the general-fuzzer configs Alexander Bulekov
2020-09-21  2:25 ` [PATCH v3 14/16] scripts/oss-fuzz: Add script to reorder a general-fuzzer trace Alexander Bulekov
2020-10-08  7:42   ` Paolo Bonzini
2020-09-21  2:25 ` [PATCH v3 15/16] scripts/oss-fuzz: Add crash trace minimization script Alexander Bulekov
2020-09-21  2:25 ` [PATCH v3 16/16] fuzz: Add instructions for using general-fuzz Alexander Bulekov
2020-10-01 15:44   ` Darren Kenny
2020-09-21  2:45 ` [PATCH v3 00/16] Add a General Virtual Device Fuzzer no-reply
2020-09-21  2:58 ` no-reply
2020-09-21  3:30 ` no-reply
2020-09-21  3:43 ` no-reply
2020-09-21  3:46 ` no-reply
2020-09-21  4:30 ` no-reply
2020-09-21  4:39 ` no-reply
2020-09-21  5:22 ` no-reply
2020-09-21  5:31 ` no-reply
2020-09-21  6:17 ` no-reply
2020-09-21  6:26 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200921144139.r424ql3ck2dvih2m@mozz.bu.edu \
    --to=alxndr@bu.edu \
    --cc=bsd@redhat.com \
    --cc=darren.kenny@oracle.com \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).