From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFE13C4727E for ; Fri, 25 Sep 2020 22:24:28 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 597A62086A for ; Fri, 25 Sep 2020 22:24:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="D+r9tmp4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 597A62086A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:32818 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kLw8h-0007wA-7x for qemu-devel@archiver.kernel.org; Fri, 25 Sep 2020 18:24:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41004) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLw7s-0007Ru-Hc for qemu-devel@nongnu.org; Fri, 25 Sep 2020 18:23:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:40238) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kLw7q-0000pR-1E for qemu-devel@nongnu.org; Fri, 25 Sep 2020 18:23:35 -0400 Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601072612; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X0ERSg3LEqHLjGakaREUS2/TFm8SSCL8rgYNPOV54tU=; b=D+r9tmp4U8OdBi9P8v98k3NmD1p7a6+CLjEPjfo1RX/vr1llyk4c5RiTbay2ZcERPqQQGn At2IMq/FkxhXGwy6Kwx6SpmnyAm9DLd2LoGfvR59QlG5BEarIM9DC/ON01qUexadYsJM/v +/wTU5gh7LBTox7iXRbRcMI7vDUM2HI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-413-vLasISZkPBOqX1UUPAoVPg-1; Fri, 25 Sep 2020 18:23:30 -0400 X-MC-Unique: vLasISZkPBOqX1UUPAoVPg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D258A10066FE; Fri, 25 Sep 2020 22:23:27 +0000 (UTC) Received: from x1.home (ovpn-112-71.phx2.redhat.com [10.3.112.71]) by smtp.corp.redhat.com (Postfix) with ESMTP id 321991002C01; Fri, 25 Sep 2020 22:23:17 +0000 (UTC) Date: Fri, 25 Sep 2020 16:23:16 -0600 From: Alex Williamson To: Kirti Wankhede Subject: Re: [PATCH v26 13/17] vfio: create mapped iova list when vIOMMU is enabled Message-ID: <20200925162316.53dbd2b0@x1.home> In-Reply-To: <1600817059-26721-14-git-send-email-kwankhede@nvidia.com> References: <1600817059-26721-1-git-send-email-kwankhede@nvidia.com> <1600817059-26721-14-git-send-email-kwankhede@nvidia.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=alex.williamson@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=alex.williamson@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/25 02:48:20 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -32 X-Spam_score: -3.3 X-Spam_bar: --- X-Spam_report: (-3.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.199, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: cohuck@redhat.com, cjia@nvidia.com, aik@ozlabs.ru, Zhengxiao.zx@Alibaba-inc.com, shuangtai.tst@alibaba-inc.com, qemu-devel@nongnu.org, peterx@redhat.com, eauger@redhat.com, yi.l.liu@intel.com, quintela@redhat.com, ziye.yang@intel.com, armbru@redhat.com, mlevitsk@redhat.com, pasic@linux.ibm.com, felipe@nutanix.com, zhi.a.wang@intel.com, kevin.tian@intel.com, yan.y.zhao@intel.com, dgilbert@redhat.com, changpeng.liu@intel.com, eskultet@redhat.com, Ken.Xue@amd.com, jonathan.davies@nutanix.com, pbonzini@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 23 Sep 2020 04:54:15 +0530 Kirti Wankhede wrote: > Create mapped iova list when vIOMMU is enabled. For each mapped iova > save translated address. Add node to list on MAP and remove node from > list on UNMAP. > This list is used to track dirty pages during migration. > > Signed-off-by: Kirti Wankhede > --- > hw/vfio/common.c | 58 ++++++++++++++++++++++++++++++++++++++----- > include/hw/vfio/vfio-common.h | 8 ++++++ > 2 files changed, 60 insertions(+), 6 deletions(-) > > diff --git a/hw/vfio/common.c b/hw/vfio/common.c > index d4959c036dd1..dc56cded2d95 100644 > --- a/hw/vfio/common.c > +++ b/hw/vfio/common.c > @@ -407,8 +407,8 @@ static bool vfio_listener_skipped_section(MemoryRegionSection *section) > } > > /* Called with rcu_read_lock held. */ > -static bool vfio_get_vaddr(IOMMUTLBEntry *iotlb, void **vaddr, > - bool *read_only) > +static bool vfio_get_xlat_addr(IOMMUTLBEntry *iotlb, void **vaddr, > + ram_addr_t *ram_addr, bool *read_only) > { > MemoryRegion *mr; > hwaddr xlat; > @@ -439,8 +439,17 @@ static bool vfio_get_vaddr(IOMMUTLBEntry *iotlb, void **vaddr, > return false; > } > > - *vaddr = memory_region_get_ram_ptr(mr) + xlat; > - *read_only = !writable || mr->readonly; > + if (vaddr) { > + *vaddr = memory_region_get_ram_ptr(mr) + xlat; > + } > + > + if (ram_addr) { > + *ram_addr = memory_region_get_ram_addr(mr) + xlat; > + } > + > + if (read_only) { > + *read_only = !writable || mr->readonly; > + } > > return true; > } > @@ -450,7 +459,6 @@ static void vfio_iommu_map_notify(IOMMUNotifier *n, IOMMUTLBEntry *iotlb) > VFIOGuestIOMMU *giommu = container_of(n, VFIOGuestIOMMU, n); > VFIOContainer *container = giommu->container; > hwaddr iova = iotlb->iova + giommu->iommu_offset; > - bool read_only; > void *vaddr; > int ret; > > @@ -466,7 +474,10 @@ static void vfio_iommu_map_notify(IOMMUNotifier *n, IOMMUTLBEntry *iotlb) > rcu_read_lock(); > > if ((iotlb->perm & IOMMU_RW) != IOMMU_NONE) { > - if (!vfio_get_vaddr(iotlb, &vaddr, &read_only)) { > + ram_addr_t ram_addr; > + bool read_only; > + > + if (!vfio_get_xlat_addr(iotlb, &vaddr, &ram_addr, &read_only)) { > goto out; > } > /* > @@ -484,8 +495,28 @@ static void vfio_iommu_map_notify(IOMMUNotifier *n, IOMMUTLBEntry *iotlb) > "0x%"HWADDR_PRIx", %p) = %d (%m)", > container, iova, > iotlb->addr_mask + 1, vaddr, ret); > + } else { > + VFIOIovaRange *iova_range; > + > + iova_range = g_malloc0(sizeof(*iova_range)); > + iova_range->iova = iova; > + iova_range->size = iotlb->addr_mask + 1; > + iova_range->ram_addr = ram_addr; > + > + QLIST_INSERT_HEAD(&giommu->iova_list, iova_range, next); > } > } else { > + VFIOIovaRange *iova_range, *tmp; > + > + QLIST_FOREACH_SAFE(iova_range, &giommu->iova_list, next, tmp) { > + if (iova_range->iova >= iova && > + iova_range->iova + iova_range->size <= iova + > + iotlb->addr_mask + 1) { > + QLIST_REMOVE(iova_range, next); > + g_free(iova_range); > + } > + } > + This is some pretty serious overhead... can't we trigger a replay when migration is enabled to build this information then? We're looking at potentially thousands of entries, so a list is probably also not a good choice. I don't think it's acceptable to incur this even when not migrating (ie. the vast majority of the time). Thanks, Alex > ret = vfio_dma_unmap(container, iova, iotlb->addr_mask + 1); > if (ret) { > error_report("vfio_dma_unmap(%p, 0x%"HWADDR_PRIx", " > @@ -642,6 +673,7 @@ static void vfio_listener_region_add(MemoryListener *listener, > g_free(giommu); > goto fail; > } > + QLIST_INIT(&giommu->iova_list); > QLIST_INSERT_HEAD(&container->giommu_list, giommu, giommu_next); > memory_region_iommu_replay(giommu->iommu, &giommu->n); > > @@ -740,6 +772,13 @@ static void vfio_listener_region_del(MemoryListener *listener, > QLIST_FOREACH(giommu, &container->giommu_list, giommu_next) { > if (MEMORY_REGION(giommu->iommu) == section->mr && > giommu->n.start == section->offset_within_region) { > + VFIOIovaRange *iova_range, *tmp; > + > + QLIST_FOREACH_SAFE(iova_range, &giommu->iova_list, next, tmp) { > + QLIST_REMOVE(iova_range, next); > + g_free(iova_range); > + } > + > memory_region_unregister_iommu_notifier(section->mr, > &giommu->n); > QLIST_REMOVE(giommu, giommu_next); > @@ -1541,6 +1580,13 @@ static void vfio_disconnect_container(VFIOGroup *group) > QLIST_REMOVE(container, next); > > QLIST_FOREACH_SAFE(giommu, &container->giommu_list, giommu_next, tmp) { > + VFIOIovaRange *iova_range, *itmp; > + > + QLIST_FOREACH_SAFE(iova_range, &giommu->iova_list, next, itmp) { > + QLIST_REMOVE(iova_range, next); > + g_free(iova_range); > + } > + > memory_region_unregister_iommu_notifier( > MEMORY_REGION(giommu->iommu), &giommu->n); > QLIST_REMOVE(giommu, giommu_next); > diff --git a/include/hw/vfio/vfio-common.h b/include/hw/vfio/vfio-common.h > index 0a1651eda2d0..aa7524fe2cc5 100644 > --- a/include/hw/vfio/vfio-common.h > +++ b/include/hw/vfio/vfio-common.h > @@ -89,11 +89,19 @@ typedef struct VFIOContainer { > QLIST_ENTRY(VFIOContainer) next; > } VFIOContainer; > > +typedef struct VFIOIovaRange { > + hwaddr iova; > + size_t size; > + ram_addr_t ram_addr; > + QLIST_ENTRY(VFIOIovaRange) next; > +} VFIOIovaRange; > + > typedef struct VFIOGuestIOMMU { > VFIOContainer *container; > IOMMUMemoryRegion *iommu; > hwaddr iommu_offset; > IOMMUNotifier n; > + QLIST_HEAD(, VFIOIovaRange) iova_list; > QLIST_ENTRY(VFIOGuestIOMMU) giommu_next; > } VFIOGuestIOMMU; >