From: Greg Kurz <groug@kaod.org>
To: "Cédric Le Goater" <clg@kaod.org>
Cc: Gustavo Romero <gromero@linux.ibm.com>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH v2 2/6] spapr/xive: Add a warning when StoreEOI is activated on POWER8 CPUs
Date: Tue, 6 Oct 2020 18:52:29 +0200 [thread overview]
Message-ID: <20201006185229.1d6f6285@bahia.lan> (raw)
In-Reply-To: <20201005165147.526426-3-clg@kaod.org>
On Mon, 5 Oct 2020 18:51:43 +0200
Cédric Le Goater <clg@kaod.org> wrote:
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
> hw/ppc/spapr_caps.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/hw/ppc/spapr_caps.c b/hw/ppc/spapr_caps.c
> index 57c62c22e4cc..b0a9d0227db2 100644
> --- a/hw/ppc/spapr_caps.c
> +++ b/hw/ppc/spapr_caps.c
> @@ -535,6 +535,14 @@ static void cap_storeeoi_apply(SpaprMachineState *spapr, uint8_t val,
> return; /* Disabled by default */
> }
>
> + /* For POWER8 CPUs, setting StoreEOI is useless as XIVE is not used */
> + if (!ppc_type_check_compat(machine->cpu_type, CPU_POWERPC_LOGICAL_3_00, 0,
> + spapr->max_compat_pvr)) {
It seems that this check is already done during machine init before
we get here:
spapr_machine_init()
spapr_irq_init()
spapr_irq_check()
So you could maybe just check !spapr->irq->xive I think.
And s/on POWER8 CPUs/with XICS/ in the title.
> + warn_report("StoreEOI is for the XIVE interrupt mode "
> + "(POWER9 and above)");
> + return;
> + }
> +
> /* Check host support when the KVM device is in use */
> if (kvm_irqchip_in_kernel()) {
> if (!kvm_storeeoi) {
next prev parent reply other threads:[~2020-10-06 16:54 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 16:51 [PATCH v2 0/6] spapr/xive: Activate StoreEOI in P10 compat guests Cédric Le Goater
2020-10-05 16:51 ` [PATCH v2 1/6] spapr/xive: Introduce a StoreEOI capability Cédric Le Goater
2020-10-06 16:42 ` Greg Kurz
2020-10-07 5:59 ` Cédric Le Goater
2020-10-07 7:24 ` Greg Kurz
2020-10-05 16:51 ` [PATCH v2 2/6] spapr/xive: Add a warning when StoreEOI is activated on POWER8 CPUs Cédric Le Goater
2020-10-06 16:52 ` Greg Kurz [this message]
2020-10-05 16:51 ` [PATCH v2 3/6] spapr/xive: Add a warning when StoreEOI is activated on POWER9 CPUs Cédric Le Goater
2020-10-06 16:58 ` Greg Kurz
2020-10-06 17:03 ` Cédric Le Goater
2020-10-07 8:56 ` Greg Kurz
2020-10-07 9:21 ` Cédric Le Goater
2020-10-05 16:51 ` [PATCH v2 4/6] spapr/xive: Enforce load-after-store ordering Cédric Le Goater
2020-10-06 17:02 ` Greg Kurz
2020-10-05 16:51 ` [PATCH v2 5/6] spapr/xive: Activate StoreEOI at the source level Cédric Le Goater
2020-10-06 17:06 ` Greg Kurz
2020-10-06 17:41 ` Cédric Le Goater
2020-10-07 7:26 ` Greg Kurz
2020-10-05 16:51 ` [PATCH v2 6/6] spapr/xive: Introduce a new CAS value for the StoreEOI capability Cédric Le Goater
2020-10-06 17:39 ` Greg Kurz
2020-10-06 17:56 ` Cédric Le Goater
2020-10-07 13:43 ` Greg Kurz
2020-10-07 14:28 ` Cédric Le Goater
2020-10-09 0:23 ` [PATCH v2 0/6] spapr/xive: Activate StoreEOI in P10 compat guests David Gibson
2020-10-09 5:57 ` Cédric Le Goater
2020-10-12 5:38 ` David Gibson
2020-11-02 13:22 ` Cédric Le Goater
2020-11-23 6:44 ` David Gibson
2020-11-23 11:16 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201006185229.1d6f6285@bahia.lan \
--to=groug@kaod.org \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=gromero@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).