From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20233C4741F for ; Wed, 7 Oct 2020 18:19:48 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D5172173E for ; Wed, 7 Oct 2020 18:19:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IHvIolX+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D5172173E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47278 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQE2U-0007Zp-Cn for qemu-devel@archiver.kernel.org; Wed, 07 Oct 2020 14:19:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40720) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQE1Q-00076z-72 for qemu-devel@nongnu.org; Wed, 07 Oct 2020 14:18:40 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:46250) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kQE1O-0006tp-K4 for qemu-devel@nongnu.org; Wed, 07 Oct 2020 14:18:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602094717; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4hSrCZ6l2miX7qFxu++YbM0D70W0OhJCMepyTZASMIQ=; b=IHvIolX+7cBUZrTYDgjj1HREtV5D7Kupq3X85azDDiQhHXv+p5ErDlxqFDWNpRDdSfV6jp gljPSnRZ/38SBb7XJc/ENCVxnDAzcHprd17MxJV12c0GLLQIp4BVTZEXkLKIG26eKPhkmc GWQMRTM8X5tr0c0nTTXj/WBMIMW0j6o= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-562-mcIcu2myN0-L7K4AfmrLEw-1; Wed, 07 Oct 2020 14:18:32 -0400 X-MC-Unique: mcIcu2myN0-L7K4AfmrLEw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 065C21074644 for ; Wed, 7 Oct 2020 18:18:32 +0000 (UTC) Received: from localhost (ovpn-119-102.rdu2.redhat.com [10.10.119.102]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8353E1002C04; Wed, 7 Oct 2020 18:18:31 +0000 (UTC) Date: Wed, 7 Oct 2020 14:18:30 -0400 From: Eduardo Habkost To: John Snow Subject: Re: [PATCH v5 11/36] qapi/common.py: Add indent manager Message-ID: <20201007181830.GZ7303@habkost.net> References: <20201005195158.2348217-1-jsnow@redhat.com> <20201005195158.2348217-12-jsnow@redhat.com> <87d01uifmn.fsf@dusky.pond.sub.org> <0a507019-1e59-2967-9c7a-fa3712a74ae0@redhat.com> MIME-Version: 1.0 In-Reply-To: <0a507019-1e59-2967-9c7a-fa3712a74ae0@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ehabkost@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=ehabkost@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/07 00:44:56 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.742, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cleber Rosa , Markus Armbruster , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Oct 07, 2020 at 02:08:33PM -0400, John Snow wrote: > On 10/7/20 4:50 AM, Markus Armbruster wrote: > > John Snow writes: > > > > > Code style tools really dislike the use of global keywords, because it > > > generally involves re-binding the name at runtime which can have strange > > > effects depending on when and how that global name is referenced in > > > other modules. > > > > > > Make a little indent level manager instead. > > > > > > Signed-off-by: John Snow > > > Reviewed-by: Eduardo Habkost > > > Reviewed-by: Cleber Rosa > > > > Intentation is a job for QAPIGen (and its subtypes). But if this patch > > is easier to achieve this series' goal, I don't mind. > > > > I agree, but refactoring it properly is beyond my capacity right now. > > This was the dumbest thing I could do to get pylint/mypy passing, which > required the elimination (or suppression) of the global keyword. > > Creating a stateful object was the fastest way from A to B. An even dumber solution could be: indent_prefixes = [] def push_indent(amount=4): """Add `amount` spaces to indentation prefix""" indent_prefixes.push(' '*amount) def pop_indent(): """Revert the most recent push_indent() call""" indent_prefixes.pop() def genindent(): """Return the current indentation prefix""" return ''.join(indent_prefixes) No global keyword involved, and the only stateful object is a dumb list. -- Eduardo