From: Stefan Hajnoczi <stefanha@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
qemu-block@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
"Coiby Xu" <Coiby.Xu@gmail.com>, "Max Reitz" <mreitz@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Fam Zheng" <fam@euphon.net>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: [PULL v2 15/30] util/vhost-user-server: check EOF when reading payload
Date: Mon, 12 Oct 2020 19:27:45 +0100 [thread overview]
Message-ID: <20201012182800.157697-16-stefanha@redhat.com> (raw)
In-Reply-To: <20201012182800.157697-1-stefanha@redhat.com>
Unexpected EOF is an error that must be reported.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 20200924151549.913737-9-stefanha@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
util/vhost-user-server.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/util/vhost-user-server.c b/util/vhost-user-server.c
index 5a60e2ca2a..ec555abcb2 100644
--- a/util/vhost-user-server.c
+++ b/util/vhost-user-server.c
@@ -169,8 +169,10 @@ vu_message_read(VuDev *vu_dev, int conn_fd, VhostUserMsg *vmsg)
};
if (vmsg->size) {
rc = qio_channel_readv_all_eof(ioc, &iov_payload, 1, &local_err);
- if (rc == -1) {
- error_report_err(local_err);
+ if (rc != 1) {
+ if (local_err) {
+ error_report_err(local_err);
+ }
goto fail;
}
}
--
2.26.2
next prev parent reply other threads:[~2020-10-12 18:44 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 18:27 [PULL v2 00/30] Block patches Stefan Hajnoczi
2020-10-12 18:27 ` [PULL v2 01/30] block/nvme: Add driver statistics for access alignment and hw errors Stefan Hajnoczi
2020-10-12 18:27 ` [PULL v2 02/30] libvhost-user: Allow vu_message_read to be replaced Stefan Hajnoczi
2020-10-12 18:27 ` [PULL v2 03/30] libvhost-user: remove watch for kick_fd when de-initialize vu-dev Stefan Hajnoczi
2020-10-12 18:27 ` [PULL v2 04/30] util/vhost-user-server: generic vhost user server Stefan Hajnoczi
2020-10-12 18:27 ` [PULL v2 05/30] block: move logical block size check function to a common utility function Stefan Hajnoczi
2020-10-12 18:27 ` [PULL v2 06/30] block/export: vhost-user block device backend server Stefan Hajnoczi
2020-10-12 18:27 ` [PULL v2 07/30] test: new qTest case to test the vhost-user-blk-server Stefan Hajnoczi
2020-10-12 18:27 ` [PULL v2 08/30] MAINTAINERS: Add vhost-user block device backend server maintainer Stefan Hajnoczi
2020-10-12 18:27 ` [PULL v2 09/30] util/vhost-user-server: s/fileds/fields/ typo fix Stefan Hajnoczi
2020-10-12 18:27 ` [PULL v2 10/30] util/vhost-user-server: drop unnecessary QOM cast Stefan Hajnoczi
2020-10-12 18:27 ` [PULL v2 11/30] util/vhost-user-server: drop unnecessary watch deletion Stefan Hajnoczi
2020-10-12 18:27 ` [PULL v2 12/30] block/export: consolidate request structs into VuBlockReq Stefan Hajnoczi
2020-10-12 18:27 ` [PULL v2 13/30] util/vhost-user-server: drop unused DevicePanicNotifier Stefan Hajnoczi
2020-10-12 18:27 ` [PULL v2 14/30] util/vhost-user-server: fix memory leak in vu_message_read() Stefan Hajnoczi
2020-10-12 18:27 ` Stefan Hajnoczi [this message]
2020-10-12 18:27 ` [PULL v2 16/30] util/vhost-user-server: rework vu_client_trip() coroutine lifecycle Stefan Hajnoczi
2020-10-12 18:27 ` [PULL v2 17/30] block/export: report flush errors Stefan Hajnoczi
2020-10-12 18:27 ` [PULL v2 18/30] block/export: convert vhost-user-blk server to block export API Stefan Hajnoczi
2020-10-12 18:27 ` [PULL v2 19/30] util/vhost-user-server: move header to include/ Stefan Hajnoczi
2020-10-12 18:27 ` [PULL v2 20/30] util/vhost-user-server: use static library in meson.build Stefan Hajnoczi
2020-10-12 18:27 ` [PULL v2 21/30] qemu-storage-daemon: avoid compiling blockdev_ss twice Stefan Hajnoczi
2020-10-12 18:27 ` [PULL v2 22/30] block: move block exports to libblockdev Stefan Hajnoczi
2020-10-12 18:27 ` [PULL v2 23/30] block/export: add iothread and fixed-iothread options Stefan Hajnoczi
2020-10-12 18:27 ` [PULL v2 24/30] block/export: add vhost-user-blk multi-queue support Stefan Hajnoczi
2020-10-12 18:27 ` [PULL v2 25/30] tests/qtest: add multi-queue test case to vhost-user-blk-test Stefan Hajnoczi
2020-10-12 18:27 ` [PULL v2 26/30] block/io: fix bdrv_co_block_status_above Stefan Hajnoczi
2020-10-12 18:27 ` [PULL v2 27/30] block/io: bdrv_common_block_status_above: support include_base Stefan Hajnoczi
2020-10-12 18:27 ` [PULL v2 28/30] block/io: bdrv_common_block_status_above: support bs == base Stefan Hajnoczi
2020-10-12 18:27 ` [PULL v2 29/30] block/io: fix bdrv_is_allocated_above Stefan Hajnoczi
2020-10-12 18:28 ` [PULL v2 30/30] iotests: add commit top->base cases to 274 Stefan Hajnoczi
2020-10-12 19:00 ` [PULL v2 00/30] Block patches no-reply
2020-10-12 21:48 ` Peter Maydell
2020-10-13 0:05 ` Eric Blake
2020-10-20 15:19 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201012182800.157697-16-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=Coiby.Xu@gmail.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=crosa@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=fam@euphon.net \
--cc=kwolf@redhat.com \
--cc=lvivier@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).