From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 258C3C433DF for ; Wed, 14 Oct 2020 19:37:40 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6951A214D8 for ; Wed, 14 Oct 2020 19:37:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ec9sHdzW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6951A214D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55392 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSmag-00074d-DL for qemu-devel@archiver.kernel.org; Wed, 14 Oct 2020 15:37:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42760) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSmPp-0005Aa-Gh for qemu-devel@nongnu.org; Wed, 14 Oct 2020 15:26:25 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:55278) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kSmPn-0002SL-OX for qemu-devel@nongnu.org; Wed, 14 Oct 2020 15:26:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602703582; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cfn0wNNCYzC4IFRFHwTP/VEDeMdOjsOvXaSaOBmv+Z4=; b=Ec9sHdzWmWKCzWEc0qBvYBaDMvWmAcfSE5VZahWAGSA4yKNkXI6MR3XlEEvkzmHKdezKNi 6+8a1C+0LB5zyD+OVf4aPQtM1DpV55AHvGGXvYVlxR4IRjh5Sa8Kw918xQeh1ATBewHcYC 7OR711fcon1mSxm83Zk56wIazz4STn0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-298-R--Y8DgsMEOB9BR32OGcpA-1; Wed, 14 Oct 2020 15:26:19 -0400 X-MC-Unique: R--Y8DgsMEOB9BR32OGcpA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AB37E56C90; Wed, 14 Oct 2020 19:26:17 +0000 (UTC) Received: from work-vm (ovpn-113-95.ams2.redhat.com [10.36.113.95]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0BD886EF5E; Wed, 14 Oct 2020 19:26:15 +0000 (UTC) Date: Wed, 14 Oct 2020 20:26:13 +0100 From: "Dr. David Alan Gilbert" To: Bihong Yu Subject: Re: [PATCH v2 7/8] migration: Open brace '{' following function declarations go on the next line Message-ID: <20201014192613.GM2996@work-vm> References: <1602508140-11372-1-git-send-email-yubihong@huawei.com> <1602508140-11372-8-git-send-email-yubihong@huawei.com> MIME-Version: 1.0 In-Reply-To: <1602508140-11372-8-git-send-email-yubihong@huawei.com> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dgilbert@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/14 03:37:33 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhengchuan@huawei.com, quintela@redhat.com, qemu-trivial@nongnu.org, qemu-devel@nongnu.org, alex.chen@huawei.com, wanghao232@huawei.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Bihong Yu (yubihong@huawei.com) wrote: > Signed-off-by: Bihong Yu > Reviewed-by: Chuan Zheng Reviewed-by: Dr. David Alan Gilbert > --- > migration/rdma.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/migration/rdma.c b/migration/rdma.c > index 0eb42b7..ca4d315 100644 > --- a/migration/rdma.c > +++ b/migration/rdma.c > @@ -273,7 +273,8 @@ static uint64_t htonll(uint64_t v) > return u.llv; > } > > -static uint64_t ntohll(uint64_t v) { > +static uint64_t ntohll(uint64_t v) > +{ > union { uint32_t lv[2]; uint64_t llv; } u; > u.llv = v; > return ((uint64_t)ntohl(u.lv[0]) << 32) | (uint64_t) ntohl(u.lv[1]); > -- > 1.8.3.1 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK