From: Kevin Wolf <kwolf@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: f4bug@amsat.org, qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [PATCH] monitor: Fix order in monitor_cleanup()
Date: Thu, 15 Oct 2020 09:46:13 +0200 [thread overview]
Message-ID: <20201015074613.GA4610@merkur.fritz.box> (raw)
In-Reply-To: <878sc8yba7.fsf@linaro.org>
Am 14.10.2020 um 19:20 hat Alex Bennée geschrieben:
>
> Kevin Wolf <kwolf@redhat.com> writes:
>
> > We can only destroy Monitor objects after we're sure that they are not
> > in use by the dispatcher coroutine any more. This fixes crashes like the
> > following where we tried to destroy a monitor mutex while the dispatcher
> > coroutine still holds it:
> >
> > (gdb) bt
> > #0 0x00007fe541cf4bc5 in raise () at /lib64/libc.so.6
> > #1 0x00007fe541cdd8a4 in abort () at /lib64/libc.so.6
> > #2 0x000055c24e965327 in error_exit (err=16, msg=0x55c24eead3a0 <__func__.33> "qemu_mutex_destroy") at ../util/qemu-thread-posix.c:37
> > #3 0x000055c24e9654c3 in qemu_mutex_destroy (mutex=0x55c25133e0f0) at ../util/qemu-thread-posix.c:70
> > #4 0x000055c24e7cfaf1 in monitor_data_destroy_qmp (mon=0x55c25133dfd0) at ../monitor/qmp.c:439
> > #5 0x000055c24e7d23bc in monitor_data_destroy (mon=0x55c25133dfd0) at ../monitor/monitor.c:615
> > #6 0x000055c24e7d253a in monitor_cleanup () at ../monitor/monitor.c:644
> > #7 0x000055c24e6cb002 in qemu_cleanup () at ../softmmu/vl.c:4549
> > #8 0x000055c24e0d259b in main (argc=24, argv=0x7ffff66b0d58, envp=0x7ffff66b0e20) at ../softmmu/main.c:51
> >
> > Reported-by: Alex Bennée <alex.bennee@linaro.org>
> > Signed-off-by: Kevin Wolf <kwolf@redhat.com>
>
> LGTM:
>
> Tested-by: Alex Bennée <alex.bennee@linaro.org>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
>
> Who's tree is going to take it?
In theory Markus, but he's on vacation this week. As this seems to
affect multiple people and we want to unblock testing quickly, I'll just
take it through mine.
Kevin
next prev parent reply other threads:[~2020-10-15 7:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 12:50 [PATCH] monitor: Fix order in monitor_cleanup() Kevin Wolf
2020-10-13 13:32 ` Ben Widawsky
2020-10-14 17:20 ` Alex Bennée
2020-10-15 7:46 ` Kevin Wolf [this message]
2020-10-19 9:19 ` Markus Armbruster
2021-01-29 12:53 ` Markus Armbruster
2021-02-12 14:22 ` Kevin Wolf
2021-02-15 12:17 ` Markus Armbruster
2021-02-15 15:08 ` Paolo Bonzini
2021-02-15 15:28 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201015074613.GA4610@merkur.fritz.box \
--to=kwolf@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).