From: "Daniel P. Berrangé" <berrange@redhat.com>
To: marcandre.lureau@redhat.com
Cc: qemu-devel@nongnu.org, Michael Roth <mdroth@linux.vnet.ibm.com>
Subject: Re: [PATCH 2/2] qga: add ssh-{add,remove}-authorized-keys
Date: Thu, 15 Oct 2020 13:10:15 +0100 [thread overview]
Message-ID: <20201015121015.GG163620@redhat.com> (raw)
In-Reply-To: <20201013202502.335336-3-marcandre.lureau@redhat.com>
On Wed, Oct 14, 2020 at 12:25:02AM +0400, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Add new commands to add and remove SSH public keys from
> ~/.ssh/authorized_keys.
>
> I took a different approach for testing, including the unit tests right
> with the code. I wanted to overwrite the function to get the user
> details, I couldn't easily do that over QMP. Furthermore, I prefer
> having unit tests very close to the code, and unit files that are domain
> specific (commands-posix is too crowded already). Fwiw, that
> coding/testing style is Rust-style (where tests can or should even be
> part of the documentation!).
>
> Fixes:
> https://bugzilla.redhat.com/show_bug.cgi?id=1885332
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> qga/commands-posix-ssh.c | 394 +++++++++++++++++++++++++++++++++++++++
> qga/commands-win32.c | 10 +
> qga/meson.build | 17 +-
> qga/qapi-schema.json | 32 ++++
> 4 files changed, 452 insertions(+), 1 deletion(-)
> create mode 100644 qga/commands-posix-ssh.c
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> +##
> +# @guest-ssh-add-authorized-keys:
> +#
> +# @username: the user account to add the authorized key
> +# @keys: the public keys to add (in OpenSSH format)
> +#
> +# Append a public key to user $HOME/.ssh/authorized_keys on Unix systems (not
> +# implemented for other systems).
s/a public key/public keys/
> +#
> +# Returns: Nothing on success.
> +#
> +# Since: 5.2
> +##
> +{ 'command': 'guest-ssh-add-authorized-keys',
> + 'data': { 'username': 'str', 'keys': ['str'] } }
> +
> +##
> +# @guest-ssh-remove-authorized-keys:
> +#
> +# @username: the user account to add the authorized key
> +# @keys: the public keys to remove (in OpenSSH format)
> +#
> +# Remove public keys from the user $HOME/.ssh/authorized_keys on Unix systems
> +# (not implemented for other systems).
Mention that if the requested key does not exist, it is not an
error.
> +#
> +# Returns: Nothing on success.
> +#
> +# Since: 5.2
> +##
> +{ 'command': 'guest-ssh-remove-authorized-keys',
> + 'data': { 'username': 'str', 'keys': ['str'] } }
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2020-10-15 12:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 20:25 [PATCH 0/2] qemu-ga: add ssh-{add,remove}-authorized-keys marcandre.lureau
2020-10-13 20:25 ` [PATCH 1/2] glib-compat: add g_unix_get_passwd_entry_qemu() marcandre.lureau
2020-10-13 20:25 ` [PATCH 2/2] qga: add ssh-{add,remove}-authorized-keys marcandre.lureau
2020-10-13 21:14 ` Philippe Mathieu-Daudé
2020-10-14 7:37 ` Marc-André Lureau
2020-10-14 11:18 ` Philippe Mathieu-Daudé
2020-10-15 12:10 ` Daniel P. Berrangé [this message]
2020-10-19 19:02 ` Eric Blake
2020-10-20 6:46 ` Marc-André Lureau
2020-10-13 20:33 ` [PATCH 0/2] qemu-ga: " no-reply
2020-10-14 10:43 ` Michal Privoznik
2020-10-14 10:49 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201015121015.GG163620@redhat.com \
--to=berrange@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).