From: "Daniel P. Berrangé" <berrange@redhat.com>
To: AlexChen <alex.chen@huawei.com>
Cc: zhengchuan@huawei.com, qemu-devel@nongnu.org,
zhang.zhanghailiang@huawei.com
Subject: Re: io: Don't use '#' flag of printf format
Date: Mon, 19 Oct 2020 13:18:09 +0100 [thread overview]
Message-ID: <20201019121809.GJ236912@redhat.com> (raw)
In-Reply-To: <5F8D8292.5030302@huawei.com>
On Mon, Oct 19, 2020 at 08:12:02PM +0800, AlexChen wrote:
> Signed-off-by: AlexChen <alex.chen@huawei.com>
> ---
> io/channel-websock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/io/channel-websock.c b/io/channel-websock.c
> index 47a0e941d9..e94a1fcf99 100644
> --- a/io/channel-websock.c
> +++ b/io/channel-websock.c
> @@ -746,7 +746,7 @@ static int qio_channel_websock_decode_header(QIOChannelWebsock *ioc,
> opcode != QIO_CHANNEL_WEBSOCK_OPCODE_CLOSE &&
> opcode != QIO_CHANNEL_WEBSOCK_OPCODE_PING &&
> opcode != QIO_CHANNEL_WEBSOCK_OPCODE_PONG) {
> - error_setg(errp, "unsupported opcode: %#04x; only binary, close, "
> + error_setg(errp, "unsupported opcode: 0x%04x; only binary, close, "
> "ping, and pong websocket frames are supported", opcode);
> qio_channel_websock_write_close(
> ioc, QIO_CHANNEL_WEBSOCK_STATUS_INVALID_DATA ,
Acked-by: Daniel P. Berrangé <berrange@redhat.com>
and added to my queue
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2020-10-19 12:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 12:12 io: Don't use '#' flag of printf format AlexChen
2020-10-19 12:18 ` Daniel P. Berrangé [this message]
2020-10-19 12:55 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201019121809.GJ236912@redhat.com \
--to=berrange@redhat.com \
--cc=alex.chen@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
--cc=zhengchuan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).