From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43F38C433E7 for ; Mon, 19 Oct 2020 12:31:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C55622276 for ; Mon, 19 Oct 2020 12:31:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Wx4kOQdq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C55622276 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33624 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUUKG-0004IL-45 for qemu-devel@archiver.kernel.org; Mon, 19 Oct 2020 08:31:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58918) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUUIw-0003Tb-89 for qemu-devel@nongnu.org; Mon, 19 Oct 2020 08:30:22 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:27401) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kUUIt-0006IS-TQ for qemu-devel@nongnu.org; Mon, 19 Oct 2020 08:30:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603110618; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RO98a8qj5/RJRuJ+j/LXzJhm4HDBCoJHQOiaAclUFKk=; b=Wx4kOQdqDBZRutXAtQJfuhKn3Qxi+P6Bs8RVNDWmycOd5in7EJqq1TmDxeLsONHaHVaQO+ niOctctvqlwL2CbuyqigRfLEtz6fiFqW2Qzh9g+vUT3e8zFja79DugGiKEyh33pkhVdqO1 uTFkplMjJqMz/oZnHL11x6ktsimEhU8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-419-jv8ln5FjNzG9pcIyGXkODA-1; Mon, 19 Oct 2020 08:30:16 -0400 X-MC-Unique: jv8ln5FjNzG9pcIyGXkODA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5AF86106BC28 for ; Mon, 19 Oct 2020 12:30:15 +0000 (UTC) Received: from localhost (ovpn-66-44.rdu2.redhat.com [10.10.66.44]) by smtp.corp.redhat.com (Postfix) with ESMTP id 13C705C1A3; Mon, 19 Oct 2020 12:30:14 +0000 (UTC) Date: Mon, 19 Oct 2020 08:30:14 -0400 From: Eduardo Habkost To: Markus Armbruster Subject: Re: [PATCH v2 0/5] qapi: Restrict machine (and migration) specific commands Message-ID: <20201019123014.GI5733@habkost.net> References: <20201012121536.3381997-1-philmd@redhat.com> <20201015182824.GG5733@habkost.net> <87ft6a1wgn.fsf@dusky.pond.sub.org> MIME-Version: 1.0 In-Reply-To: <87ft6a1wgn.fsf@dusky.pond.sub.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ehabkost@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=ehabkost@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/19 01:44:30 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Oct 19, 2020 at 09:55:20AM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Mon, Oct 12, 2020 at 02:15:31PM +0200, Philippe Mathieu-Daudé wrote: > >> Reduce the machine code pulled into qemu-storage-daemon. > >> > >> The series is fully Acked, but Markus wants it reviewed > >> by the Machine core maintainers. > > > > I've confirmed that all patches move QAPI schema code without > > introducing any additional changes. > > > > Reviewed-by: Eduardo Habkost > > I take this as "I agree the things moved to machine.json belong there". > Holler if I'm mistaken. I agree machine.json is better than misc.json for them, yes. I miss short descriptions of the purpose of each file, though. It would help us decide what's appropriate in the future. -- Eduardo