From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE965C43457 for ; Tue, 20 Oct 2020 12:37:38 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 45FE722282 for ; Tue, 20 Oct 2020 12:37:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="GOPdCOdx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 45FE722282 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40934 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUqtU-0005nR-Qz for qemu-devel@archiver.kernel.org; Tue, 20 Oct 2020 08:37:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41054) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUqsR-0005Dg-SJ; Tue, 20 Oct 2020 08:36:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:58946) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUqsP-00025H-Nu; Tue, 20 Oct 2020 08:36:31 -0400 Received: from dhcp-10-100-145-180.wdc.com (unknown [199.255.45.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7D6CF22265; Tue, 20 Oct 2020 12:36:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603197387; bh=FEwfkeg0VU3/4beusZEazOB3JANkNtcJ8FjXvi2Umgc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GOPdCOdxCkveQfZavMxo/WZwge3JtGGFjBrzwZKHyPyFOzOsTuMI29nPJcES8Jb3R 7oiOO92KzngJQzZStmX/Y9IlkzmZHDzd/DHC1bRRLjfPKYwBraMHCZE7sCNpmXq/lA feagsIJvkz2POZwDdkLtGcWqo7vcsO8ppylOYlOI= Date: Tue, 20 Oct 2020 05:36:24 -0700 From: Keith Busch To: Klaus Jensen Subject: Re: [PATCH v7 10/11] hw/block/nvme: Separate read and write handlers Message-ID: <20201020123624.GH1435260@dhcp-10-100-145-180.wdc.com> References: <20201019021726.12048-1-dmitry.fomichev@wdc.com> <20201019021726.12048-11-dmitry.fomichev@wdc.com> <20201020082822.GB178548@apples.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201020082822.GB178548@apples.localdomain> Received-SPF: pass client-ip=198.145.29.99; envelope-from=kbusch@kernel.org; helo=mail.kernel.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/20 08:36:27 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -70 X-Spam_score: -7.1 X-Spam_bar: ------- X-Spam_report: (-7.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Kevin Wolf , Damien Le Moal , qemu-block@nongnu.org, Niklas Cassel , Dmitry Fomichev , Klaus Jensen , qemu-devel@nongnu.org, Maxim Levitsky , Alistair Francis , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Matias Bjorling Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Oct 20, 2020 at 10:28:22AM +0200, Klaus Jensen wrote: > On Oct 19 11:17, Dmitry Fomichev wrote: > > With ZNS support in place, the majority of code in nvme_rw() has > > become read- or write-specific. Move these parts to two separate > > handlers, nvme_read() and nvme_write() to make the code more > > readable and to remove multiple is_write checks that so far existed > > in the i/o path. > > > > This is a refactoring patch, no change in functionality. > > > > This makes a lot of sense, totally Acked, but it might be better to move > it ahead as a preparation patch? It would make the zoned patch easier on > the eye. I agree with the suggestion.