On Mon, Oct 12, 2020 at 10:48:17PM +0100, Peter Maydell wrote:
> On Mon, 12 Oct 2020 at 19:28, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> >
> > The following changes since commit 2387df497b4b4bcf754eb7398edca82889e2ef54:
> >
> >   Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2020-10-10' into staging (2020-10-12 11:29:42 +0100)
> >
> > are available in the Git repository at:
> >
> >   https://gitlab.com/stefanha/qemu.git tags/block-pull-request
> >
> > for you to fetch changes up to 3664ec6bbe236126b79d251d4037889e7181ab55:
> >
> >   iotests: add commit top->base cases to 274 (2020-10-12 16:47:58 +0100)
> >
> > ----------------------------------------------------------------
> > Pull request
> >
> > v2:
> >  * Rebase and resolve conflict with commit 029a88c9a7e3 ("qemu-nbd: Honor
> >    SIGINT and SIGHUP") [Peter]
> >
> 
> Build failures, OSX and the BSDs:
> 
> Compiling C object
> contrib/libvhost-user/libvhost-user.a.p/libvhost-user-glib.c.o
> ../../contrib/libvhost-user/libvhost-user.c:27:10: fatal error:
> 'sys/eventfd.h' file not found
> #include <sys/eventfd.h>
>          ^~~~~~~~~~~~~~~
> In file included from ../../contrib/libvhost-user/libvhost-user-glib.c:17:
> In file included from ../../contrib/libvhost-user/libvhost-user-glib.h:19:
> ../../contrib/libvhost-user/libvhost-user.h:21:10: fatal error:
> 'linux/vhost.h' file not found
> #include <linux/vhost.h>
>          ^~~~~~~~~~~~~~~
> 1 error generated.
> 
> 
> Build failure, 32-bit:
> 
> ../../util/vhost-user-server.c: In function 'vu_message_read':
> ../../util/vhost-user-server.c:119:30: error: format '%lu' expects
> argument of type 'long unsigned int', but argument 3 has type 'size_t
> {aka unsigned int}' [-Werror=format=]
>                  error_report("A maximum of %zu fds are allowed, "
>                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../../util/vhost-user-server.c:121:39:
>                               max_fds, vmsg->fd_num + nfds);
>                                        ~~~~~~~~~~~~~~~~~~~
> ../../util/vhost-user-server.c:120:45: note: format string is defined here
>                               "however got %lu fds now",
>                                            ~~^
>                                            %u
> 
> (you might also want to wordsmith the English in that error message)
> 
> Build failure, Windows:
> 
> ../../qemu-nbd.c:158:5: error: "CONFIG_POSIX" is not defined [-Werror=undef]
>  #if CONFIG_POSIX
>      ^
> 
> 'make check' failure, s390x and ppc64 (ie big-endian host):
> 
> ERROR:../../tests/qtest/vhost-user-blk-test.c:448:idx: assertion
> failed (capacity == TEST_IMAGE_SIZE / 512): (2199023255552 == 131072)
> ERROR qtest-i386: qos-test - Bail out!
> ERROR:../../tests/qtest/vhost-user-blk-test.c:448:idx: assertion
> failed (capacity == TEST_IMAGE_SIZE / 512): (2199023255552 == 131072)
> 
> I also got this on aarch64 host:
> 
> ERROR:../../tests/qtest/boot-sector.c:161:boot_sector_test: assertion
> failed (signature == SIGNATURE): (0x00000000 == 0x0000dead)
> ERROR qtest-s390x: cdrom-test - Bail out!
> ERROR:../../tests/qtest/boot-sector.c:161:boot_sector_test: assertion
> failed (signature == SIGNATURE): (0x00000000 == 0x0000dead)
> 
> but it might be an unrelated intermittent.
> 
> Also a hang on x86-64 host running qtest-ppc64 qos-test, ditto.

Thanks for the info. I will send a v2.

Stefan