From: Klaus Jensen <its@irrelevant.dk>
To: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Cc: "Fam Zheng" <fam@euphon.net>, "Kevin Wolf" <kwolf@redhat.com>,
"Damien Le Moal" <damien.lemoal@wdc.com>,
qemu-block@nongnu.org, "Niklas Cassel" <niklas.cassel@wdc.com>,
"Klaus Jensen" <k.jensen@samsung.com>,
qemu-devel@nongnu.org, "Maxim Levitsky" <mlevitsk@redhat.com>,
"Alistair Francis" <alistair.francis@wdc.com>,
"Keith Busch" <kbusch@kernel.org>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Matias Bjorling" <matias.bjorling@wdc.com>
Subject: Re: [PATCH v7 05/11] hw/block/nvme: Support Zoned Namespace Command Set
Date: Wed, 21 Oct 2020 12:26:04 +0200 [thread overview]
Message-ID: <20201021102604.GA276644@apples.localdomain> (raw)
In-Reply-To: <20201019021726.12048-6-dmitry.fomichev@wdc.com>
[-- Attachment #1: Type: text/plain, Size: 1985 bytes --]
On Oct 19 11:17, Dmitry Fomichev wrote:
> +/*
> + * Close or finish all the zones that are currently open.
> + */
> +static void nvme_zoned_clear_ns(NvmeNamespace *ns)
> +{
> + NvmeZone *zone;
> + uint32_t set_state;
> + int i;
> +
> + zone = ns->zone_array;
> + for (i = 0; i < ns->num_zones; i++, zone++) {
> + switch (nvme_get_zone_state(zone)) {
> + case NVME_ZONE_STATE_IMPLICITLY_OPEN:
> + QTAILQ_REMOVE(&ns->imp_open_zones, zone, entry);
> + break;
> + case NVME_ZONE_STATE_EXPLICITLY_OPEN:
> + QTAILQ_REMOVE(&ns->exp_open_zones, zone, entry);
> + break;
> + case NVME_ZONE_STATE_CLOSED:
> + /* fall through */
> + default:
> + continue;
> + }
> +
> + if (zone->d.wp == zone->d.zslba) {
> + set_state = NVME_ZONE_STATE_EMPTY;
> + } else {
> + set_state = NVME_ZONE_STATE_CLOSED;
> + }
> +
> + switch (set_state) {
> + case NVME_ZONE_STATE_CLOSED:
> + trace_pci_nvme_clear_ns_close(nvme_get_zone_state(zone),
> + zone->d.zslba);
> + QTAILQ_INSERT_TAIL(&ns->closed_zones, zone, entry);
> + break;
> + case NVME_ZONE_STATE_EMPTY:
> + trace_pci_nvme_clear_ns_reset(nvme_get_zone_state(zone),
> + zone->d.zslba);
> + break;
> + case NVME_ZONE_STATE_FULL:
> + trace_pci_nvme_clear_ns_full(nvme_get_zone_state(zone),
> + zone->d.zslba);
> + zone->d.wp = nvme_zone_wr_boundary(zone);
> + QTAILQ_INSERT_TAIL(&ns->full_zones, zone, entry);
> + }
No need for the switch here - just add to the closed list in the
conditional.
The NVME_ZONE_STATE_FULL case is unreachable.
> +
> + zone->w_ptr = zone->d.wp;
> + nvme_set_zone_state(zone, set_state);
> + }
> +}
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-10-21 10:29 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 2:17 [PATCH v7 00/11] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set Dmitry Fomichev
2020-10-19 2:17 ` [PATCH v7 01/11] hw/block/nvme: Add Commands Supported and Effects log Dmitry Fomichev
2020-10-19 19:22 ` Keith Busch
2020-10-19 20:16 ` Klaus Jensen
2020-10-20 23:04 ` Dmitry Fomichev
2020-10-19 2:17 ` [PATCH v7 02/11] hw/block/nvme: Generate namespace UUIDs Dmitry Fomichev
2020-10-19 19:24 ` Keith Busch
2020-10-19 19:30 ` Klaus Jensen
2020-10-19 2:17 ` [PATCH v7 03/11] hw/block/nvme: Add support for Namespace Types Dmitry Fomichev
2020-10-19 19:51 ` Keith Busch
2020-10-19 20:53 ` Klaus Jensen
2020-10-21 1:50 ` Dmitry Fomichev
2020-10-19 2:17 ` [PATCH v7 04/11] hw/block/nvme: Support allocated CNS command variants Dmitry Fomichev
2020-10-19 20:07 ` Keith Busch
2020-10-20 8:21 ` Klaus Jensen
2020-10-20 23:09 ` Dmitry Fomichev
2020-10-19 2:17 ` [PATCH v7 05/11] hw/block/nvme: Support Zoned Namespace Command Set Dmitry Fomichev
2020-10-19 9:50 ` Klaus Jensen
2020-10-19 15:55 ` Klaus Jensen
2020-10-19 12:33 ` Klaus Jensen
2020-10-20 11:08 ` Klaus Jensen
2020-10-21 10:26 ` Klaus Jensen [this message]
2020-10-21 23:19 ` Dmitry Fomichev
2020-10-19 2:17 ` [PATCH v7 06/11] hw/block/nvme: Introduce max active and open zone limits Dmitry Fomichev
2020-10-19 2:17 ` [PATCH v7 07/11] hw/block/nvme: Support Zone Descriptor Extensions Dmitry Fomichev
2020-10-19 2:17 ` [PATCH v7 08/11] hw/block/nvme: Add injection of Offline/Read-Only zones Dmitry Fomichev
2020-10-19 11:42 ` Klaus Jensen
2020-10-20 23:01 ` Dmitry Fomichev
2020-10-19 2:17 ` [PATCH v7 09/11] hw/block/nvme: Document zoned parameters in usage text Dmitry Fomichev
2020-10-19 2:17 ` [PATCH v7 10/11] hw/block/nvme: Separate read and write handlers Dmitry Fomichev
2020-10-20 8:28 ` Klaus Jensen
2020-10-20 12:36 ` Keith Busch
2020-10-20 23:05 ` Dmitry Fomichev
2020-10-19 2:17 ` [PATCH v7 11/11] hw/block/nvme: Merge nvme_write_zeroes() with nvme_write() Dmitry Fomichev
2020-10-20 8:29 ` Klaus Jensen
2020-10-19 7:32 ` [PATCH v7 00/11] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201021102604.GA276644@apples.localdomain \
--to=its@irrelevant.dk \
--cc=alistair.francis@wdc.com \
--cc=damien.lemoal@wdc.com \
--cc=dmitry.fomichev@wdc.com \
--cc=fam@euphon.net \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=kwolf@redhat.com \
--cc=matias.bjorling@wdc.com \
--cc=mlevitsk@redhat.com \
--cc=niklas.cassel@wdc.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).