From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C33E1C55179 for ; Thu, 22 Oct 2020 15:23:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 30693223BF for ; Thu, 22 Oct 2020 15:23:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="cgzc4SXf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 30693223BF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45218 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kVcQi-0003gx-2o for qemu-devel@archiver.kernel.org; Thu, 22 Oct 2020 11:23:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36794) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kVcOM-0001fZ-8B; Thu, 22 Oct 2020 11:20:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:49240) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kVcOK-0003CO-Fm; Thu, 22 Oct 2020 11:20:37 -0400 Received: from dhcp-10-100-145-180.wdc.com (unknown [199.255.45.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F0FD1208B8; Thu, 22 Oct 2020 15:20:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603380034; bh=+4UBEznFWi8L9nacNFO46Afm/orZAA4aXjtMa4SmhN4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cgzc4SXfBIfLK2MAPk1T0zGfOsR9Fw5nj8kWSlhHxUouNBGkVbgiseYpd6qwO1JFU YItbS0kOn62FexavD39Ol+thY/7G8F3B3NTxQTWSEatw5DlWWtI5m9ecfUf7t1h7zc nyHxv6oWGwsNUWKETVXW97vaJhwQhAH0yTNHYcPg= Date: Thu, 22 Oct 2020 08:20:31 -0700 From: Keith Busch To: Klaus Jensen Subject: Re: [PATCH 0/2] hw/block/nvme: two fixes for create sq/cq Message-ID: <20201022152031.GA1668364@dhcp-10-100-145-180.wdc.com> References: <20201022132404.190695-1-its@irrelevant.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201022132404.190695-1-its@irrelevant.dk> Received-SPF: pass client-ip=198.145.29.99; envelope-from=kbusch@kernel.org; helo=mail.kernel.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/22 11:01:06 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -70 X-Spam_score: -7.1 X-Spam_bar: ------- X-Spam_report: (-7.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Klaus Jensen , qemu-devel@nongnu.org, qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Oct 22, 2020 at 03:24:02PM +0200, Klaus Jensen wrote: > From: Klaus Jensen > > The first patch is a follow up to "hw/block/nvme: fix prp mapping status > codes" and fixes some status codes in the nvme_create_{sq,cq} functions. > > The second patch fixes a faulty check on the given queue identifier. Looks good. Reviewed-by: Keith Busch