From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B66C5C4363A for ; Mon, 26 Oct 2020 11:53:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E7C9122263 for ; Mon, 26 Oct 2020 11:53:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OdMV0/gq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E7C9122263 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41502 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kX14V-0008JM-PT for qemu-devel@archiver.kernel.org; Mon, 26 Oct 2020 07:53:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38298) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kX13m-0007sb-Ve for qemu-devel@nongnu.org; Mon, 26 Oct 2020 07:53:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:60522) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kX13j-0000LH-UV for qemu-devel@nongnu.org; Mon, 26 Oct 2020 07:53:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603713186; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5tSv4kEUJRY33T+xl+WhUrpRtH4lGUKRADQMDZy82lI=; b=OdMV0/gqevlS/r7SrVyClTVgvw0HvL2/iSY8QbEYQDsN1NEL8RY1LgzXeBLZ/NuQ2IS9VM 9hfAfT4i29JtME03fbdMRz/BRP1JLzdGyJmo/dv4j7m6UkjKNTauHh8noYJU4I+N4P0QR4 ZaDBmyd3OFbCCk2wC2hPdF0KryEc8lM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-448-X2T_fAElOFuH32J1jJSpvw-1; Mon, 26 Oct 2020 07:53:05 -0400 X-MC-Unique: X2T_fAElOFuH32J1jJSpvw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0B1B780F054; Mon, 26 Oct 2020 11:53:04 +0000 (UTC) Received: from work-vm (ovpn-112-208.ams2.redhat.com [10.36.112.208]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 14BAD5B4B7; Mon, 26 Oct 2020 11:53:02 +0000 (UTC) Date: Mon, 26 Oct 2020 11:53:00 +0000 From: "Dr. David Alan Gilbert" To: Peter Maydell Subject: Re: [PATCH] migration: Drop unused VMSTATE_FLOAT64 support Message-ID: <20201026115300.GE3277@work-vm> References: <20201022120830.5938-1-peter.maydell@linaro.org> MIME-Version: 1.0 In-Reply-To: <20201022120830.5938-1-peter.maydell@linaro.org> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dgilbert@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/25 21:03:19 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Juan Quintela Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Peter Maydell (peter.maydell@linaro.org) wrote: > Commit ef96e3ae9698d6 in January 2019 removed the last user of the > VMSTATE_FLOAT64* macros. These were used by targets which defined > their floating point register file as an array of 'float64'. > > We used to try to maintain a stricter distinction between > 'float64' (a type for holding an integer representing an IEEE float) > and 'uint64_t', including having a debug option for 'float64' being > a struct and supposedly mandatory macros for converting between > float64 and uint64_t. We no longer think that's a usefully > strong distinction to draw and we allow ourselves to freely > assume that float64 really is just a 64-bit integer type, so > for new targets we would simply recommend use of the uint64_t type > for a floating point register file. The float64 type remains > as a useful way of documenting in the type signature of helper > functions and the like that they expect to receive an IEEE float > from the TCG generated code rather than an arbitrary integer. > > Since the VMSTATE_FLOAT64* macros have no remaining users and > we don't recommend new code uses them, delete them. > > Signed-off-by: Peter Maydell Reviewed-by: Dr. David Alan Gilbert > --- > include/migration/vmstate.h | 13 ------------- > migration/vmstate-types.c | 26 -------------------------- > 2 files changed, 39 deletions(-) > > diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h > index f68ed7db13c..4d71dc8fbaa 100644 > --- a/include/migration/vmstate.h > +++ b/include/migration/vmstate.h > @@ -219,7 +219,6 @@ extern const VMStateInfo vmstate_info_uint64; > #define VMS_NULLPTR_MARKER (0x30U) /* '0' */ > extern const VMStateInfo vmstate_info_nullptr; > > -extern const VMStateInfo vmstate_info_float64; > extern const VMStateInfo vmstate_info_cpudouble; > > extern const VMStateInfo vmstate_info_timer; > @@ -997,12 +996,6 @@ extern const VMStateInfo vmstate_info_qlist; > VMSTATE_SINGLE_TEST(_f, _s, _t, 0, vmstate_info_uint64, uint64_t) > > > -#define VMSTATE_FLOAT64_V(_f, _s, _v) \ > - VMSTATE_SINGLE(_f, _s, _v, vmstate_info_float64, float64) > - > -#define VMSTATE_FLOAT64(_f, _s) \ > - VMSTATE_FLOAT64_V(_f, _s, 0) > - > #define VMSTATE_TIMER_PTR_TEST(_f, _s, _test) \ > VMSTATE_POINTER_TEST(_f, _s, _test, vmstate_info_timer, QEMUTimer *) > > @@ -1114,12 +1107,6 @@ extern const VMStateInfo vmstate_info_qlist; > #define VMSTATE_INT64_ARRAY(_f, _s, _n) \ > VMSTATE_INT64_ARRAY_V(_f, _s, _n, 0) > > -#define VMSTATE_FLOAT64_ARRAY_V(_f, _s, _n, _v) \ > - VMSTATE_ARRAY(_f, _s, _n, _v, vmstate_info_float64, float64) > - > -#define VMSTATE_FLOAT64_ARRAY(_f, _s, _n) \ > - VMSTATE_FLOAT64_ARRAY_V(_f, _s, _n, 0) > - > #define VMSTATE_CPUDOUBLE_ARRAY_V(_f, _s, _n, _v) \ > VMSTATE_ARRAY(_f, _s, _n, _v, vmstate_info_cpudouble, CPU_DoubleU) > > diff --git a/migration/vmstate-types.c b/migration/vmstate-types.c > index 35e784c9d93..e22d41d73d6 100644 > --- a/migration/vmstate-types.c > +++ b/migration/vmstate-types.c > @@ -420,32 +420,6 @@ const VMStateInfo vmstate_info_uint16_equal = { > .put = put_uint16, > }; > > -/* floating point */ > - > -static int get_float64(QEMUFile *f, void *pv, size_t size, > - const VMStateField *field) > -{ > - float64 *v = pv; > - > - *v = make_float64(qemu_get_be64(f)); > - return 0; > -} > - > -static int put_float64(QEMUFile *f, void *pv, size_t size, > - const VMStateField *field, QJSON *vmdesc) > -{ > - uint64_t *v = pv; > - > - qemu_put_be64(f, float64_val(*v)); > - return 0; > -} > - > -const VMStateInfo vmstate_info_float64 = { > - .name = "float64", > - .get = get_float64, > - .put = put_float64, > -}; > - > /* CPU_DoubleU type */ > > static int get_cpudouble(QEMUFile *f, void *pv, size_t size, > -- > 2.20.1 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK