From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Bihong Yu <yubihong@huawei.com>
Cc: zhengchuan@huawei.com, quintela@redhat.com,
qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
armbru@redhat.com, alex.chen@huawei.com, wanghao232@huawei.com
Subject: Re: [PATCH v3 0/8] Fix some style problems in migration
Date: Mon, 26 Oct 2020 12:24:55 +0000 [thread overview]
Message-ID: <20201026122455.GA28658@work-vm> (raw)
In-Reply-To: <1603163448-27122-1-git-send-email-yubihong@huawei.com>
* Bihong Yu (yubihong@huawei.com) wrote:
> Recently I am reading migration related code, find some style problems in
> migration directory while using checkpatch.pl to check migration code. Fix the
> error style problems.
>
Queued
> v2:
> - fix Signed-off-by error
> - fix printf format error: "%0x" -> "0x%x"
>
> v3:
> - change "VMStateDescription * []" to "VMStateDescription *[]"
>
> Bihong Yu (8):
> migration: Do not use C99 // comments
> migration: Don't use '#' flag of printf format
> migration: Add spaces around operator
> migration: Open brace '{' following struct go on the same line
> migration: Add braces {} for if statement
> migration: Do not initialise statics and globals to 0 or NULL
> migration: Open brace '{' following function declarations go on the
> next line
> migration: Delete redundant spaces
>
> migration/block.c | 4 ++--
> migration/migration.c | 4 ++--
> migration/migration.h | 3 +--
> migration/postcopy-ram.c | 2 +-
> migration/ram.c | 14 ++++++++------
> migration/rdma.c | 7 ++++---
> migration/savevm.c | 4 ++--
> migration/vmstate.c | 10 +++++-----
> 8 files changed, 25 insertions(+), 23 deletions(-)
>
> --
> 1.8.3.1
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
prev parent reply other threads:[~2020-10-26 12:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 3:10 [PATCH v3 0/8] Fix some style problems in migration Bihong Yu
2020-10-20 3:10 ` [PATCH v3 1/8] migration: Do not use C99 // comments Bihong Yu
2020-10-20 13:34 ` Juan Quintela
2020-10-20 3:10 ` [PATCH v3 2/8] migration: Don't use '#' flag of printf format Bihong Yu
2020-10-20 13:25 ` Juan Quintela
2020-10-20 3:10 ` [PATCH v3 3/8] migration: Add spaces around operator Bihong Yu
2020-10-20 13:36 ` Juan Quintela
2020-10-20 3:10 ` [PATCH v3 4/8] migration: Open brace '{' following struct go on the same line Bihong Yu
2020-10-20 13:37 ` Juan Quintela
2020-10-20 3:10 ` [PATCH v3 5/8] migration: Add braces {} for if statement Bihong Yu
2020-10-20 13:35 ` Juan Quintela
2020-10-20 3:10 ` [PATCH v3 6/8] migration: Do not initialise statics and globals to 0 or NULL Bihong Yu
2020-10-20 13:35 ` Juan Quintela
2020-10-20 3:10 ` [PATCH v3 7/8] migration: Open brace '{' following function declarations go on the next line Bihong Yu
2020-10-20 3:10 ` [PATCH v3 8/8] migration: Delete redundant spaces Bihong Yu
2020-10-20 13:39 ` Juan Quintela
2020-10-20 3:27 ` [PATCH v3 0/8] Fix some style problems in migration no-reply
2020-10-26 12:24 ` Dr. David Alan Gilbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201026122455.GA28658@work-vm \
--to=dgilbert@redhat.com \
--cc=alex.chen@huawei.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=quintela@redhat.com \
--cc=wanghao232@huawei.com \
--cc=yubihong@huawei.com \
--cc=zhengchuan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).