From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75A90C4363A for ; Mon, 26 Oct 2020 17:24:27 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 069AD21D7B for ; Mon, 26 Oct 2020 17:24:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="eZsNxDGl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 069AD21D7B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43846 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kX6EM-0005x9-0D for qemu-devel@archiver.kernel.org; Mon, 26 Oct 2020 13:24:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47894) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kX64A-0002AL-EF for qemu-devel@nongnu.org; Mon, 26 Oct 2020 13:13:56 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:47246) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kX648-0007dt-8i for qemu-devel@nongnu.org; Mon, 26 Oct 2020 13:13:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603732430; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2Kk07t6hlLsc4iKdRzaP6lgjP8F1hZWAM4MUSr07ye8=; b=eZsNxDGlwiScnUHwMq3b7mrNDj4FwKZB4J/U8boMn02+W58ik5fPEHGU9iwPFQS9Lx8kdC hx4YX/RL4YN31OdXcmhjAcsiVFqjMUzhBTX22up8YlTTznKIEzifHOkkrRJJfCFvlm1yEr j88if3z63LeIml689Ae+MlRBbZ0hwb8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-440-qWeoxswUNSSwN0I4EnTuSg-1; Mon, 26 Oct 2020 13:13:48 -0400 X-MC-Unique: qWeoxswUNSSwN0I4EnTuSg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 53E745719D; Mon, 26 Oct 2020 17:13:47 +0000 (UTC) Received: from work-vm (ovpn-112-208.ams2.redhat.com [10.36.112.208]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 802FB5D9E4; Mon, 26 Oct 2020 17:13:43 +0000 (UTC) Date: Mon, 26 Oct 2020 17:13:40 +0000 From: "Dr. David Alan Gilbert" To: Misono Tomohiro Subject: Re: [PATCH] virtiofsd: passthrough_ll: set FUSE_LOG_INFO as default log_level Message-ID: <20201026171340.GB152260@work-vm> References: <20201008110148.2757734-1-misono.tomohiro@jp.fujitsu.com> MIME-Version: 1.0 In-Reply-To: <20201008110148.2757734-1-misono.tomohiro@jp.fujitsu.com> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dgilbert@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/25 21:03:19 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: virtio-fs@redhat.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Misono Tomohiro (misono.tomohiro@jp.fujitsu.com) wrote: > Just noticed that although help message says default log level is INFO, > it is actually 0 (EMRGE) and no mesage will be shown when error occurs. > It's better to follow help message. > > Signed-off-by: Misono Tomohiro Queued > --- > tools/virtiofsd/passthrough_ll.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c > index 0b229ebd57..4ff9f1b688 100644 > --- a/tools/virtiofsd/passthrough_ll.c > +++ b/tools/virtiofsd/passthrough_ll.c > @@ -2888,12 +2888,11 @@ int main(int argc, char *argv[]) > goto err_out1; > } > > - /* > - * log_level is 0 if not configured via cmd options (0 is LOG_EMERG, > - * and we don't use this log level). > - */ > if (opts.log_level != 0) { > current_log_level = opts.log_level; > + } else { > + /* default log level is INFO */ > + current_log_level = FUSE_LOG_INFO; > } > lo.debug = opts.debug; > if (lo.debug) { > -- > 2.25.4 > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK