From: Igor Mammedov <imammedo@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: Peng Liang <liangpeng10@huawei.com>,
mst@redhat.com, qemu-devel@nongnu.org, xiexiangyou@huawei.com,
zhang.zhanghailiang@huawei.com
Subject: Re: [PATCH] ACPI: Avoid infinite recursion when dump-vmstate
Date: Wed, 11 Nov 2020 18:13:06 +0100 [thread overview]
Message-ID: <20201111181306.20ebdd77@redhat.com> (raw)
In-Reply-To: <20201111140112.GE3232@work-vm>
On Wed, 11 Nov 2020 14:01:12 +0000
"Dr. David Alan Gilbert" <dgilbert@redhat.com> wrote:
> Is someone taking a fix for this in 5.2 - it's breaking vmstate
> comparison.
can you merge it via migration tree?
[...]
for fixed up version below
Acked-by: Igor Mammedov <imammedo@redhat.com>
> >
> > Do you mean that we need another VMStateDescription to describe
> > AcpiGhesState instead of using VMSTATE_UINT64 directly? Maybe like this:
> >
> > diff --git a/hw/acpi/generic_event_device.c b/hw/acpi/generic_event_device.c
> > index 6df400e1ee16..5454be67d5f0 100644
> > --- a/hw/acpi/generic_event_device.c
> > +++ b/hw/acpi/generic_event_device.c
> > @@ -322,6 +322,16 @@ static const VMStateDescription vmstate_ged_state = {
> > }
> > };
> >
> > +static const VMStateDescription vmstate_ghes = {
> > + .name = "acpi-ghes",
> > + .version_id = 1,
> > + .minimum_version_id = 1,
> > + .fields = (VMStateField[]) {
> > + VMSTATE_UINT64(ghes_addr_le, AcpiGhesState),
> > + VMSTATE_END_OF_LIST()
> > + },
> > +};
> > +
> > static bool ghes_needed(void *opaque)
> > {
> > AcpiGedState *s = opaque;
> > @@ -335,7 +345,7 @@ static const VMStateDescription vmstate_ghes_state = {
> > .needed = ghes_needed,
> > .fields = (VMStateField[]) {
> > VMSTATE_STRUCT(ghes_state, AcpiGedState, 1,
> > - vmstate_ghes_state, AcpiGhesState),
> > + vmstate_ghes, AcpiGhesState),
> > VMSTATE_END_OF_LIST()
> > }
> > };
> >
> > --
> > Thanks,
> > Peng
> >
next prev parent reply other threads:[~2020-11-11 17:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 9:31 [PATCH] ACPI: Avoid infinite recursion when dump-vmstate Peng Liang
2020-10-23 16:09 ` Igor Mammedov
2020-10-23 18:54 ` Dr. David Alan Gilbert
2020-10-23 19:23 ` Igor Mammedov
2020-10-26 9:40 ` Dr. David Alan Gilbert
2020-10-26 6:22 ` Peng Liang
2020-11-11 14:01 ` Dr. David Alan Gilbert
2020-11-11 17:13 ` Igor Mammedov [this message]
2020-11-11 17:26 ` Dr. David Alan Gilbert
2020-11-12 1:28 ` Peng Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201111181306.20ebdd77@redhat.com \
--to=imammedo@redhat.com \
--cc=dgilbert@redhat.com \
--cc=liangpeng10@huawei.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xiexiangyou@huawei.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).