From: Mauro Matteo Cascella <mcascell@redhat.com>
To: qemu-devel@nongnu.org
Cc: jasowang@redhat.com, pgn@zju.edu.cn, mcascell@redhat.com
Subject: [PATCH] hw/net/dp8393x: fix integer underflow in dp8393x_do_transmit_packets()
Date: Tue, 24 Nov 2020 10:24:45 +0100 [thread overview]
Message-ID: <20201124092445.658647-1-mcascell@redhat.com> (raw)
An integer underflow could occur during packet transmission due to 'tx_len' not
being updated if SONIC_TFC register is set to zero. Check for negative 'tx_len'
when removing existing FCS.
RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1899722
Signed-off-by: Mauro Matteo Cascella <mcascell@redhat.com>
Reported-by: Gaoning Pan <pgn@zju.edu.cn>
---
hw/net/dp8393x.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c
index 674b04b354..205c0decc5 100644
--- a/hw/net/dp8393x.c
+++ b/hw/net/dp8393x.c
@@ -495,6 +495,10 @@ static void dp8393x_do_transmit_packets(dp8393xState *s)
} else {
/* Remove existing FCS */
tx_len -= 4;
+ if (tx_len < 0) {
+ SONIC_ERROR("tx_len is %d\n", tx_len);
+ break;
+ }
}
if (s->regs[SONIC_RCR] & (SONIC_RCR_LB1 | SONIC_RCR_LB0)) {
--
2.28.0
next reply other threads:[~2020-11-24 9:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 9:24 Mauro Matteo Cascella [this message]
2020-11-30 10:44 ` [PATCH] hw/net/dp8393x: fix integer underflow in dp8393x_do_transmit_packets() Philippe Mathieu-Daudé
2020-11-30 12:11 ` Mauro Matteo Cascella
2020-12-01 5:46 ` Jason Wang
2020-12-01 12:09 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201124092445.658647-1-mcascell@redhat.com \
--to=mcascell@redhat.com \
--cc=jasowang@redhat.com \
--cc=pgn@zju.edu.cn \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).