From: Greg Kurz <groug@kaod.org>
To: qemu-devel@nongnu.org
Cc: Igor Mammedov <imammedo@redhat.com>,
qemu-ppc@nongnu.org, Greg Kurz <groug@kaod.org>,
David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH for-6.0 v2 0/4] spapr: Perform hotplug sanity checks at pre-plug
Date: Tue, 1 Dec 2020 12:37:24 +0100 [thread overview]
Message-ID: <20201201113728.885700-1-groug@kaod.org> (raw)
Igor recently suggested that instead of failing in spapr_drc_attach()
at plug time we should rather check that the DRC is attachable at
pre-plug time. This allows to error out before the hot-plugged device
is even realized and to come up with simpler plug callbacks.
sPAPR currently supports hotplug of PCI devices, PHBs, CPU cores,
PC-DIMM/NVDIMM memory and TPM proxy devices. Some of these already
do sanity checks at pre-plug that are sufficient to ensure the DRC
are attachables. Some others don't even have a pre-plug handler.
This series adds the missing pieces so that all failing conditions
are caught at pre-plug time instead of plug time for all devices.
v2: - hopefully less fragile way of setting compat mode for hot-plugged
CPUs
Greg Kurz (4):
spapr: Fix pre-2.10 dummy ICP hack
spapr: Abort if ppc_set_compat() fails for hot-plugged CPUs
spapr: Simplify error path of spapr_core_plug()
spapr: spapr_drc_attach() cannot fail
include/hw/ppc/spapr_drc.h | 8 ++++++-
hw/ppc/spapr.c | 49 ++++++++++++++++++--------------------
hw/ppc/spapr_drc.c | 8 ++-----
hw/ppc/spapr_nvdimm.c | 2 +-
hw/ppc/spapr_pci.c | 2 +-
5 files changed, 34 insertions(+), 35 deletions(-)
--
2.26.2
next reply other threads:[~2020-12-01 11:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 11:37 Greg Kurz [this message]
2020-12-01 11:37 ` [PATCH for-6.0 v2 1/4] spapr: Fix pre-2.10 dummy ICP hack Greg Kurz
2020-12-01 11:37 ` [PATCH for-6.0 v2 2/4] spapr: Abort if ppc_set_compat() fails for hot-plugged CPUs Greg Kurz
2020-12-01 11:37 ` [PATCH for-6.0 v2 3/4] spapr: Simplify error path of spapr_core_plug() Greg Kurz
2020-12-01 11:37 ` [PATCH for-6.0 v2 4/4] spapr: spapr_drc_attach() cannot fail Greg Kurz
2020-12-02 3:16 ` [PATCH for-6.0 v2 0/4] spapr: Perform hotplug sanity checks at pre-plug David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201201113728.885700-1-groug@kaod.org \
--to=groug@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).