From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 210BBC4361B for ; Fri, 11 Dec 2020 20:15:06 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 541F923125 for ; Fri, 11 Dec 2020 20:15:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 541F923125 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46282 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1knooh-0003ot-Sg for qemu-devel@archiver.kernel.org; Fri, 11 Dec 2020 15:15:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57160) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1knoPB-0007KJ-Mn for qemu-devel@nongnu.org; Fri, 11 Dec 2020 14:48:41 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:39671) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1knoP4-0003Py-Ff for qemu-devel@nongnu.org; Fri, 11 Dec 2020 14:48:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607716113; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pZsD8WQXUb/xlSoy3KRoA6W8Hmis8Jy0nZmG8g4g1EY=; b=S/mbwttBP4xP3ijV7cvu9JmkqDq6FsH+y00YMAMOZLll9ohHsC3kWPR5fBUQ7as+xQPcaB 3kyeP/8EoHM71YTk7wDqfczwjZ+V+vfeGOQxjGOPr0NsIa6HhiEpT72RzHjh8wp0mGfAVR E95kdHOpjzjb7pCLUhpefzbcXIq9lhM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-557-Rl5KRjB6Nb-pNfPVwx8Aow-1; Fri, 11 Dec 2020 14:48:31 -0500 X-MC-Unique: Rl5KRjB6Nb-pNfPVwx8Aow-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 44058805EE3; Fri, 11 Dec 2020 19:48:30 +0000 (UTC) Received: from localhost (ovpn-116-160.rdu2.redhat.com [10.10.116.160]) by smtp.corp.redhat.com (Postfix) with ESMTP id F2F595D97C; Fri, 11 Dec 2020 19:48:29 +0000 (UTC) Date: Fri, 11 Dec 2020 14:48:28 -0500 From: Eduardo Habkost To: Markus Armbruster Subject: Re: [PATCH 11/20] Revert "qobject: let object_property_get_str() use new API" Message-ID: <20201211194828.GD1289986@habkost.net> References: <20201211171152.146877-1-armbru@redhat.com> <20201211171152.146877-12-armbru@redhat.com> MIME-Version: 1.0 In-Reply-To: <20201211171152.146877-12-armbru@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ehabkost@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=ehabkost@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Daniel P =?utf-8?B?LiBCZXJyYW5nw6k=?= , qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Dec 11, 2020 at 06:11:43PM +0100, Markus Armbruster wrote: > Commit aafb21a0b9 "qobject: let object_property_get_str() use new API" > isn't much of a simplification. Not worth having > object_property_get_str() differ from the other > object_property_get_FOO(). Revert. > > This reverts commit aafb21a0b9cea5fa0fe52e68111bb6bd13837a02. > > Cc: Paolo Bonzini > Cc: Daniel P. Berrangé > Cc: Eduardo Habkost > Signed-off-by: Markus Armbruster Reviewed-by: Eduardo Habkost -- Eduardo