From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41F5EC4361B for ; Thu, 17 Dec 2020 18:30:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 49B402389F for ; Thu, 17 Dec 2020 18:30:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 49B402389F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42964 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kpy2K-0007H2-6W for qemu-devel@archiver.kernel.org; Thu, 17 Dec 2020 13:30:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57118) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpy1b-0006ma-Lx for qemu-devel@nongnu.org; Thu, 17 Dec 2020 13:29:15 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:24668) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kpy1Z-0008KQ-I7 for qemu-devel@nongnu.org; Thu, 17 Dec 2020 13:29:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1608229751; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9pc84JSqpJor5txpReTnUrRtyK4+zJp5NVckqHkQetg=; b=ITLZO+T0X4gOkGIoSkFx4TnpFUW9khoHJLJ7WvzQdZQYCR9NKO9CqT7XAzb0TBBKiRG35K e6x8QHQUNI+Ibo1y/G58q5gIwYOjxY1IXYpCAgtYrIp4AaKDuREvqEHBxt2XsFkkVgg/ww LiSA8bribJHdRxBu3m5Jzs3VlQjzDrs= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-201-7aGVJKEWPy6EDWrl_78k2w-1; Thu, 17 Dec 2020 13:29:10 -0500 X-MC-Unique: 7aGVJKEWPy6EDWrl_78k2w-1 Received: by mail-wm1-f69.google.com with SMTP id r1so3455069wmn.8 for ; Thu, 17 Dec 2020 10:29:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9pc84JSqpJor5txpReTnUrRtyK4+zJp5NVckqHkQetg=; b=PG4PFunNZ1bMn7dpUJMBWQkmTJSkz3bvmXZh0lGTFlYQhSDgtrN1gehTCFVuU35wYW TKux9QY3DJCzs1Cs3u5+Fiy9MpjrFRfVE3TmHv9cH1ScxXBOIOqTmPHvuczFxaAWpeoP mbv20wW2fHAwmvic63Q47vlWvYAXK4BiHhz3C89WWSyxXRRVSk8kfOlgipdYYgPpvDgg j+D3VPYbO6/l3x4s5B1qL8HRTFDwp+POQMrzu4xLTNUFYGpzJtEuni3mfNfhe7oYvpja E0yPQp6Dp19nivBo6mviZVnwIccRqUWxZiE+GFsvDnPNOzXY298juilwx6b5kcHI312c xrdA== X-Gm-Message-State: AOAM531QWkE8zlNDQjFfw+GXDX+HrsVU0repD7ZZmqUbl9g9+2izK72s d5TqDr0ygNm1/ntJyu0bMIpJgX9qiz6orOnamMYB1a2siy9jBxDX3to2u/ubH045lxfohgWglGq JOtHtzr4Xx6UHrgM= X-Received: by 2002:a7b:cbda:: with SMTP id n26mr649466wmi.144.1608229748174; Thu, 17 Dec 2020 10:29:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJxneDy82L9kp79rI/bN6am/vBFqNBpSfMFnLWvgkjCOTa50GX8Lztwq8ZpwuIg6Ln+q6rbNiw== X-Received: by 2002:a7b:cbda:: with SMTP id n26mr649450wmi.144.1608229747981; Thu, 17 Dec 2020 10:29:07 -0800 (PST) Received: from redhat.com (bzq-79-178-32-166.red.bezeqint.net. [79.178.32.166]) by smtp.gmail.com with ESMTPSA id o13sm8378569wmc.44.2020.12.17.10.29.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Dec 2020 10:29:06 -0800 (PST) Date: Thu, 17 Dec 2020 13:29:03 -0500 From: "Michael S. Tsirkin" To: Jiahui Cen Subject: Re: [PATCH] acpi/gpex: Inform os to keep firmware resource map Message-ID: <20201217132844-mutt-send-email-mst@kernel.org> References: <20201217132926.4812-1-cenjiahui@huawei.com> MIME-Version: 1.0 In-Reply-To: <20201217132926.4812-1-cenjiahui@huawei.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: xieyingtai@huawei.com, Igor Mammedov , qemu-devel@nongnu.org, Gerd Hoffmann Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Dec 17, 2020 at 09:29:26PM +0800, Jiahui Cen wrote: > There may be some differences in pci resource assignment between guest os > and firmware. > > Eg. A Bridge with Bus [d2] > -+-[0000:d2]---01.0-[d3]----01.0 > > where [d2:01.00] is a pcie-pci-bridge with BAR0 (mem, 64-bit, non-pref) [size=256] > [d3:01.00] is a PCI Device with BAR0 (mem, 64-bit, pref) [size=128K] > BAR4 (mem, 64-bit, pref) [size=64M] > > In EDK2, the Resource Map would be: > PciBus: Resource Map for Bridge [D2|01|00] > Type = PMem64; Base = 0x8004000000; Length = 0x4100000; Alignment = 0x3FFFFFF > Base = 0x8004000000; Length = 0x4000000; Alignment = 0x3FFFFFF; Owner = PCI [D3|01|00:20] > Base = 0x8008000000; Length = 0x20000; Alignment = 0x1FFFF; Owner = PCI [D3|01|00:10] > Type = Mem64; Base = 0x8008100000; Length = 0x100; Alignment = 0xFFF > > While in Linux, kernel will use 0x2FFFFFF as the alignment to calculate > the PMem64 size, which would be 0x6000000. > > The diffences could result in resource assignment failure. A bit more data here please. When does this result in a failure? > Using _DSM #5 method to inform guest os not to ignore the PCI configuration > that firmware has done at boot time could handle the differences. > > Signed-off-by: Jiahui Cen > --- > hw/pci-host/gpex-acpi.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/hw/pci-host/gpex-acpi.c b/hw/pci-host/gpex-acpi.c > index 071aa11b5c..2b490f3379 100644 > --- a/hw/pci-host/gpex-acpi.c > +++ b/hw/pci-host/gpex-acpi.c > @@ -112,10 +112,19 @@ static void acpi_dsdt_add_pci_osc(Aml *dev) > UUID = aml_touuid("E5C937D0-3553-4D7A-9117-EA4D19C3434D"); > ifctx = aml_if(aml_equal(aml_arg(0), UUID)); > ifctx1 = aml_if(aml_equal(aml_arg(2), aml_int(0))); > - uint8_t byte_list[1] = {1}; > + uint8_t byte_list[1] = {0x21}; > buf = aml_buffer(1, byte_list); > aml_append(ifctx1, aml_return(buf)); > aml_append(ifctx, ifctx1); > + > + /* PCI Firmware Specification 3.2 > + * 4.6.5. _DSM for Ignoring PCI Boot Configurations > + * The UUID in _DSM in this context is > + * {E5C937D0-3553-4D7A-9117-EA4D19C3434D} > + */ > + ifctx1 = aml_if(aml_equal(aml_arg(2), aml_int(5))); > + aml_append(ifctx1, aml_return(aml_int(0))); > + aml_append(ifctx, ifctx1); > aml_append(method, ifctx); > > byte_list[0] = 0; > -- > 2.28.0