From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FDE6C4361B for ; Thu, 17 Dec 2020 13:19:04 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5CFAD2389A for ; Thu, 17 Dec 2020 13:19:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5CFAD2389A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33754 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kptBO-0004y5-0L for qemu-devel@archiver.kernel.org; Thu, 17 Dec 2020 08:19:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38052) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpt37-0007B1-Ew for qemu-devel@nongnu.org; Thu, 17 Dec 2020 08:10:31 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:44030) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kpt31-0004IM-0E for qemu-devel@nongnu.org; Thu, 17 Dec 2020 08:10:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1608210622; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oQAErxFq8UJn8Xoaa8u3QsVOZADUcDDrqJDNizvUzFU=; b=bUlSGXEX4pUuOm7KbPbMmtDU4GALcUWUyZdx0B18tl+x8bsRH488AaVlk8ToHJBMrJ//jW or0sb3+j3iDr4/OkPsrKrYFurlFVZcP8sa3G93zy4qEunEHiyqWxiRJ2TASTeBDwMOjRSM JWI9H98PnjOFpa3ZDyw/Pt0V7dyc95c= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-159-jXPRdbd7NwWwSbYplpdNkA-1; Thu, 17 Dec 2020 08:10:20 -0500 X-MC-Unique: jXPRdbd7NwWwSbYplpdNkA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D5AFF6D520; Thu, 17 Dec 2020 13:10:18 +0000 (UTC) Received: from gondolin (ovpn-113-176.ams2.redhat.com [10.36.113.176]) by smtp.corp.redhat.com (Postfix) with ESMTP id A79A91A353; Thu, 17 Dec 2020 13:10:01 +0000 (UTC) Date: Thu, 17 Dec 2020 14:09:58 +0100 From: Cornelia Huck To: Matthew Rosato Subject: Re: [RFC 3/8] s390x/pci: fix pcistb length Message-ID: <20201217140958.7fcfa9f1.cohuck@redhat.com> In-Reply-To: <84b3a7bf-6a37-bd9f-cd99-8eb969c83bda@linux.ibm.com> References: <1607546066-2240-1-git-send-email-mjrosato@linux.ibm.com> <1607546066-2240-4-git-send-email-mjrosato@linux.ibm.com> <20201210113006.666ce143.cohuck@redhat.com> <84b3a7bf-6a37-bd9f-cd99-8eb969c83bda@linux.ibm.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: thuth@redhat.com, pmorel@linux.ibm.com, david@redhat.com, schnelle@linux.ibm.com, richard.henderson@linaro.org, qemu-s390x@nongnu.org, qemu-devel@nongnu.org, pasic@linux.ibm.com, borntraeger@de.ibm.com, alex.williamson@redhat.com, mst@redhat.com, pbonzini@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 10 Dec 2020 10:15:06 -0500 Matthew Rosato wrote: > On 12/10/20 5:30 AM, Cornelia Huck wrote: > > On Wed, 9 Dec 2020 15:34:21 -0500 > > Matthew Rosato wrote: > > > >> In pcistb_service_call, we are grabbing 8 bits from a guest register to > >> indicate the length of the store operation -- but per the architecture > >> the length is actually defined by 13 bits of the guest register. > >> > >> Signed-off-by: Matthew Rosato > >> Reviewed-by: Pierre Morel > >> --- > >> hw/s390x/s390-pci-inst.c | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-inst.c > >> index 70bfd91..db86f12 100644 > >> --- a/hw/s390x/s390-pci-inst.c > >> +++ b/hw/s390x/s390-pci-inst.c > >> @@ -750,7 +750,7 @@ int pcistb_service_call(S390CPU *cpu, uint8_t r1, uint8_t r3, uint64_t gaddr, > >> int i; > >> uint32_t fh; > >> uint8_t pcias; > >> - uint8_t len; > >> + uint16_t len; > >> uint8_t buffer[128]; > >> > >> if (env->psw.mask & PSW_MASK_PSTATE) { > >> @@ -760,7 +760,7 @@ int pcistb_service_call(S390CPU *cpu, uint8_t r1, uint8_t r3, uint64_t gaddr, > >> > >> fh = env->regs[r1] >> 32; > >> pcias = (env->regs[r1] >> 16) & 0xf; > >> - len = env->regs[r1] & 0xff; > >> + len = env->regs[r1] & 0x1fff; > >> offset = env->regs[r3]; > >> > >> if (!(fh & FH_MASK_ENABLE)) { > > > > Is that a general problem that we just did not notice before? > > > > If yes, this probably deserves a Fixes: tag and can be queued > > independently of the rest of the series. > > > > Good point. I can split this out, and same for "s390x/pci: Fix > memory_region_access_valid call" > Any plans for sending this? I'm currently collecting patches for a last pull request before the holidays; but I'm sure there will be more pull requests next year :)