From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: qemu-devel@nongnu.org, tuguoyi@outlook.com, berrange@redhat.com,
Tuguoyi <tu.guoyi@h3c.com>, Juan Quintela <quintela@redhat.com>
Subject: Re: [PATCH 1/2] savevm: Remove dead code in save_snapshot()
Date: Thu, 17 Dec 2020 17:32:34 +0000 [thread overview]
Message-ID: <20201217173234.GN4117@work-vm> (raw)
In-Reply-To: <5b4d677b-88aa-ab28-cc2a-dc7d1c4934b8@openvz.org>
* Denis V. Lunev (den@openvz.org) wrote:
> On 12/17/20 6:27 PM, Dr. David Alan Gilbert wrote:
> > * Tuguoyi (tu.guoyi@h3c.com) wrote:
> >> The snapshot in each bs is deleted at the beginning, so there is no need
> >> to find the snapshot again.
> >>
> >> Signed-off-by: Tuguoyi <tu.guoyi@h3c.com>
> > This looks OK to me, becoming redundant after Denis's 0b46160 - but
> > I don't know the snapshot code much;
> >
> > Denis - do you agree this is correct?
>
> For me it looks too that the code becomes redundant, thus
>
> Reviewed-by: Denis V. Lunev <den@openvz.org>
Thanks!
(Both patches) queued
> > Dave
> >
> >> ---
> >> migration/savevm.c | 10 ++--------
> >> 1 file changed, 2 insertions(+), 8 deletions(-)
> >>
> >> diff --git a/migration/savevm.c b/migration/savevm.c
> >> index 5f937a2..601b514 100644
> >> --- a/migration/savevm.c
> >> +++ b/migration/savevm.c
> >> @@ -2728,7 +2728,7 @@ int qemu_load_device_state(QEMUFile *f)
> >> int save_snapshot(const char *name, Error **errp)
> >> {
> >> BlockDriverState *bs, *bs1;
> >> - QEMUSnapshotInfo sn1, *sn = &sn1, old_sn1, *old_sn = &old_sn1;
> >> + QEMUSnapshotInfo sn1, *sn = &sn1;
> >> int ret = -1, ret2;
> >> QEMUFile *f;
> >> int saved_vm_running;
> >> @@ -2797,13 +2797,7 @@ int save_snapshot(const char *name, Error **errp)
> >> }
> >>
> >> if (name) {
> >> - ret = bdrv_snapshot_find(bs, old_sn, name);
> >> - if (ret >= 0) {
> >> - pstrcpy(sn->name, sizeof(sn->name), old_sn->name);
> >> - pstrcpy(sn->id_str, sizeof(sn->id_str), old_sn->id_str);
> >> - } else {
> >> - pstrcpy(sn->name, sizeof(sn->name), name);
> >> - }
> >> + pstrcpy(sn->name, sizeof(sn->name), name);
> >> } else {
> >> /* cast below needed for OpenBSD where tv_sec is still 'long' */
> >> localtime_r((const time_t *)&tv.tv_sec, &tm);
> >> --
> >> 2.7.4
> >>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2020-12-17 17:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 6:53 [PATCH 0/2] savevm: Delete stale snapshots in save_snapshot() Tuguoyi
2020-12-08 6:53 ` [PATCH 1/2] savevm: Remove dead code " Tuguoyi
2020-12-17 15:27 ` Dr. David Alan Gilbert
2020-12-17 16:14 ` Denis V. Lunev
2020-12-17 17:32 ` Dr. David Alan Gilbert [this message]
2020-12-08 6:53 ` [PATCH 2/2] savevm: Delete snapshots just created in case of error Tuguoyi
2020-12-17 15:38 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201217173234.GN4117@work-vm \
--to=dgilbert@redhat.com \
--cc=berrange@redhat.com \
--cc=den@openvz.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=tu.guoyi@h3c.com \
--cc=tuguoyi@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).