From: Cornelia Huck <cohuck@redhat.com>
To: Willian Rampazzo <wrampazz@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>,
qemu-devel@nongnu.org,
Wainer dos Santos Moschetta <wainersm@redhat.com>,
Willian Rampazzo <willianr@redhat.com>,
qemu-s390x@nongnu.org, Cleber Rosa <crosa@redhat.com>
Subject: Re: [PATCH v2] tests/acceptance: Add a test with the Fedora 31 kernel and initrd
Date: Mon, 21 Dec 2020 13:59:55 +0100 [thread overview]
Message-ID: <20201221135955.69b0b182.cohuck@redhat.com> (raw)
In-Reply-To: <d341b59d-17bb-a159-0bbd-e53e2dab9f65@redhat.com>
On Fri, 18 Dec 2020 15:23:32 -0300
Willian Rampazzo <wrampazz@redhat.com> wrote:
> On 12/17/20 5:53 AM, Thomas Huth wrote:
> > + # Hot-plug a virtio-crypto device and see whether it gets accepted
> > + self.clear_guest_dmesg()
>
> Your previous patch "[PATCH 1/3] tests/acceptance: Extract the code to
> clear dmesg and wait for CRW reports" defined the method as
> "clear_guests_dmesg". After fixing this in the code:
Hm, I see clear_guest_dmesg in the code I have on my s390-next branch?
>
> Tested-by: Willian Rampazzo <willianr@redhat.com>
>
> > + self.vm.command('object-add', qom_type='cryptodev-backend-builtin',
> > + id='cbe0')
> > + self.vm.command('device_add', driver='virtio-crypto-ccw', id='crypdev0',
> > + cryptodev='cbe0')
> > + exec_command_and_wait_for_pattern(self,
> > + 'while ! (dmesg -c | grep Accelerator.device) ; do'
> > + ' sleep 1 ; done', 'Accelerator device is ready')
> > + self.vm.command('device_del', id='crypdev0')
> > + self.vm.command('object-del', id='cbe0')
> > + exec_command_and_wait_for_pattern(self,
> > + 'while ! (dmesg -c | grep Start.virtcrypto_remove) ; do'
> > + ' sleep 1 ; done', 'Start virtcrypto_remove.')
> >
>
> Reviewed-by: Willian Rampazzo <willianr@redhat.com>
>
next prev parent reply other threads:[~2020-12-21 13:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 8:53 [PATCH v2] tests/acceptance: Add a test with the Fedora 31 kernel and initrd Thomas Huth
2020-12-18 13:38 ` Cornelia Huck
2020-12-21 13:05 ` Thomas Huth
2020-12-21 13:32 ` Cornelia Huck
2020-12-18 15:05 ` Wainer dos Santos Moschetta
2020-12-21 13:27 ` Thomas Huth
2020-12-18 18:23 ` Willian Rampazzo
2020-12-21 12:59 ` Cornelia Huck [this message]
2020-12-21 13:24 ` Thomas Huth
2020-12-21 15:10 ` Willian Rampazzo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201221135955.69b0b182.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=crosa@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
--cc=willianr@redhat.com \
--cc=wrampazz@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).