From: Peter Xu <peterx@redhat.com>
To: Eric Farman <farman@linux.ibm.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Thomas Huth <thuth@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-s390x <qemu-s390x@nongnu.org>,
Cornelia Huck <cohuck@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v3 1/3] update-linux-headers: Include const.h
Date: Thu, 7 Jan 2021 14:12:12 -0500 [thread overview]
Message-ID: <20210107191212.GB355967@xz-x1> (raw)
In-Reply-To: <cfbc49a9-9377-49d6-3c1d-b97c5e3ed2bf@linux.ibm.com>
On Thu, Jan 07, 2021 at 12:50:34PM -0500, Eric Farman wrote:
>
>
> On 1/7/21 12:05 PM, Peter Maydell wrote:
> > On Thu, 7 Jan 2021 at 16:52, Eric Farman <farman@linux.ibm.com> wrote:
> > > On 1/6/21 2:03 PM, Peter Xu wrote:
> > > > Could I ask why the const.h is installed into include/standard-headers/linux
> > > > rather than linux-headers/linux? When I was working on my version I failed to
> > > > figure out the difference.
> > >
> > > Considering the main difference is whether the header file is copied
> > > directly or edited with a bunch of substitutions, and const.h doesn't
> > > get modified by those substitutions, I suppose it could go in
> > > linux-headers itself.
> >
> > No, it can't, because linux-headers/ only goes on the include
> > path when on a Linux host and on a CPU architecture with KVM support,
> > whereas include/standard-headers/ headers are available and
> > used on all host OSes/architectures.
> >
> > Because include/standard-headers/linux/ethtool.h will end up
> > with a line
> > #include "standard-headers/linux/const.h"
> > we need to provide a const.h in that location so that the #include
> > pulls in the file correctly.
>
> Ah, today I learned. Thanks, Peter.
Yeah. Peter taught me the rules on IRC after I posted the email, and I didn't
update later. So I guess my r-b stands. :) Thanks,
--
Peter Xu
next prev parent reply other threads:[~2021-01-07 19:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 20:20 [PATCH v3 0/3] vfio-ccw: Implement request notifier Eric Farman
2021-01-04 20:20 ` [PATCH v3 1/3] update-linux-headers: Include const.h Eric Farman
2021-01-06 19:03 ` Peter Xu
2021-01-07 16:51 ` Eric Farman
2021-01-07 17:05 ` Peter Maydell
2021-01-07 17:50 ` Eric Farman
2021-01-07 19:12 ` Peter Xu [this message]
2021-01-07 6:52 ` Philippe Mathieu-Daudé
2021-01-04 20:20 ` [PATCH v3 2/3] Update linux headers to 5.11-rc2 Eric Farman
2021-01-11 12:54 ` Cornelia Huck
2021-01-11 13:00 ` Michael S. Tsirkin
2021-01-11 13:43 ` Cornelia Huck
2021-01-11 15:00 ` Michael S. Tsirkin
2021-01-11 15:11 ` Eric Farman
2021-01-11 15:18 ` Michael S. Tsirkin
2021-01-11 16:05 ` Cornelia Huck
2021-01-13 11:27 ` Cornelia Huck
2021-01-04 20:20 ` [PATCH v3 3/3] vfio-ccw: Connect the device request notifier Eric Farman
2021-01-13 12:58 ` [PATCH v3 0/3] vfio-ccw: Implement " Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210107191212.GB355967@xz-x1 \
--to=peterx@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=dgilbert@redhat.com \
--cc=farman@linux.ibm.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).