From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47C01C433DB for ; Tue, 12 Jan 2021 18:41:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CEDF02222A for ; Tue, 12 Jan 2021 18:41:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CEDF02222A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34022 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kzObF-0006CD-Q4 for qemu-devel@archiver.kernel.org; Tue, 12 Jan 2021 13:41:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55392) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzOWQ-0001A4-Sw; Tue, 12 Jan 2021 13:36:03 -0500 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]:38817) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kzOWP-0007IV-D3; Tue, 12 Jan 2021 13:36:02 -0500 Received: by mail-ed1-x534.google.com with SMTP id w10so2536878edu.5; Tue, 12 Jan 2021 10:36:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cIbTTFaWqBlw1RG7hwtN0wXtBq0CsVDSjfCtHIelito=; b=oa8ugs1bbQImjYGvzrrC9iWH7/IjBH8mPKKCZ8C05gGEOlFpRWPXcWH4bujSXJxR8L vfdcmn6vRw7g3PkYOqWmlzTbHMNuY1Ph7Irgfxri+atvvyZtQN/41RqW7jM5djB97iUw ir2MPcYNIOm8vAX8c5zUSTIwz5ikhwBjsvnKdgbCuC0y4NzD7nqrrEtLK84qtCfZ9Pyy d857Hx/cImqGReyN6V3IacfHN0VmVMQ+ng/9uFA/GNnDlGZU9qHodYNM8iiS86lZhSKa qFSarRoX10B9uNaB6TRZJbBqeVfKG70WV+My3vz1aGTACF3yp615ysOW/t8kmLyR+2WT c7/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=cIbTTFaWqBlw1RG7hwtN0wXtBq0CsVDSjfCtHIelito=; b=Tns69vjJxrRWRbAb8MMQ/0keXswoxC6n/Ox0pFXMTthbwVysSp7k4OFHgP1j7S1wWY N1zyaIQvfW2yxWmlb65ORsIevkxcs++Q2no9ulqoHMxdwNMC3wBGKY/XxjessMJncmeQ dageGtA/yMZm74y+fXli5fKDWkbiL5u2O99i2pjUUNH8uoUUU/CjTtmundgJmdVSwXkQ xbYdRJtU3c97gC3byOdslFkG/1vHW5iuVlY4Yh3Pvuw3eY1z2g4LSKn5/ilWtoxbgd0s N4/SjAu6STgD2/NWLGgO31uj214yusy3muioOR5OAwwqcD/qK4UvQNLxotpc0zm9WIeJ lTyg== X-Gm-Message-State: AOAM5305MBO8W3RAUIV9o0yQ6EjOJAKq/IlAS2z38z7QIDBnaY45/px6 lLOefOCISYDpDsDDX4u3i6M= X-Google-Smtp-Source: ABdhPJwXzxR76AAx/y9vRklqRXPWNY6DAT3STKdSWqBWNiTOJe5HoaMnC6gcmQVmIM/ugRNI5omFog== X-Received: by 2002:a50:f745:: with SMTP id j5mr384426edn.92.1610476559715; Tue, 12 Jan 2021 10:35:59 -0800 (PST) Received: from x1w.redhat.com (190.red-83-57-173.dynamicip.rima-tde.net. [83.57.173.190]) by smtp.gmail.com with ESMTPSA id x16sm1526282ejb.38.2021.01.12.10.35.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jan 2021 10:35:59 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Bin Meng , qemu-devel@nongnu.org, Bin Meng Subject: [RFC PATCH v6 03/11] hw/ssi: imx_spi: Convert some debug printf()s to trace events Date: Tue, 12 Jan 2021 19:35:21 +0100 Message-Id: <20210112183529.2011863-4-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210112183529.2011863-1-f4bug@amsat.org> References: <20210112183529.2011863-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::534; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ed1-x534.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jean-Christophe Dubois , qemu-arm@nongnu.org, Peter Chubb Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Convert some DPRINTF() to trace events. Signed-off-by: Philippe Mathieu-Daudé --- hw/ssi/imx_spi.c | 8 ++++---- hw/ssi/trace-events | 7 +++++++ 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/hw/ssi/imx_spi.c b/hw/ssi/imx_spi.c index 40f72c36b61..35ab33c0511 100644 --- a/hw/ssi/imx_spi.c +++ b/hw/ssi/imx_spi.c @@ -14,6 +14,7 @@ #include "migration/vmstate.h" #include "qemu/log.h" #include "qemu/module.h" +#include "trace.h" #ifndef DEBUG_IMX_SPI #define DEBUG_IMX_SPI 0 @@ -232,7 +233,7 @@ static void imx_spi_reset(DeviceState *dev) { IMXSPIState *s = IMX_SPI(dev); - DPRINTF("\n"); + trace_imx_spi_reset(); memset(s->regs, 0, sizeof(s->regs)); @@ -290,7 +291,7 @@ static uint64_t imx_spi_read(void *opaque, hwaddr offset, unsigned size) break; } - DPRINTF("reg[%s] => 0x%" PRIx32 "\n", imx_spi_reg_name(index), value); + trace_imx_spi_read(index, imx_spi_reg_name(index), value); imx_spi_update_irq(s); @@ -310,8 +311,7 @@ static void imx_spi_write(void *opaque, hwaddr offset, uint64_t value, return; } - DPRINTF("reg[%s] <= 0x%" PRIx32 "\n", imx_spi_reg_name(index), - (uint32_t)value); + trace_imx_spi_write(index, imx_spi_reg_name(index), value); change_mask = s->regs[index] ^ value; diff --git a/hw/ssi/trace-events b/hw/ssi/trace-events index 612d3d6087a..20fcaf32df6 100644 --- a/hw/ssi/trace-events +++ b/hw/ssi/trace-events @@ -1,3 +1,5 @@ +# See docs/devel/tracing.txt for syntax documentation. + # aspeed_smc.c aspeed_smc_flash_set_segment(int cs, uint64_t reg, uint64_t start, uint64_t end) "CS%d segreg=0x%"PRIx64" [ 0x%"PRIx64" - 0x%"PRIx64" ]" @@ -10,6 +12,11 @@ aspeed_smc_dma_rw(const char *dir, uint32_t flash_addr, uint32_t dram_addr, uint aspeed_smc_write(uint64_t addr, uint32_t size, uint64_t data) "@0x%" PRIx64 " size %u: 0x%" PRIx64 aspeed_smc_flash_select(int cs, const char *prefix) "CS%d %sselect" +# imx_spi.c +imx_spi_reset(void) "" +imx_spi_read(uint32_t index, const char *name, uint32_t value) "index:%u (%s) value:0x%08x" +imx_spi_write(uint32_t index, const char *name, uint32_t value) "index:%u (%s) value:0x%08x" + # npcm7xx_fiu.c npcm7xx_fiu_enter_reset(const char *id, int reset_type) "%s reset type: %d" -- 2.26.2