From: Keith Busch <kbusch@kernel.org>
To: Klaus Jensen <its@irrelevant.dk>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Dmitry Fomichev <dmitry.fomichev@wdc.com>,
Klaus Jensen <k.jensen@samsung.com>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH] hw/block/nvme: conditionally enable DULBE for zoned namespaces
Date: Thu, 14 Jan 2021 15:39:28 -0800 [thread overview]
Message-ID: <20210114233928.GF1511902@dhcp-10-100-145-180.wdc.com> (raw)
In-Reply-To: <20210111180952.112488-1-its@irrelevant.dk>
On Mon, Jan 11, 2021 at 07:09:52PM +0100, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
>
> The device uses the BDRV_BLOCK_ZERO flag to determine the "deallocated"
> status of logical blocks. Since the zoned namespaces command set
> specification defines that logical blocks SHALL be marked as deallocated
> when the zone is in the Empty or Offline states, DULBE can only be
> supported if the zone size is a multiple of the calculated deallocation
> granularity (reported in NPDG) which depends on the underlying block
> device cluster size (if applicable) or the configured
> discard_granularity.
>
> Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
Looks good.
Reviewed-by: Keith Busch <kbusch@kernel.org>
next prev parent reply other threads:[~2021-01-14 23:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 18:09 [PATCH] hw/block/nvme: conditionally enable DULBE for zoned namespaces Klaus Jensen
2021-01-14 23:39 ` Keith Busch [this message]
2021-01-15 7:10 ` Klaus Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210114233928.GF1511902@dhcp-10-100-145-180.wdc.com \
--to=kbusch@kernel.org \
--cc=dmitry.fomichev@wdc.com \
--cc=its@irrelevant.dk \
--cc=k.jensen@samsung.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).