From: Greg Kurz <groug@kaod.org>
To: Alexander Bulekov <alxndr@bu.edu>
Cc: Laurent Vivier <lvivier@redhat.com>,
Thomas Huth <thuth@redhat.com>,
Christian Schoenebeck <qemu_oss@crudebyte.com>,
qemu-devel@nongnu.org, Bandan Das <bsd@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] fuzz: Add virtio-9p configurations for fuzzing
Date: Fri, 15 Jan 2021 13:23:08 +0100 [thread overview]
Message-ID: <20210115132308.371a0675@bahia.lan> (raw)
In-Reply-To: <20210114221748.503565-1-alxndr@bu.edu>
On Thu, 14 Jan 2021 17:17:48 -0500
Alexander Bulekov <alxndr@bu.edu> wrote:
> Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
> ---
No changelog at all ?
> tests/qtest/fuzz/generic_fuzz_configs.h | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/tests/qtest/fuzz/generic_fuzz_configs.h b/tests/qtest/fuzz/generic_fuzz_configs.h
> index 7fed035345..ffdb590c58 100644
> --- a/tests/qtest/fuzz/generic_fuzz_configs.h
> +++ b/tests/qtest/fuzz/generic_fuzz_configs.h
> @@ -59,6 +59,18 @@ const generic_fuzz_config predefined_configs[] = {
> .name = "virtio-mouse",
> .args = "-machine q35 -nodefaults -device virtio-mouse",
> .objects = "virtio*",
> + },{
> + .name = "virtio-9p",
> + .args = "-machine q35 -nodefaults "
> + "-device virtio-9p,fsdev=hshare,mount_tag=hshare "
> + "-fsdev local,id=hshare,path=/tmp/,security_model=none",
Sharing a general purpose directory like "/tmp" is definitely not a
recommended practice. This is typically the kind of thing that I'd
like to see documented in the changelog to help me understand ;-)
What operations does the fuzz test perform on the device ?
> + .objects = "virtio*",
> + },{
> + .name = "virtio-9p-synth",
> + .args = "-machine q35 -nodefaults "
> + "-device virtio-9p,fsdev=hshare,mount_tag=hshare "
> + "-fsdev synth,id=hshare",
> + .objects = "virtio*",
Not sure this is super useful since the only known use case for
the synth fsdev driver is running the virtio-9p qtest, but
it looks fine anyway.
> },{
> .name = "e1000",
> .args = "-M q35 -nodefaults "
next prev parent reply other threads:[~2021-01-15 12:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 22:17 [PATCH] fuzz: Add virtio-9p configurations for fuzzing Alexander Bulekov
2021-01-15 10:33 ` Darren Kenny
2021-01-15 15:18 ` Alexander Bulekov
2021-01-15 12:23 ` Greg Kurz [this message]
2021-01-15 12:51 ` Christian Schoenebeck via
2021-01-15 15:38 ` Alexander Bulekov
2021-01-15 15:32 ` Alexander Bulekov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210115132308.371a0675@bahia.lan \
--to=groug@kaod.org \
--cc=alxndr@bu.edu \
--cc=bsd@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu_oss@crudebyte.com \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).