From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85510C433E0 for ; Fri, 22 Jan 2021 13:43:17 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F327022D57 for ; Fri, 22 Jan 2021 13:43:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F327022D57 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57304 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2wia-0003OG-2E for qemu-devel@archiver.kernel.org; Fri, 22 Jan 2021 08:43:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36202) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2whi-0002Tm-E0 for qemu-devel@nongnu.org; Fri, 22 Jan 2021 08:42:22 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:32849) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l2whg-00020H-Py for qemu-devel@nongnu.org; Fri, 22 Jan 2021 08:42:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611322939; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ej2GXwu2YE9bjINRerY1kMeBb/35xSs9zpqWN8gz8B8=; b=HFn+eGBWUo+RjKmAy0NgAcY6aZWdZbc18aI4A/4CxEoKKBI7j9By2xfjYTl259pC26203p Vs53vIndjAnylP3KjXhO6nxIdIDYrPAWX/pop1ZZ1eVByq5zH61sNuQmIFd1gcoLlXmGFm K4oHFHtVCrvzGDyOwJ2sdmVBRhbjwuQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-11-zLgBlhNsOdGWo0LU2aOW3w-1; Fri, 22 Jan 2021 08:42:17 -0500 X-MC-Unique: zLgBlhNsOdGWo0LU2aOW3w-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B686E801F9A for ; Fri, 22 Jan 2021 13:42:16 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-182.ams2.redhat.com [10.36.112.182]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 69A83E2C9; Fri, 22 Jan 2021 13:42:16 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 7023818000AB; Fri, 22 Jan 2021 14:42:13 +0100 (CET) Date: Fri, 22 Jan 2021 14:42:13 +0100 From: Gerd Hoffmann To: Laszlo Ersek Subject: Re: [PULL 10/11] vnc: move initialization to framebuffer_update_request Message-ID: <20210122134213.atygadb2ospaqhcg@sirius.home.kraxel.org> References: <20210115102424.1360437-1-kraxel@redhat.com> <20210115102424.1360437-11-kraxel@redhat.com> <26961441-e25b-25a1-b2e7-a6bb6a439022@redhat.com> <20210122084621.rdfxbamfzyc7aaft@sirius.home.kraxel.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.182, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Jan 22, 2021 at 01:49:38PM +0100, Laszlo Ersek wrote: > On 01/22/21 09:46, Gerd Hoffmann wrote: > >> This patch breaks QEMU for me. > > > >> The symptom is the following: in virt-manager, the display remains dead > >> (black), when I start an OVMF guest. At the same time, unusually high > >> CPU load can be seen on the host; it makes me think that virt-manager is > >> trying, in a busy loop, to complete the VNC handshake, or some such. > >> Ultimately, although the guest boots up fine, virt-manager gives up, and > >> the display window says "Viewer was disconnected". > > > > It is the vnc_colordepth() call. Seems gtk-vnc sends a update request > > with incremental=0 as response to the VNC_ENCODING_WMVi message. So > > sending that as response to an incremental=0 update request creates an > > endless loop ... > > Interesting; I saw that commit 9e1632ad07ca *added* (as opposed to > *moving*) the vnc_colordepth() call; I thought it was a relatively > insignificant bit... /me too. Some discussions in the resize changes indicated that the idea of a non-incremetal update request is that the server sends the *full* server-side state, so the client can render the screen properly without remembering old state. So I thought ok, lets send the colordepth info too, no big deal ... take care, Gerd