* [PATCH] tcg/tci: Implement INDEX_op_ld8s_i64
@ 2021-01-27 21:07 Stefan Weil
2021-01-27 22:55 ` Richard Henderson
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Weil @ 2021-01-27 21:07 UTC (permalink / raw)
To: Richard Henderson; +Cc: Stefan Weil, Alex Bennée, qemu-devel
That TCG opcode is used by debian-buster (arm64) running ffmpeg:
qemu-aarch64 /usr/bin/ffmpeg -i theora.mkv theora.webm
Reported-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
tcg/tci.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tcg/tci.c b/tcg/tci.c
index ddbb259e1d..3d5e50b4df 100644
--- a/tcg/tci.c
+++ b/tcg/tci.c
@@ -886,7 +886,10 @@ uintptr_t QEMU_DISABLE_CFI tcg_qemu_tb_exec(CPUArchState *env,
tci_write_reg8(regs, t0, *(uint8_t *)(t1 + t2));
break;
case INDEX_op_ld8s_i64:
- TODO();
+ t0 = *tb_ptr++;
+ t1 = tci_read_r(regs, &tb_ptr);
+ t2 = tci_read_s32(&tb_ptr);
+ tci_write_reg8(regs, t0, *(int8_t *)(t1 + t2));
break;
case INDEX_op_ld16u_i64:
t0 = *tb_ptr++;
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tcg/tci: Implement INDEX_op_ld8s_i64
2021-01-27 21:07 [PATCH] tcg/tci: Implement INDEX_op_ld8s_i64 Stefan Weil
@ 2021-01-27 22:55 ` Richard Henderson
0 siblings, 0 replies; 2+ messages in thread
From: Richard Henderson @ 2021-01-27 22:55 UTC (permalink / raw)
To: Stefan Weil; +Cc: Alex Bennée, qemu-devel
On 1/27/21 11:07 AM, Stefan Weil wrote:
> case INDEX_op_ld8s_i64:
> - TODO();
> + t0 = *tb_ptr++;
> + t1 = tci_read_r(regs, &tb_ptr);
> + t2 = tci_read_s32(&tb_ptr);
> + tci_write_reg8(regs, t0, *(int8_t *)(t1 + t2));
> break;
This doesn't work, because tci_write_reg8 truncates to uint8_t again. You need
to use tci_write_reg().
r~
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-27 22:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-27 21:07 [PATCH] tcg/tci: Implement INDEX_op_ld8s_i64 Stefan Weil
2021-01-27 22:55 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).