From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
David Hildenbrand <david@redhat.com>,
Pankaj Gupta <pankaj.gupta.linux@gmail.com>
Subject: [PULL 9/9] virtio-pmem: add trace events
Date: Tue, 2 Feb 2021 10:12:47 -0500 [thread overview]
Message-ID: <20210202151116.1573669-10-mst@redhat.com> (raw)
In-Reply-To: <20210202151116.1573669-1-mst@redhat.com>
From: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
This patch adds trace events for virtio-pmem functionality.
Adding trace events for virtio pmem request, reponse and host
side fsync functionality.
Signed-off-by: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
Message-Id: <20201117115705.32195-1-pankaj.gupta.linux@gmail.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/virtio/virtio-pmem.c | 4 ++++
hw/virtio/trace-events | 5 +++++
2 files changed, 9 insertions(+)
diff --git a/hw/virtio/virtio-pmem.c b/hw/virtio/virtio-pmem.c
index ddb0125901..d83e973bf2 100644
--- a/hw/virtio/virtio-pmem.c
+++ b/hw/virtio/virtio-pmem.c
@@ -24,6 +24,7 @@
#include "sysemu/hostmem.h"
#include "block/aio.h"
#include "block/thread-pool.h"
+#include "trace.h"
typedef struct VirtIODeviceRequest {
VirtQueueElement elem;
@@ -41,6 +42,7 @@ static int worker_cb(void *opaque)
/* flush raw backing image */
err = fsync(req_data->fd);
+ trace_virtio_pmem_flush_done(err);
if (err != 0) {
err = 1;
}
@@ -59,6 +61,7 @@ static void done_cb(void *opaque, int ret)
/* Callbacks are serialized, so no need to use atomic ops. */
virtqueue_push(req_data->pmem->rq_vq, &req_data->elem, len);
virtio_notify((VirtIODevice *)req_data->pmem, req_data->pmem->rq_vq);
+ trace_virtio_pmem_response();
g_free(req_data);
}
@@ -69,6 +72,7 @@ static void virtio_pmem_flush(VirtIODevice *vdev, VirtQueue *vq)
HostMemoryBackend *backend = MEMORY_BACKEND(pmem->memdev);
ThreadPool *pool = aio_get_thread_pool(qemu_get_aio_context());
+ trace_virtio_pmem_flush_request();
req_data = virtqueue_pop(vq, sizeof(VirtIODeviceRequest));
if (!req_data) {
virtio_error(vdev, "virtio-pmem missing request data");
diff --git a/hw/virtio/trace-events b/hw/virtio/trace-events
index 2060a144a2..c62727f879 100644
--- a/hw/virtio/trace-events
+++ b/hw/virtio/trace-events
@@ -122,3 +122,8 @@ virtio_mem_unplug_all_request(void) ""
virtio_mem_resized_usable_region(uint64_t old_size, uint64_t new_size) "old_size=0x%" PRIx64 "new_size=0x%" PRIx64
virtio_mem_state_request(uint64_t addr, uint16_t nb_blocks) "addr=0x%" PRIx64 " nb_blocks=%" PRIu16
virtio_mem_state_response(uint16_t state) "state=%" PRIu16
+
+# virtio-pmem.c
+virtio_pmem_flush_request(void) "flush request"
+virtio_pmem_response(void) "flush response"
+virtio_pmem_flush_done(int type) "fsync return=%d"
--
MST
next prev parent reply other threads:[~2021-02-02 15:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 15:12 [PULL 0/9] pc,virtio: fixes, features Michael S. Tsirkin
2021-02-02 15:12 ` [PULL 1/9] virtio: move 'use-disabled-flag' property to hw_compat_4_2 Michael S. Tsirkin
2021-02-02 15:12 ` [PULL 2/9] virtio-mmio: fix guest kernel crash with SHM regions Michael S. Tsirkin
2021-02-02 15:12 ` [PULL 3/9] virtio: Add corresponding memory_listener_unregister to unrealize Michael S. Tsirkin
2021-02-02 15:12 ` [PULL 4/9] tests/acpi: allow updates for expected data files Michael S. Tsirkin
2021-02-02 15:12 ` [PULL 5/9] acpi: Permit OEM ID and OEM table ID fields to be changed Michael S. Tsirkin
2021-02-02 15:12 ` [PULL 6/9] tests/acpi: add OEM ID and OEM TABLE ID test Michael S. Tsirkin
2021-02-02 15:12 ` [PULL 7/9] tests/acpi: update expected data files Michael S. Tsirkin
2021-02-02 15:12 ` Michael S. Tsirkin [this message]
2021-02-02 15:12 ` [PULL 8/9] tests/acpi: disallow updates for " Michael S. Tsirkin
2021-02-02 22:44 ` [PULL 0/9] pc,virtio: fixes, features Peter Maydell
2021-02-02 22:57 ` Michael S. Tsirkin
2021-02-03 14:15 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210202151116.1573669-10-mst@redhat.com \
--to=mst@redhat.com \
--cc=david@redhat.com \
--cc=pankaj.gupta.linux@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).