From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: berrange@redhat.com, qemu-devel@nongnu.org, quintela@redhat.com
Subject: Re: [PATCH v2 3/4] migration: Fix cache_init()'s "Failed to allocate" error messages
Date: Tue, 2 Feb 2021 15:37:02 +0000 [thread overview]
Message-ID: <20210202153702.GF3030@work-vm> (raw)
In-Reply-To: <87wnvq4hsc.fsf@dusky.pond.sub.org>
* Markus Armbruster (armbru@redhat.com) wrote:
> Eric Blake <eblake@redhat.com> writes:
>
> > On 2/2/21 8:17 AM, Markus Armbruster wrote:
> >> cache_init() attempts to handle allocation failure.. The two error
> >
> > The double . looks odd.
>
> Typo. Perhaps the maintainer can take care of it.
Yeh I can try and remember to take it out on the merge.
> >> messages are garbage, as untested error messages commonly are:
> >>
> >> Parameter 'cache size' expects Failed to allocate cache
> >> Parameter 'cache size' expects Failed to allocate page cache
> >>
> >> Fix them to just
> >>
> >> Failed to allocate cache
> >> Failed to allocate page cache
> >>
> >> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> >> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> >> ---
> >> migration/page_cache.c | 6 ++----
> >> 1 file changed, 2 insertions(+), 4 deletions(-)
> >>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2021-02-02 15:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 14:17 [PATCH v2 0/4] migration: Fixes and cleanups aroung migrate-set-parameters Markus Armbruster
2021-02-02 14:17 ` [PATCH v2 1/4] migration: Fix migrate-set-parameters argument validation Markus Armbruster
2021-02-02 14:17 ` [PATCH v2 2/4] migration: Clean up signed vs. unsigned XBZRLE cache-size Markus Armbruster
2021-02-02 14:17 ` [PATCH v2 3/4] migration: Fix cache_init()'s "Failed to allocate" error messages Markus Armbruster
2021-02-02 14:23 ` Eric Blake
2021-02-02 15:21 ` Markus Armbruster
2021-02-02 15:37 ` Dr. David Alan Gilbert [this message]
2021-02-02 14:17 ` [PATCH v2 4/4] migration: Fix a few absurdly defective " Markus Armbruster
2021-02-04 15:08 ` [PATCH v2 0/4] migration: Fixes and cleanups aroung migrate-set-parameters Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210202153702.GF3030@work-vm \
--to=dgilbert@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).