From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 057A3C433DB for ; Tue, 2 Feb 2021 18:03:56 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C43F64F96 for ; Tue, 2 Feb 2021 18:03:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C43F64F96 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56330 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l701q-0005Hr-K4 for qemu-devel@archiver.kernel.org; Tue, 02 Feb 2021 13:03:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45370) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6ztq-0005Mj-6c for qemu-devel@nongnu.org; Tue, 02 Feb 2021 12:55:38 -0500 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]:34865) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l6ztc-0002Ev-DM for qemu-devel@nongnu.org; Tue, 02 Feb 2021 12:55:36 -0500 Received: by mail-wr1-x429.google.com with SMTP id l12so21439273wry.2 for ; Tue, 02 Feb 2021 09:55:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=PYXcmESVfoHGpmKd9uk67sd4tJIXB63SS0T0aA9+ufE=; b=af05IcL22bqjW1FlDCb5i6J2yVgnhiFzSCwFx97Ij9ottmSyTa7e0nyx/q14HW5MfU WJqyadfdlCvfGiudmv2FNYurC5AjnrXM380hgFgylOr41kfJdylC8RrJtzehbezCkfQX RIQu2/2OzmhdcLIIY2NBMn6V/+1eqN061E1JQQ/YcT0ToQ89bLvS8dBZQgelpbhyvCxX /PVpdrI0wAvby4EZzBXLaSPEtyus8gRtKcyjjIPidaT/viAplqqrrcosnV/Hd6uAzTTF 6PnjqaNldrWuR61dMSL/3muPSHX4W/wDOcmod5+nMW/XZJqwC2VEsuui8ne8VfP1lbon r5fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PYXcmESVfoHGpmKd9uk67sd4tJIXB63SS0T0aA9+ufE=; b=Q65/XOpOXIurMFimp5+xiFXaPi13LcCecu82NqTxmgJ14DPk1VmTF6LOJCzunEvvTo 0bxSiyllmhqFUhb48JbeJAd0w6VhKbPmwNb5nibrB3QcnEn66D496U/Zj1LOAB/Tk2wJ icOKrMG9cDMtwA4rsV9Og7pMbAZYXcrIuwuI+5BiLFI4xxRB66PHJF5uMu15tG+RgtuN FzkR9cITkpwVHoWuyWQ5RzEZH+jayoY4CgEYuVj4xiVMwm1Ny5aBXZcOCywc4AyCetAX waAlf5sCd9xpXZGMp9I878iiGcO9UTT9opQNoMS8Ph0nXEfnvKw875zJDgi6HkRCmpfx KLhg== X-Gm-Message-State: AOAM532JQR4AS+QLoJnLKaYRVomyWPUR4c0/+aAY4caSvg08r9p5B7Dc zYYJYbJHCBa2k0ah3zaFlb4OU/a+6gjNTQ== X-Google-Smtp-Source: ABdhPJybarTjnxPh+95jtdr1PwrouEXY3UjgfNJTADooBQxdvLj0lfycM5aqlGHSv3sKzdn0Jj243Q== X-Received: by 2002:a05:6000:1245:: with SMTP id j5mr12916554wrx.333.1612288522840; Tue, 02 Feb 2021 09:55:22 -0800 (PST) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id q6sm4142283wmj.32.2021.02.02.09.55.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Feb 2021 09:55:22 -0800 (PST) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 03/21] hw/char/exynos4210_uart: Fix missing call to report ready for input Date: Tue, 2 Feb 2021 17:54:59 +0000 Message-Id: <20210202175517.28729-4-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210202175517.28729-1-peter.maydell@linaro.org> References: <20210202175517.28729-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Iris Johnson When the frontend device has no space for a read the fd is removed from polling to allow time for the guest to read and clear the buffer. Without the call to qemu_chr_fe_accept_input(), the poll will not be broken out of when the guest has cleared the buffer causing significant IO delays that get worse with smaller buffers. Buglink: https://bugs.launchpad.net/qemu/+bug/1913341 Signed-off-by: Iris Johnson Message-id: 20210130184016.1787097-1-iris@modwiz.com Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- hw/char/exynos4210_uart.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/char/exynos4210_uart.c b/hw/char/exynos4210_uart.c index 9b21d201b34..80d401a3795 100644 --- a/hw/char/exynos4210_uart.c +++ b/hw/char/exynos4210_uart.c @@ -519,6 +519,7 @@ static uint64_t exynos4210_uart_read(void *opaque, hwaddr offset, s->reg[I_(UTRSTAT)] &= ~UTRSTAT_Rx_BUFFER_DATA_READY; res = s->reg[I_(URXH)]; } + qemu_chr_fe_accept_input(&s->chr); exynos4210_uart_update_dmabusy(s); trace_exynos_uart_read(s->channel, offset, exynos4210_uart_regname(offset), res); -- 2.20.1