From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43E16C433DB for ; Wed, 3 Feb 2021 15:43:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8EA0F64E41 for ; Wed, 3 Feb 2021 15:43:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8EA0F64E41 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36498 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7KJf-0004xN-GD for qemu-devel@archiver.kernel.org; Wed, 03 Feb 2021 10:43:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42396) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7KI8-0004O7-9x for qemu-devel@nongnu.org; Wed, 03 Feb 2021 10:42:07 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:44416) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l7KI2-0002rm-4W for qemu-devel@nongnu.org; Wed, 03 Feb 2021 10:42:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612366915; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p6N6eGN6ZfX5urCFvQmjGdUI4EUgeAMh1oRVJi4gATg=; b=RDC4xxPIySfqAcfwAACk6BBy6j7yN+aGffa2Crjb6Z1m7slwZywZfaIl1Ok0WEssFfF4lr uIYtVi5kQ2+8DZw8PMTymy7tZy3YxHB/ZyUNa6JrUKd130wVo4NfDOupIecGTkwpE+xXpa yANuTQHi1nxkiNGm1tEdYBeCOs2ChO8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-162-x1k7kJhkO_eDnhQFLehdKg-1; Wed, 03 Feb 2021 10:41:52 -0500 X-MC-Unique: x1k7kJhkO_eDnhQFLehdKg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 27AAB102C813; Wed, 3 Feb 2021 15:41:51 +0000 (UTC) Received: from merkur.fritz.box (ovpn-115-32.ams2.redhat.com [10.36.115.32]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6C63F5C238; Wed, 3 Feb 2021 15:41:34 +0000 (UTC) Date: Wed, 3 Feb 2021 16:41:33 +0100 From: Kevin Wolf To: Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= Subject: Re: [PATCH 10/12] tests/qemu-iotests: Replace the words 'blacklist/whitelist' Message-ID: <20210203154133.GD5507@merkur.fritz.box> References: <20210202205824.1085853-1-philmd@redhat.com> <20210202205824.1085853-11-philmd@redhat.com> <20210203102757.GL300990@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210203102757.GL300990@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kwolf@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -32 X-Spam_score: -3.3 X-Spam_bar: --- X-Spam_report: (-3.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.539, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Otubo , Peter Maydell , qemu-block@nongnu.org, Michael Roth , qemu-devel@nongnu.org, "Dr. David Alan Gilbert" , Alex =?iso-8859-1?Q?Benn=E9e?= , Alex Williamson , Gerd Hoffmann , Stefan Hajnoczi , Max Reitz , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 03.02.2021 um 11:28 hat Daniel P. Berrangé geschrieben: > On Tue, Feb 02, 2021 at 09:58:22PM +0100, Philippe Mathieu-Daudé wrote: > > Follow the inclusive terminology from the "Conscious Language in your > > Open Source Projects" guidelines [*] and replace the words "blacklist" > > and "whitelist" appropriately. We're not doing access control here, so allowlist/denylist are not the appropriate words to use here. > > [*] https://github.com/conscious-lang/conscious-lang-docs/blob/main/faq.md > > > > Signed-off-by: Philippe Mathieu-Daudé > > --- > > tests/qemu-iotests/149 | 14 +++++++------- > > tests/qemu-iotests/149.out | 8 ++++---- > > 2 files changed, 11 insertions(+), 11 deletions(-) > > > > diff --git a/tests/qemu-iotests/149 b/tests/qemu-iotests/149 > > index 328fd05a4c9..b1d3f5fad67 100755 > > --- a/tests/qemu-iotests/149 > > +++ b/tests/qemu-iotests/149 > > @@ -500,7 +500,7 @@ configs = [ > > > > ] > > > > -blacklist = [ > > +denylist = [ > > # We don't have a cast-6 cipher impl for QEMU yet > > "cast6-256-xts-plain64-sha1", > > "cast6-128-xts-plain64-sha1", > > @@ -510,17 +510,17 @@ blacklist = [ > > "twofish-192-xts-plain64-sha1", > > ] > > "skiplist" better describes the purpose of this. That it's a list is very obvious from the code and doesn't tell anything about the content. How about skip_configs? > > > > -whitelist = [] > > +allowlist = [] > > if "LUKS_CONFIG" in os.environ: > > - whitelist = os.environ["LUKS_CONFIG"].split(",") > > + allowlist = os.environ["LUKS_CONFIG"].split(",") > > And "filterlist" test_configs? configs_to_test? > > > > for config in configs: > > - if config.name in blacklist: > > - iotests.log("Skipping %s in blacklist" % config.name) > > + if config.name in denylist: > > + iotests.log("Skipping %s in denylist" % config.name) > > continue > > > > - if len(whitelist) > 0 and config.name not in whitelist: > > - iotests.log("Skipping %s not in whitelist" % config.name) > > + if len(allowlist) > 0 and config.name not in allowlist: > > + iotests.log("Skipping %s not in allowlist" % config.name) > > continue The messages need to be updates accordingly, of course. Kevin