qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, Cleber Rosa <crosa@redhat.com>
Subject: Re: [PATCH 11/20] ui: add an optional get_flags callback to GraphicHwOps
Date: Thu, 4 Feb 2021 09:32:00 +0100	[thread overview]
Message-ID: <20210204083200.xduubtproypxcgtv@sirius.home.kraxel.org> (raw)
In-Reply-To: <CAMxuvaxDMR2a+mKFPjA29rQrTzbNPt7hpBWVqBvV3iAABTLeoA@mail.gmail.com>

On Thu, Feb 04, 2021 at 02:21:02AM +0400, Marc-André Lureau wrote:
> On Wed, Feb 3, 2021 at 7:48 PM Gerd Hoffmann <kraxel@redhat.com> wrote:
> 
> > > +static int
> > > +virtio_gpu_get_flags(void *opaque)
> > > +{
> > > +    VirtIOGPUBase *g = opaque;
> > > +    int flags = GRAPHIC_FLAGS_NONE;
> > > +
> > > +    if (virtio_gpu_virgl_enabled(g->conf))
> > > +        flags |= GRAPHIC_FLAGS_GL;
> > > +
> > > +    if (virtio_gpu_dmabuf_enabled(g->conf))
> > > +        flags |= GRAPHIC_FLAGS_DMABUF;
> >
> > fbe6ba76ac01 ui: add an optional get_flags callback to GraphicHwOps
> > ERROR: braces {} are necessary for all arms of this statement
> > #50: FILE: hw/display/virtio-gpu-base.c:123:
> > +    if (virtio_gpu_virgl_enabled(g->conf))
> > [...]
> >
> > ERROR: braces {} are necessary for all arms of this statement
> > #53: FILE: hw/display/virtio-gpu-base.c:126:
> > +    if (virtio_gpu_dmabuf_enabled(g->conf))
> > [...]
> >
> > total: 2 errors, 0 warnings, 68 lines checked
> >
> 
> If you queued the series, do you mind squashing a style fix? Otherwise I
> can resend.

Whatever is easier for you (note there are more codestyle warnings in
following patches, see patchew report).

take care,
  Gerd



  reply	other threads:[~2021-02-04  8:34 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-02 14:26 [PATCH 00/20] Various vhost-user-gpu & UI fixes marcandre.lureau
2021-02-02 14:26 ` [PATCH 01/20] vhost-user-gpu: check backend for EDID support marcandre.lureau
2021-02-02 14:26 ` [PATCH 02/20] vhost-user-gpu: handle vhost-user-gpu features in a callback marcandre.lureau
2021-02-02 14:26 ` [PATCH 03/20] vhost-user-gpu: use an extandable state enum for commands marcandre.lureau
2021-02-02 14:26 ` [PATCH 04/20] vhost-user-gpu: handle display-info in a callback marcandre.lureau
2021-02-02 14:26 ` [PATCH 05/20] ui: remove extra #ifdef CONFIG_OPENGL marcandre.lureau
2021-02-02 14:26 ` [PATCH 06/20] ui: remove gl_ctx_get_current marcandre.lureau
2021-02-02 14:26 ` [PATCH 07/20] ui: add gd_gl_area_scanout_disable marcandre.lureau
2021-02-02 14:26 ` [PATCH 08/20] ui: annotate DCLOps callback requirements marcandre.lureau
2021-02-02 14:26 ` [PATCH 09/20] ui: remove console_has_gl_dmabuf() marcandre.lureau
2021-02-02 14:26 ` [PATCH 10/20] vhost-user-gpu: add a configuration flag for dmabuf usage marcandre.lureau
2021-02-02 14:26 ` [PATCH 11/20] ui: add an optional get_flags callback to GraphicHwOps marcandre.lureau
2021-02-03 15:48   ` Gerd Hoffmann
2021-02-03 22:21     ` Marc-André Lureau
2021-02-04  8:32       ` Gerd Hoffmann [this message]
2021-02-02 14:26 ` [PATCH 12/20] ui: add a DCLOps callback to check dmabuf support marcandre.lureau
2021-02-02 14:26 ` [PATCH 13/20] ui: check hw requirements during DCL registration marcandre.lureau
2021-02-02 14:26 ` [PATCH 14/20] ui: add qemu_egl_has_dmabuf helper marcandre.lureau
2021-02-02 14:26 ` [PATCH 15/20] ui: check gtk-egl dmabuf support marcandre.lureau
2021-02-02 14:26 ` [PATCH 16/20] ui: add egl dmabuf import to gtkglarea marcandre.lureau
2021-02-02 14:26 ` [PATCH 17/20] virtio-gpu: avoid re-entering cmdq processing marcandre.lureau
2021-02-02 14:26 ` [PATCH 18/20] display/ui: add a callback to indicate GL state is flushed marcandre.lureau
2021-02-02 14:26 ` [PATCH 19/20] chardev: check if the chardev is registered for yanking marcandre.lureau
2021-02-02 14:26 ` [PATCH 20/20] RFC: tests: add some virtio-gpu & vhost-user-gpu acceptance test marcandre.lureau
2021-02-03 11:38   ` Gerd Hoffmann
2021-02-03 13:33     ` Marc-André Lureau
2021-02-03 14:16       ` Gerd Hoffmann
2021-02-03 14:20         ` Marc-André Lureau
2021-02-02 14:57 ` [PATCH 00/20] Various vhost-user-gpu & UI fixes no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210204083200.xduubtproypxcgtv@sirius.home.kraxel.org \
    --to=kraxel@redhat.com \
    --cc=crosa@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).