From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Zack Marvel <zpmarvel@gmail.com>
Subject: Re: [PATCH] ui/gtk: vte: fix sending multiple characeters
Date: Mon, 22 Feb 2021 12:39:17 +0100 [thread overview]
Message-ID: <20210222113917.mlsal6rmjv4bb4zj@sirius.home.kraxel.org> (raw)
In-Reply-To: <20210221170613.13183-2-zpmarvel@gmail.com>
On Sun, Feb 21, 2021 at 10:06:13AM -0700, Zack Marvel wrote:
> When using the GTK UI with libvte, multicharacter keystrokes are not
> sent correctly (such as arrow keys). gd_vc_in should check the
> CharBackend's can_receive instead of assuming multiple characters can be
> received. This is not an issue for e.g. the SDL UI because
> qemu_chr_be_write is called with len=1 for each character (SDL sends
> more than once keystroke).
>
> Modify gd_vc_in to call qemu_chr_be_write multiple times if necessary.
>
> Buglink: https://bugs.launchpad.net/qemu/+bug/1407808
>
> Signed-off-by: Zack Marvel <zpmarvel@gmail.com>
Added to ui patch queue.
thanks,
Gerd
prev parent reply other threads:[~2021-02-22 11:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-21 16:52 [PATCH] ui/gtk: vte: fix sending multiple characeters Zack Marvel
2021-02-21 16:57 ` no-reply
2021-02-21 17:06 ` Zack Marvel
2021-02-21 17:06 ` Zack Marvel
2021-02-22 11:39 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210222113917.mlsal6rmjv4bb4zj@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=zpmarvel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).