From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3C93C433E0 for ; Mon, 22 Feb 2021 18:02:24 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 67FAB601FF for ; Mon, 22 Feb 2021 18:02:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 67FAB601FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37056 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lEFXL-0006a2-Gl for qemu-devel@archiver.kernel.org; Mon, 22 Feb 2021 13:02:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57794) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEFV9-0004fl-R6 for qemu-devel@nongnu.org; Mon, 22 Feb 2021 13:00:07 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:34746) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lEFV7-0003fL-5z for qemu-devel@nongnu.org; Mon, 22 Feb 2021 13:00:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614016804; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g0daaZIiL7zB1dNQnlGOdmrK5Ct4nJWAQKVeDV4S+9U=; b=SxAvLQEgIQg4AF43XkIExc4cZPw1W0kFjn25idJ41GmCzCFGeNIKelKJtCCKHnHXT8l8fM raDcsdZXnT3ihpQ+y0m5xdVmdGqpQdxpf9vv8yJHoKnd52CjRlog/vOomjy6wOoOdpqTEZ C7C2mLthoiCOD1Ddm9yxOwe2VJTujzY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-113-x6AyWPnMMK6ocNz1yohAhA-1; Mon, 22 Feb 2021 13:00:02 -0500 X-MC-Unique: x6AyWPnMMK6ocNz1yohAhA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CAB31192CC57; Mon, 22 Feb 2021 17:59:56 +0000 (UTC) Received: from gondolin (ovpn-113-115.ams2.redhat.com [10.36.113.115]) by smtp.corp.redhat.com (Postfix) with ESMTP id 90F5F60DA0; Mon, 22 Feb 2021 17:59:33 +0000 (UTC) Date: Mon, 22 Feb 2021 18:59:30 +0100 From: Cornelia Huck To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Subject: Re: [PATCH v2 02/11] hw/boards: Introduce machine_class_valid_for_accelerator() Message-ID: <20210222185930.4c08cb69.cohuck@redhat.com> In-Reply-To: <6ceff55c-6da4-e773-7809-de3be2f566ab@redhat.com> References: <20210219173847.2054123-1-philmd@redhat.com> <20210219173847.2054123-3-philmd@redhat.com> <20210222183400.0c151d46.cohuck@redhat.com> <6ceff55c-6da4-e773-7809-de3be2f566ab@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Received-SPF: pass client-ip=216.205.24.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , kvm@vger.kernel.org, Paul Durrant , David Hildenbrand , qemu-devel@nongnu.org, "Edgar E. Iglesias" , Stefano Stabellini , "Michael S. Tsirkin" , Huacai Chen , Halil Pasic , Christian Borntraeger , =?UTF-8?B?SGVydsOp?= Poussineau , Anthony Perard , xen-devel@lists.xenproject.org, Leif Lindholm , Thomas Huth , Eduardo Habkost , Mark Cave-Ayland , Alistair Francis , Richard Henderson , Greg Kurz , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, David Gibson , Radoslaw Biernacki , Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= , qemu-ppc@nongnu.org, Paolo Bonzini , Aleksandar Rikalo , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 22 Feb 2021 18:46:15 +0100 Philippe Mathieu-Daud=C3=A9 wrote: > On 2/22/21 6:34 PM, Cornelia Huck wrote: > > On Fri, 19 Feb 2021 18:38:38 +0100 > > Philippe Mathieu-Daud=C3=A9 wrote: > > =20 > >> Introduce the valid_accelerators[] field to express the list > >> of valid accelators a machine can use, and add the > >> machine_class_valid_for_current_accelerator() and > >> machine_class_valid_for_accelerator() methods. > >> > >> Signed-off-by: Philippe Mathieu-Daud=C3=A9 > >> --- > >> include/hw/boards.h | 24 ++++++++++++++++++++++++ > >> hw/core/machine.c | 26 ++++++++++++++++++++++++++ > >> 2 files changed, 50 insertions(+) > >> > >> diff --git a/include/hw/boards.h b/include/hw/boards.h > >> index 68d3d10f6b0..4d08bc12093 100644 > >> --- a/include/hw/boards.h > >> +++ b/include/hw/boards.h > >> @@ -36,6 +36,24 @@ void machine_set_cpu_numa_node(MachineState *machin= e, > >> const CpuInstanceProperties *props, > >> Error **errp); > >> =20 > >> +/** > >> + * machine_class_valid_for_accelerator: > >> + * @mc: the machine class > >> + * @acc_name: accelerator name > >> + * > >> + * Returns %true if the accelerator is valid for the machine, %false > >> + * otherwise. See #MachineClass.valid_accelerators. =20 > >=20 > > Naming confusion: is the machine class valid for the accelerator, or > > the accelerator valid for the machine class? Or either? :) =20 >=20 > "the accelerator valid for the machine class". >=20 > Is this clearer? >=20 > "Returns %true if the current accelerator is valid for the > selected machine, %false otherwise. >=20 > Or... >=20 > "Returns %true if the selected accelerator is valid for the > current machine, %false otherwise. Maybe that one, given how it ends up being called? Or "specified machine"? >=20 > How would look "either"? >=20 > The machine is already selected, and the accelerator too... Yes, so this is basically testing the (machine,accelerator) tuple, which is what I meant with 'either'. >=20 > > =20 > >> + */ > >> +bool machine_class_valid_for_accelerator(MachineClass *mc, const char= *acc_name); > >> +/** > >> + * machine_class_valid_for_current_accelerator: > >> + * @mc: the machine class > >> + * > >> + * Returns %true if the accelerator is valid for the current machine, > >> + * %false otherwise. See #MachineClass.valid_accelerators. =20 > >=20 > > Same here: current accelerator vs. current machine. So maybe "Returns %true if the current accelerator is valid for the specified machine class..." ? > > =20 > >> + */ > >> +bool machine_class_valid_for_current_accelerator(MachineClass *mc);