From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>
Cc: Michael Roth <michael.roth@amd.com>, John Snow <jsnow@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Cleber Rosa <crosa@redhat.com>
Subject: [PATCH v3 00/16] qapi: static typing conversion, pt3
Date: Mon, 22 Feb 2021 19:33:52 -0500 [thread overview]
Message-ID: <20210223003408.964543-1-jsnow@redhat.com> (raw)
Hi, this series adds static types to the QAPI module.
This is part three, and it focuses on expr.py.
This series is applied and hosted here:
https://gitlab.com/jsnow/qemu/-/tree/python-qapi-cleanup-pt3
Environment:
- Python >= 3.6, <= 3.8 *
- mypy >= 0.770
- pylint >= 2.6.0
- flake8
- isort
Every commit should pass with (from ./scripts/):
- flake8 qapi/
- pylint --rcfile=qapi/pylintrc qapi/
- mypy --config-file=qapi/mypy.ini qapi/
- pushd qapi && isort -c . && popd
Please read the changelog below for some review notes that may be of interest.
V3:
001/16:[----] [--] 'qapi/expr.py: Remove 'info' argument from nested check_if_str'
002/16:[----] [--] 'qapi/expr.py: Check for dict instead of OrderedDict'
003/16:[0004] [FC] 'qapi/expr.py: constrain incoming expression types'
004/16:[----] [--] 'qapi/expr.py: Add assertion for union type 'check_dict''
005/16:[----] [--] 'qapi/expr.py: move string check upwards in check_type'
006/16:[----] [--] 'qapi/expr.py: Check type of 'data' member'
007/16:[0002] [FC] 'qapi/expr.py: Add casts in a few select cases'
008/16:[----] [--] 'qapi/expr.py: add type hint annotations'
009/16:[down] 'qapi/expr.py: Consolidate check_if_str calls in check_if'
010/16:[----] [--] 'qapi/expr.py: Remove single-letter variable'
011/16:[----] [--] 'qapi/expr.py: enable pylint checks'
012/16:[----] [-C] 'qapi/expr.py: Add docstrings'
013/16:[down] 'qapi/expr.py: Modify check_keys to accept any Collection'
014/16:[----] [--] 'qapi/expr.py: Use tuples instead of lists for static data'
015/16:[0004] [FC] 'qapi/expr.py: move related checks inside check_xxx functions'
016/16:[0011] [FC] 'qapi/expr.py: Use an expression checker dispatch table'
- Some RB-s added, some dropped; see "Review Status" section below.
- ("pt0" series rebased on latest origin/master.)
- Rebased on origin/master.
- 03: Re-ordered the Expression unpacking slightly to match the other stanzas.
(R-Bs kept.)
- 07: Changed capitalization of a comment. (R-Bs kept.)
- 09: Rewritten more aggressively. (R-Bs dropped.)
- 13: Use "Collection" instead of "Iterable" because of concerns with the
possibly consumptive nature of Iterable; change commit name & message.
(R-Bs dropped.)
- 15: Use tuples everywhere, even for single items. (R-Bs kept.)
- 16: Update ExpressionType to define a __str__ method, which allows
the meta variable to be passed and used directly as a string.
(R-Bs dropped.)
RFCs/notes:
- This series was written long before pt1.5 and pt2. Keep that in mind! (Sorry.)
- I used MutableMapping instead of Dict in patch 8. There's no real
reason I couldn't have used Dict, both work - this one is more
abstract. Both would work for dict/OrderedDict perfectly well.
(I think I had some reason at one point or another, but I can no
longer remember what it is, if I am being honest. It might have to do
with Dict being invariant, but MutableMapping being covariant, which
might come into play much later in the six-part series. I really
forget.)
- The dreaded _DObject comes back, this time named _JSObject. It's a bad name.
It means "Any JSON object deserialized as a Python dict". I didn't rename it
because I didn't want to shed the R-Bs yet. Please suggest a name.
(Or a way to avoid needing it at all.)
You'll probably notice that I keep futzing with the documentation near
this definition. I opted not to fix it to avoid touching patches that
were (so far) fully reviewed.
- Patch 12 (the docstring patch) needs to be heavily copy-edited. I
figured I would simply address it all at once after review from
Markus. I ask that a review of this patch be exhaustive if at all
possible.
I start using [Const] and [RW] markers in the summary string; I think
I will actually remove these as they are not real markup, but I'd like
to solicit suggestions on how to differentiate functions that modify
expr from ones that do not.
I also start using some fairly arbitrary syntax to try and document
the syntactic forms being checked and normalized here, but they are
not very consistent. Suggestions welcome.
- Patch 16 is something I am not sure I really like anymore, it has some
mild benefit but I don't like how I repeat the expression types twice
in one file. I consider this patch optional for now. I suspect there's
a neater way to write it that gives us the same benefit but looks less
ugly.
Review Status:
[01] qapi-expr-py-remove-info # [RB] CR,EH [SOB] JS
[02] qapi-expr-py-check-for-dict # [RB] CR,EH [SOB] JS
[03] qapi-expr-py-constrain # [RB] CR,EH [SOB] JS
[04] qapi-expr-py-add-assertion-for # [RB] CR,EH [SOB] JS
[05] qapi-expr-py-move-string-check # [RB] CR,EH [SOB] JS
[06] qapi-expr-py-check-type-of # [RB] EH [SOB] JS
[07] qapi-expr-py-add-casts-in-a # [RB] CR,EH [SOB] JS
[08] qapi-expr-py-add-type-hint # [RB] CR,EH [SOB] JS
[09] qapi-expr-py-consolidate # [SOB] JS
[10] qapi-expr-py-remove-single # [RB] CR,EH [SOB] JS
[11] qapi-expr-py-enable-pylint # [RB] CR,EH [SOB] JS
[12] qapi-expr-py-add-docstrings # [RB] CR [SOB] JS
[13] qapi-expr-py-modify-check_keys # [SOB] JS
[14] qapi-expr-py-use-tuples # [RB] CR,EH [SOB] JS
[15] qapi-expr-py-move-related # [RB] CR [SOB] JS
[16] qapi-expr-py-use-an-expression # [SOB] JS
John Snow (16):
qapi/expr.py: Remove 'info' argument from nested check_if_str
qapi/expr.py: Check for dict instead of OrderedDict
qapi/expr.py: constrain incoming expression types
qapi/expr.py: Add assertion for union type 'check_dict'
qapi/expr.py: move string check upwards in check_type
qapi/expr.py: Check type of 'data' member
qapi/expr.py: Add casts in a few select cases
qapi/expr.py: add type hint annotations
qapi/expr.py: Consolidate check_if_str calls in check_if
qapi/expr.py: Remove single-letter variable
qapi/expr.py: enable pylint checks
qapi/expr.py: Add docstrings
qapi/expr.py: Modify check_keys to accept any Collection
qapi/expr.py: Use tuples instead of lists for static data
qapi/expr.py: move related checks inside check_xxx functions
qapi/expr.py: Use an expression checker dispatch table
scripts/qapi/expr.py | 453 +++++++++++++++++++++++++++++++-----------
scripts/qapi/mypy.ini | 5 -
scripts/qapi/pylintrc | 1 -
3 files changed, 337 insertions(+), 122 deletions(-)
--
2.29.2
next reply other threads:[~2021-02-23 0:39 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 0:33 John Snow [this message]
2021-02-23 0:33 ` [PATCH v3 01/16] qapi/expr.py: Remove 'info' argument from nested check_if_str John Snow
2021-02-23 0:33 ` [PATCH v3 02/16] qapi/expr.py: Check for dict instead of OrderedDict John Snow
2021-02-24 9:30 ` Markus Armbruster
2021-02-24 21:23 ` John Snow
2021-02-25 10:40 ` Markus Armbruster
2021-02-25 20:04 ` John Snow
2021-03-01 16:48 ` Markus Armbruster
2021-02-23 0:33 ` [PATCH v3 03/16] qapi/expr.py: constrain incoming expression types John Snow
2021-02-24 10:01 ` Markus Armbruster
2021-02-24 21:46 ` John Snow
2021-02-25 11:56 ` Markus Armbruster
2021-02-25 20:43 ` John Snow
2021-03-02 5:23 ` Markus Armbruster
2021-02-23 0:33 ` [PATCH v3 04/16] qapi/expr.py: Add assertion for union type 'check_dict' John Snow
2021-02-24 10:35 ` Markus Armbruster
2021-02-24 21:54 ` John Snow
2021-03-24 21:09 ` John Snow
2021-03-25 5:46 ` Markus Armbruster
2021-03-25 19:42 ` John Snow
2021-02-23 0:33 ` [PATCH v3 05/16] qapi/expr.py: move string check upwards in check_type John Snow
2021-02-23 0:33 ` [PATCH v3 06/16] qapi/expr.py: Check type of 'data' member John Snow
2021-02-24 10:39 ` Markus Armbruster
2021-02-24 22:06 ` John Snow
2021-02-25 12:02 ` Markus Armbruster
2021-02-23 0:33 ` [PATCH v3 07/16] qapi/expr.py: Add casts in a few select cases John Snow
2021-02-24 12:32 ` Markus Armbruster
2021-02-24 22:24 ` John Snow
2021-02-25 12:07 ` Markus Armbruster
2021-02-25 22:10 ` John Snow
2021-02-23 0:34 ` [PATCH v3 08/16] qapi/expr.py: add type hint annotations John Snow
2021-02-24 15:27 ` Markus Armbruster
2021-02-24 22:30 ` John Snow
2021-02-25 12:08 ` Markus Armbruster
2021-02-25 13:56 ` Markus Armbruster
2021-02-25 20:54 ` John Snow
2021-03-02 5:29 ` Markus Armbruster
2021-02-23 0:34 ` [PATCH v3 09/16] qapi/expr.py: Consolidate check_if_str calls in check_if John Snow
2021-02-25 14:23 ` Markus Armbruster
2021-02-25 21:34 ` John Snow
2021-03-02 5:57 ` Markus Armbruster
2021-02-23 0:34 ` [PATCH v3 10/16] qapi/expr.py: Remove single-letter variable John Snow
2021-02-25 14:03 ` Markus Armbruster
2021-02-25 21:56 ` John Snow
2021-02-23 0:34 ` [PATCH v3 11/16] qapi/expr.py: enable pylint checks John Snow
2021-02-23 0:34 ` [PATCH v3 12/16] qapi/expr.py: Add docstrings John Snow
2021-02-23 0:34 ` [PATCH v3 13/16] qapi/expr.py: Modify check_keys to accept any Collection John Snow
2021-02-25 15:41 ` Markus Armbruster
2021-02-23 0:34 ` [PATCH v3 14/16] qapi/expr.py: Use tuples instead of lists for static data John Snow
2021-02-23 0:34 ` [PATCH v3 15/16] qapi/expr.py: move related checks inside check_xxx functions John Snow
2021-02-25 15:28 ` Markus Armbruster
2021-03-25 5:17 ` John Snow
2021-03-25 13:28 ` Markus Armbruster
2021-02-23 0:34 ` [PATCH v3 16/16] qapi/expr.py: Use an expression checker dispatch table John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210223003408.964543-1-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=armbru@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=michael.roth@amd.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).