From: Gerd Hoffmann <kraxel@redhat.com>
To: Akihiko Odaki <akihiko.odaki@gmail.com>
Cc: qemu Developers <qemu-devel@nongnu.org>,
"Michael S . Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v3 3/3] virtio-gpu: Do not distinguish the primary console
Date: Thu, 25 Feb 2021 10:10:49 +0100 [thread overview]
Message-ID: <20210225091049.npg2w7yacxel2cyz@sirius.home.kraxel.org> (raw)
In-Reply-To: <20210225013609.73388-3-akihiko.odaki@gmail.com>
> - if (m->scanout_id == 0 && m->width == 0) {
> + if (m->width == 0) {
> s->ds = qemu_create_placeholder_surface(640, 480,
> "Guest disabled display.");
> dpy_gfx_replace_surface(con, s->ds);
Just call dpy_gfx_replace_surface(con, NULL) here and let console.c
create the placeholder?
> for (i = 0; i < g->conf.max_outputs; i++) {
> g->scanout[i].con =
> graphic_console_init(DEVICE(g), i, &virtio_gpu_ops, g);
> - if (i > 0) {
> - dpy_gfx_replace_surface(g->scanout[i].con, NULL);
> - }
I think we should call dpy_gfx_replace_surface(..., NULL)
unconditionally here instead of removing the call.
> + /* primary head */
Comment can go away as we remove the special case for scanout == 0,
> + ds = qemu_create_placeholder_surface(scanout->width ?: 640,
> + scanout->height ?: 480,
> + "Guest disabled display.");
> dpy_gfx_replace_surface(scanout->con, ds);
likewise "dpy_gfx_replace_surface(..., NULL);"
take care,
Gerd
next prev parent reply other threads:[~2021-02-25 9:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 10:17 [PATCH] ui/console: Assert graphic console surface is not NULL Akihiko Odaki
2021-02-19 14:48 ` Gerd Hoffmann
2021-02-20 11:38 ` [PATCH v2] ui/console: Pass placeholder surface to displays Akihiko Odaki
2021-02-22 10:51 ` Gerd Hoffmann
2021-02-23 4:43 ` Akihiko Odaki
2021-02-24 11:06 ` Gerd Hoffmann
2021-02-25 1:36 ` [PATCH v3 1/3] ui/console: Add placeholder flag to message surface Akihiko Odaki
2021-02-25 1:36 ` [PATCH v3 2/3] ui/console: Pass placeholder surface to displays Akihiko Odaki
2021-02-25 9:06 ` Gerd Hoffmann
2021-02-25 1:36 ` [PATCH v3 3/3] virtio-gpu: Do not distinguish the primary console Akihiko Odaki
2021-02-25 9:10 ` Gerd Hoffmann [this message]
2021-02-25 9:45 ` Akihiko Odaki
2021-02-25 11:19 ` Gerd Hoffmann
2021-02-25 9:01 ` [PATCH v3 1/3] ui/console: Add placeholder flag to message surface Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210225091049.npg2w7yacxel2cyz@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=akihiko.odaki@gmail.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).