From: Keith Busch <kbusch@kernel.org>
To: Minwoo Im <minwoo.im.dev@gmail.com>
Cc: Klaus Jensen <its@irrelevant.dk>, Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org,
Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH V2 6/7] hw/block/nvme: support namespace attachment command
Date: Sat, 27 Feb 2021 02:59:35 +0900 [thread overview]
Message-ID: <20210226175935.GB3949@redsun51.ssa.fujisawa.hgst.com> (raw)
In-Reply-To: <20210210160937.1100-7-minwoo.im.dev@gmail.com>
On Thu, Feb 11, 2021 at 01:09:36AM +0900, Minwoo Im wrote:
> @@ -183,6 +183,7 @@ static const uint32_t nvme_cse_acs[256] = {
> [NVME_ADM_CMD_SET_FEATURES] = NVME_CMD_EFF_CSUPP,
> [NVME_ADM_CMD_GET_FEATURES] = NVME_CMD_EFF_CSUPP,
> [NVME_ADM_CMD_ASYNC_EV_REQ] = NVME_CMD_EFF_CSUPP,
> + [NVME_ADM_CMD_NS_ATTACHMENT] = NVME_CMD_EFF_CSUPP,
Missing NVME_CMD_EFF_NIC for the attachment command.
> };
>
> static const uint32_t nvme_cse_iocs_none[256];
> @@ -3766,6 +3767,62 @@ static uint16_t nvme_aer(NvmeCtrl *n, NvmeRequest *req)
> return NVME_NO_COMPLETE;
> }
>
> +static void __nvme_select_ns_iocs(NvmeCtrl *n, NvmeNamespace *ns);
> +static uint16_t nvme_ns_attachment(NvmeCtrl *n, NvmeRequest *req)
> +{
> + NvmeNamespace *ns;
> + NvmeCtrl *ctrl;
> + uint16_t list[NVME_CONTROLLER_LIST_SIZE] = {};
> + uint32_t nsid = le32_to_cpu(req->cmd.nsid);
> + uint32_t dw10 = le32_to_cpu(req->cmd.cdw10);
> + bool attach = !(dw10 & 0xf);
> + uint16_t *nr_ids = &list[0];
> + uint16_t *ids = &list[1];
> + uint16_t ret;
> + int i;
> +
> + trace_pci_nvme_ns_attachment(nvme_cid(req), dw10 & 0xf);
> +
> + ns = nvme_subsys_ns(n->subsys, nsid);
> + if (!ns) {
> + return NVME_INVALID_FIELD | NVME_DNR;
> + }
> +
> + ret = nvme_dma(n, (uint8_t *)list, 4096,
> + DMA_DIRECTION_TO_DEVICE, req);
> + if (ret) {
> + return ret;
> + }
> +
> + if (!*nr_ids) {
> + return NVME_NS_CTRL_LIST_INVALID | NVME_DNR;
> + }
> +
> + for (i = 0; i < *nr_ids; i++) {
> + ctrl = nvme_subsys_ctrl(n->subsys, ids[i]);
> + if (!ctrl) {
> + return NVME_NS_CTRL_LIST_INVALID | NVME_DNR;
> + }
> +
> + if (attach) {
> + if (nvme_ns_is_attached(ctrl, ns)) {
> + return NVME_NS_ALREADY_ATTACHED | NVME_DNR;
> + }
> +
> + nvme_ns_attach(ctrl, ns);
> + __nvme_select_ns_iocs(ctrl, ns);
> + } else {
> + if (!nvme_ns_is_attached(ctrl, ns)) {
> + return NVME_NS_NOT_ATTACHED | NVME_DNR;
> + }
> +
> + nvme_ns_detach(ctrl, ns);
> + }
> + }
> +
> + return NVME_SUCCESS;
> +}
Every controller that has newly attached the namespace needs to emit the
Namespace Notify AER in order for the host to react correctly to the
command.
next prev parent reply other threads:[~2021-02-26 18:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 16:09 [PATCH V2 0/6] hw/block/nvme: support namespace attachment Minwoo Im
2021-02-10 16:09 ` [PATCH V2 1/7] hw/block/nvme: support namespace detach Minwoo Im
2021-02-10 16:09 ` [PATCH V2 2/7] hw/block/nvme: fix namespaces array to 1-based Minwoo Im
2021-02-10 16:09 ` [PATCH V2 3/7] hw/block/nvme: fix allocated namespace list to 256 Minwoo Im
2021-02-10 16:09 ` [PATCH V2 4/7] hw/block/nvme: support allocated namespace type Minwoo Im
2021-02-10 16:09 ` [PATCH V2 5/7] hw/block/nvme: refactor nvme_select_ns_iocs Minwoo Im
2021-02-10 16:09 ` [PATCH V2 6/7] hw/block/nvme: support namespace attachment command Minwoo Im
2021-02-22 20:43 ` Klaus Jensen
2021-02-26 17:59 ` Keith Busch [this message]
2021-02-27 1:01 ` Minwoo Im
2021-02-10 16:09 ` [PATCH V2 7/7] hw/block/nvme: support Identify NS Attached Controller List Minwoo Im
2021-02-22 20:53 ` [PATCH V2 0/6] hw/block/nvme: support namespace attachment Klaus Jensen
2021-02-26 13:14 ` Minwoo Im
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210226175935.GB3949@redsun51.ssa.fujisawa.hgst.com \
--to=kbusch@kernel.org \
--cc=its@irrelevant.dk \
--cc=kwolf@redhat.com \
--cc=minwoo.im.dev@gmail.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).