From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F7FCC433E0 for ; Mon, 1 Mar 2021 21:06:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 868F260232 for ; Mon, 1 Mar 2021 21:06:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 868F260232 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gnu.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48926 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lGpjx-0004nz-DI for qemu-devel@archiver.kernel.org; Mon, 01 Mar 2021 16:06:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38782) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lGpjL-0004LB-Ru for qemu-devel@nongnu.org; Mon, 01 Mar 2021 16:05:28 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:57628) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lGpjJ-0000vy-Vw for qemu-devel@nongnu.org; Mon, 01 Mar 2021 16:05:27 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 89B23258; Mon, 1 Mar 2021 22:05:23 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 95EurJLaNipq; Mon, 1 Mar 2021 22:05:22 +0100 (CET) Received: from begin (unknown [IPv6:2a01:cb19:956:1b00:de41:a9ff:fe47:ec49]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 11CE9CD; Mon, 1 Mar 2021 22:05:22 +0100 (CET) Received: from samy by begin with local (Exim 4.94) (envelope-from ) id 1lGpjE-003t5x-Ug; Mon, 01 Mar 2021 22:05:20 +0100 Date: Mon, 1 Mar 2021 22:05:20 +0100 From: Samuel Thibault To: Doug Evans Subject: Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse Message-ID: <20210301210520.rfcgq6kp6qr66pzr@begin> References: <20210228213957.xkc4cceh5o6rgd5n@begin> <20210301162747.dmsaqzni6mrmkx4a@begin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210301162747.dmsaqzni6mrmkx4a@begin> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spamd-Bar: -- Authentication-Results: hera.aquilenet.fr X-Rspamd-Server: hera X-Rspamd-Queue-Id: 89B23258 X-Spamd-Result: default: False [-2.50 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_FIVE(0.00)[5]; HAS_ORG_HEADER(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_ALL(0.00)[]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; MID_RHS_NOT_FQDN(0.50)[]; BAYES_HAM(-3.00)[100.00%] Received-SPF: softfail client-ip=185.233.100.1; envelope-from=samuel.thibault@gnu.org; helo=hera.aquilenet.fr X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= , Markus Armbruster , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Samuel Thibault, le lun. 01 mars 2021 17:27:47 +0100, a ecrit: > Doug Evans, le lun. 01 mars 2021 08:23:03 -0800, a ecrit: > > On Sun, Feb 28, 2021 at 1:40 PM Samuel Thibault <[1]samuel.thibault@gnu.org> > > wrote: > > > > [...] > > > Note that one issue I am leaving for later (i.e., I don't want to drag > > this > > > patch series out to include it), is whether and how to support > > ipv4-host-> > > > ipv6-guest forwarding and vice versa. Can libslirp support this? > > > > That would be feasible yes: since the data flow is completely rebuilt > > between the host and the guest, there is no remnant of the IP version. > > It was simpler to have e.g. udp_listen and udp6_listen separate to keep > > uint32_t / in6_addr parameters, but there is no strict reason for this: > > the haddr is only passed to the bind() call, and the laddr is only > > recorded in the so. Put another way, a refactoring patch could be to > > just hand udp_listen two sockaddrs, and it will just work fine. We'd > > then introduce a slirp_add_hostfwd that takes two sockaddr instead of > > host/port. > > > > > > > > I guess I'm not familiar enough with this code. > > Help me understand how passing two addresses to udp_listen is simpler. > > That feels confusing from an API viewpoint. > > ? udp_listen already takes two addresses + two ports. I just mean > replacing that with two sockaddr, which contains both, but also contains > the address family. I submitted this to > > https://gitlab.freedesktop.org/slirp/libslirp/-/merge_requests/74 And the public API to https://gitlab.freedesktop.org/slirp/libslirp/-/merge_requests/75 Ideally we'd then just drop the ipv6-only public API. Samuel