From: David Edmondson <david.edmondson@oracle.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
qemu-block@nongnu.org, "Stefan Weil" <sw@weilnetz.de>,
"Max Reitz" <mreitz@redhat.com>,
"David Edmondson" <david.edmondson@oracle.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PATCH v2 1/6] block/vdi: When writing new bmap entry fails, don't leak the buffer
Date: Tue, 9 Mar 2021 14:40:10 +0000 [thread overview]
Message-ID: <20210309144015.557477-2-david.edmondson@oracle.com> (raw)
In-Reply-To: <20210309144015.557477-1-david.edmondson@oracle.com>
If a new bitmap entry is allocated, requiring the entire block to be
written, avoiding leaking the buffer allocated for the block should
the write fail.
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: David Edmondson <david.edmondson@oracle.com>
---
block/vdi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/vdi.c b/block/vdi.c
index 5627e7d764..2a6dc26124 100644
--- a/block/vdi.c
+++ b/block/vdi.c
@@ -690,6 +690,7 @@ nonallocating_write:
logout("finished data write\n");
if (ret < 0) {
+ g_free(block);
return ret;
}
--
2.30.1
next prev parent reply other threads:[~2021-03-09 15:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 14:40 [PATCH v2 0/6] coroutine rwlock downgrade fix, minor VDI changes David Edmondson
2021-03-09 14:40 ` David Edmondson [this message]
2021-03-09 14:40 ` [PATCH v2 2/6] block/vdi: Don't assume that blocks are larger than VdiHeader David Edmondson
2021-03-09 14:40 ` [PATCH v2 3/6] coroutine/mutex: Store the coroutine in the CoWaitRecord only once David Edmondson
2021-03-09 14:40 ` [PATCH v2 4/6] test-coroutine: Add rwlock downgrade test David Edmondson
2021-03-09 14:40 ` [PATCH v2 5/6] coroutine/rwlock: Wake writers in preference to readers David Edmondson
2021-03-09 14:40 ` [PATCH v2 6/6] coroutine/rwlock: Avoid thundering herd when unlocking David Edmondson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210309144015.557477-2-david.edmondson@oracle.com \
--to=david.edmondson@oracle.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).