From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C378CC433DB for ; Wed, 10 Mar 2021 20:33:15 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB98E64FCA for ; Wed, 10 Mar 2021 20:33:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB98E64FCA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36414 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lK5W4-0005SN-FG for qemu-devel@archiver.kernel.org; Wed, 10 Mar 2021 15:33:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34524) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lK5SS-0001m8-5c for qemu-devel@nongnu.org; Wed, 10 Mar 2021 15:29:28 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:36472) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lK5SP-0006x0-Ox for qemu-devel@nongnu.org; Wed, 10 Mar 2021 15:29:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615408163; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WUkCmkeF/L+GW58P+xjwaYZf7QVPbJvMVVLjhgnuEXM=; b=ObZI793eRhD7dIRfzJtjha4XwKImTED7iF5nNFfGiQn4OPcyhGoEQBrLIxDUOf/TVqzKML 2aVixe2ISxFv+lPGK8PEvm2Fm1e/LxS0QJbjkeVPLS8VYNeDmVhsH4fbh3HJm2ZALnYRR6 r+x8Cwv0594xcMHyke62XlYp/91iSlw= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-202-c2J1_Mu9PpuvsuYFggQzKQ-1; Wed, 10 Mar 2021 15:29:22 -0500 X-MC-Unique: c2J1_Mu9PpuvsuYFggQzKQ-1 Received: by mail-qk1-f200.google.com with SMTP id x11so10517241qki.22 for ; Wed, 10 Mar 2021 12:29:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=WUkCmkeF/L+GW58P+xjwaYZf7QVPbJvMVVLjhgnuEXM=; b=o9z7leUYu+mZEi0fNoDmaNW+w7+FyBmMvAE/+GCn60M+ZthAg6hVfLrK+sRspQmiEf HDCpMRKVGHBfavOIxBsSJkNA5TkKqiQ+Mf0Agb+C4+G1sxQ1ic34ZuP10FrbDklB1V2i 1H+urKGGLsGNwVh0VNreaN4q2mra+wdA8p2win5cBWzFlN6fcHR/WUhM7UVo+O2kxEcj mRkzATJUk56euZtOFSS2c0LYUqlSaD2BL0mIUaeV8HV8EKkSLsOL4IJ9TNWj1/cVhjPn cx/4LRChL3+5cOE6BJRflbWnO7JWy8fgKgwkxxxVpAdNy6nKIrrI9K0zgPldRAxtNek3 PuIQ== X-Gm-Message-State: AOAM530G4DHLBxPRtX3kwVIEEtZT0RjhSGZykHJiQdSMUKNyXqpGmGo0 6F4T5mO65Iw/TTRceaOsoeVOeQ9iVTUJk/hAZtv8WOMth5O50oU/zSwmGlrfefG4tnS118GjMMv JpYrMdz3Ro4O3XCg= X-Received: by 2002:ad4:4745:: with SMTP id c5mr4863092qvx.39.1615408161221; Wed, 10 Mar 2021 12:29:21 -0800 (PST) X-Google-Smtp-Source: ABdhPJzYkrnScCcVIGfCoBPFwBztSXlcf3SG1hSZg5UY64B3O1/GjuwG7isqX6fejV6IL6y/Sh/QFw== X-Received: by 2002:ad4:4745:: with SMTP id c5mr4863077qvx.39.1615408160951; Wed, 10 Mar 2021 12:29:20 -0800 (PST) Received: from xz-x1 ([142.126.89.138]) by smtp.gmail.com with ESMTPSA id o76sm312289qke.79.2021.03.10.12.29.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Mar 2021 12:29:20 -0800 (PST) Date: Wed, 10 Mar 2021 15:29:19 -0500 From: Peter Xu To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH 1/2] hw/mips/jazz: Use generic I/O bus via get_system_io() Message-ID: <20210310202919.GH6530@xz-x1> References: <20210310191255.1229848-1-f4bug@amsat.org> <20210310194924.GF6530@xz-x1> <5e53b99f-548c-8da9-f6fd-9c764642350b@amsat.org> MIME-Version: 1.0 In-Reply-To: <5e53b99f-548c-8da9-f6fd-9c764642350b@amsat.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.243, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Aleksandar Rikalo , Mark Cave-Ayland , qemu-devel@nongnu.org, Laurent Vivier , Alexander Bulekov , =?utf-8?B?SGVydsOp?= Poussineau , "Edgar E . Iglesias" , Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Mar 10, 2021 at 09:11:40PM +0100, Philippe Mathieu-Daudé wrote: > >> /* ISA bus: IO space at 0x90000000, mem space at 0x91000000 */ > >> - memory_region_init(isa_io, NULL, "isa-io", 0x00010000); > >> memory_region_init(isa_mem, NULL, "isa-mem", 0x01000000); > >> - memory_region_add_subregion(address_space, 0x90000000, isa_io); > >> + memory_region_add_subregion(address_space, 0x90000000, get_system_io()); > > > > The old code has an alias created just for adding subregion into address_space: > > > > - /* ISA IO space at 0x90000000 */ > > - memory_region_init_alias(isa, NULL, "isa_mmio", > > - get_system_io(), 0, 0x01000000); > > - memory_region_add_subregion(address_space, 0x90000000, isa); > > - isa_mem_base = 0x11000000; > > > > While you didn't revert that part. Maybe that's the issue? > > Hmm I'll have a look. This is not the series I'm working on, which > is much bigger and not ready for posting yet. I simply looked for > something similar (a bus mapped into sysbus) and remembered the > ISA bus from Jazz machines. I'll see if I can find a better PoC. Yeah no worry - it's just that I feel one memory_region_init_alias() call is probably missing in your huge series somewhere, so that you'll take that alias MR as subregion rather than the real MR (which is the root of one AS). -- Peter Xu