qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
To: qemu-devel@nongnu.org, laurent@vivier.eu
Subject: [PATCH v2 1/7] mac_via: switch rtc pram trace-events to use hex rather than decimal for addresses
Date: Thu, 11 Mar 2021 10:04:59 +0000	[thread overview]
Message-ID: <20210311100505.22596-2-mark.cave-ayland@ilande.co.uk> (raw)
In-Reply-To: <20210311100505.22596-1-mark.cave-ayland@ilande.co.uk>

Since all the documentation uses the hex offsets, this makes it much easier
to see what is going on.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
---
 hw/misc/trace-events | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/misc/trace-events b/hw/misc/trace-events
index 4b15db8ca4..81a45f7fa3 100644
--- a/hw/misc/trace-events
+++ b/hw/misc/trace-events
@@ -225,8 +225,8 @@ via1_rtc_cmd_test_write(int value) "value=0x%02x"
 via1_rtc_cmd_wprotect_write(int value) "value=0x%02x"
 via1_rtc_cmd_pram_read(int addr, int value) "addr=%u value=0x%02x"
 via1_rtc_cmd_pram_write(int addr, int value) "addr=%u value=0x%02x"
-via1_rtc_cmd_pram_sect_read(int sector, int offset, int addr, int value) "sector=%u offset=%u addr=%d value=0x%02x"
-via1_rtc_cmd_pram_sect_write(int sector, int offset, int addr, int value) "sector=%u offset=%u addr=%d value=0x%02x"
+via1_rtc_cmd_pram_sect_read(int sector, int offset, int addr, int value) "sector=%u offset=%u addr=0x%x value=0x%02x"
+via1_rtc_cmd_pram_sect_write(int sector, int offset, int addr, int value) "sector=%u offset=%u addr=0x%x value=0x%02x"
 via1_adb_send(const char *state, uint8_t data, const char *vadbint) "state %s data=0x%02x vADBInt=%s"
 via1_adb_receive(const char *state, uint8_t data, const char *vadbint, int status, int index, int size) "state %s data=0x%02x vADBInt=%s status=0x%x index=%d size=%d"
 via1_adb_poll(uint8_t data, const char *vadbint, int status, int index, int size) "data=0x%02x vADBInt=%s status=0x%x index=%d size=%d"
-- 
2.20.1



  reply	other threads:[~2021-03-11 10:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-11 10:04 [PATCH v2 0/7] mac_via: fixes and improvements Mark Cave-Ayland
2021-03-11 10:04 ` Mark Cave-Ayland [this message]
2021-03-11 10:05 ` [PATCH v2 2/7] mac_via: fix up adb_via_receive() trace events Mark Cave-Ayland
2021-03-11 10:05 ` [PATCH v2 3/7] mac_via: allow long accesses to VIA registers Mark Cave-Ayland
2021-03-11 10:05 ` [PATCH v2 4/7] mac_via: don't re-inject ADB response when switching to IDLE state Mark Cave-Ayland
2021-03-11 10:05 ` [PATCH v2 5/7] mac_via: rename VBL timer to 60Hz timer Mark Cave-Ayland
2021-03-11 10:39   ` BALATON Zoltan
2021-03-11 10:05 ` [PATCH v2 6/7] mac_via: fix 60Hz VIA1 timer interval Mark Cave-Ayland
2021-03-11 10:39   ` BALATON Zoltan
2021-03-11 10:05 ` [PATCH v2 7/7] mac_via: remove VIA1 timer optimisations Mark Cave-Ayland
2021-03-16 20:42 ` [PATCH v2 0/7] mac_via: fixes and improvements Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210311100505.22596-2-mark.cave-ayland@ilande.co.uk \
    --to=mark.cave-ayland@ilande.co.uk \
    --cc=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).