From: Igor Mammedov <imammedo@redhat.com>
To: no-reply@patchew.org
Cc: jusual@redhat.com, qemu-devel@nongnu.org, laine@redhat.com,
mst@redhat.com
Subject: Re: [PATCH 0/6] pc: support user provided NIC naming/indexing
Date: Mon, 15 Mar 2021 21:21:33 +0100 [thread overview]
Message-ID: <20210315212133.398c2dc9@redhat.com> (raw)
In-Reply-To: <161583340826.29026.17366591502722428122@c9d4d6fbb2f1>
On Mon, 15 Mar 2021 11:36:49 -0700 (PDT)
no-reply@patchew.org wrote:
> Patchew URL: https://patchew.org/QEMU/20210315180102.3008391-1-imammedo@redhat.com/
>
>
>
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
>
> Type: series
> Message-id: 20210315180102.3008391-1-imammedo@redhat.com
> Subject: [PATCH 0/6] pc: support user provided NIC naming/indexing
>
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> git rev-parse base > /dev/null || exit 0
> git config --local diff.renamelimit 0
> git config --local diff.renames True
> git config --local diff.algorithm histogram
> ./scripts/checkpatch.pl --mailback base..
> === TEST SCRIPT END ===
>
> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
> From https://github.com/patchew-project/qemu
> * [new tag] patchew/20210315180102.3008391-1-imammedo@redhat.com -> patchew/20210315180102.3008391-1-imammedo@redhat.com
> Switched to a new branch 'test'
> c0692b4 tests: acpi: update expected blobs
> 1a843d9 pci: acpi: add _DSM method to PCI devices
> 6b55586 acpi: add aml_to_decimalstring() and aml_call6() helpers
> 7b887f4 pci: acpi: ensure that acpi-index is unique
> 4056291 pci: introduce apci-index property for PCI device
> 9bd3a1b tests: acpi: temporary whitelist DSDT changes
>
> === OUTPUT BEGIN ===
> 1/6 Checking commit 9bd3a1b94c0f (tests: acpi: temporary whitelist DSDT changes)
> 2/6 Checking commit 40562915acde (pci: introduce apci-index property for PCI device)
> ERROR: Macros with complex values should be enclosed in parenthesis
> #284: FILE: include/hw/acpi/pcihp.h:77:
> +#define VMSTATE_PCI_HOTPLUG(pcihp, state, test_pcihp, test_acpi_index) \
> VMSTATE_UINT32_TEST(pcihp.hotplug_select, state, \
> test_pcihp), \
> VMSTATE_STRUCT_ARRAY_TEST(pcihp.acpi_pcihp_pci_status, state, \
> ACPI_PCIHP_MAX_HOTPLUG_BUS, \
> test_pcihp, 1, \
> vmstate_acpi_pcihp_pci_status, \
> - AcpiPciHpPciStatus)
> + AcpiPciHpPciStatus), \
> + VMSTATE_UINT32_TEST(pcihp.acpi_index, state, \
> + test_acpi_index)
probably false positive
(I don't know what's wrong here and how to fix it)
> total: 1 errors, 0 warnings, 197 lines checked
>
> Patch 2/6 has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
below warnings are intentional to follow comments style we use within aml-build.c
> 3/6 Checking commit 7b887f42419a (pci: acpi: ensure that acpi-index is unique)
> 4/6 Checking commit 6b555869ad66 (acpi: add aml_to_decimalstring() and aml_call6() helpers)
> WARNING: Block comments use a leading /* on a separate line
> #27: FILE: hw/acpi/aml-build.c:640:
> + Aml *var = aml_opcode(0x97 /* ToDecimalStringOp */);
>
> WARNING: Block comments use a leading /* on a separate line
> #32: FILE: hw/acpi/aml-build.c:645:
> + build_append_byte(var->buf, 0x00 /* NullNameOp */);
>
> total: 0 errors, 2 warnings, 55 lines checked
>
> Patch 4/6 has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 5/6 Checking commit 1a843d9de55e (pci: acpi: add _DSM method to PCI devices)
> WARNING: Block comments use a leading /* on a separate line
> #127: FILE: hw/i386/acpi-build.c:568:
> + 1 /* have supported functions */ |
>
> total: 0 errors, 1 warnings, 140 lines checked
>
> Patch 5/6 has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 6/6 Checking commit c0692b4b7df0 (tests: acpi: update expected blobs)
> === OUTPUT END ===
>
> Test command exited with code: 1
>
>
> The full log is available at
> http://patchew.org/logs/20210315180102.3008391-1-imammedo@redhat.com/testing.checkpatch/?type=message.
> ---
> Email generated automatically by Patchew [https://patchew.org/].
> Please send your feedback to patchew-devel@redhat.com
next prev parent reply other threads:[~2021-03-15 20:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 18:00 [PATCH 0/6] pc: support user provided NIC naming/indexing Igor Mammedov
2021-03-15 18:00 ` [PATCH 1/6] tests: acpi: temporary whitelist DSDT changes Igor Mammedov
2021-03-15 18:00 ` [PATCH 2/6] pci: introduce apci-index property for PCI device Igor Mammedov
2021-04-06 9:47 ` Daniel P. Berrangé
2021-04-06 17:38 ` Igor Mammedov
2021-05-14 13:37 ` Michael S. Tsirkin
2021-03-15 18:00 ` [PATCH 3/6] pci: acpi: ensure that acpi-index is unique Igor Mammedov
2021-03-15 18:01 ` [PATCH 4/6] acpi: add aml_to_decimalstring() and aml_call6() helpers Igor Mammedov
2021-03-15 18:01 ` [PATCH 5/6] pci: acpi: add _DSM method to PCI devices Igor Mammedov
2021-03-15 18:01 ` [PATCH 6/6] tests: acpi: update expected blobs Igor Mammedov
2021-03-15 18:36 ` [PATCH 0/6] pc: support user provided NIC naming/indexing no-reply
2021-03-15 20:21 ` Igor Mammedov [this message]
2021-05-14 13:32 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210315212133.398c2dc9@redhat.com \
--to=imammedo@redhat.com \
--cc=jusual@redhat.com \
--cc=laine@redhat.com \
--cc=mst@redhat.com \
--cc=no-reply@patchew.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).